Re: [systemd-devel] machines get killed when scopes are destroyed

2013-11-18 Thread Daniel P. Berrange
On Mon, Nov 18, 2013 at 03:03:18AM +0100, Zbigniew Jędrzejewski-Szmek wrote: v0lZy reported on IRC that his qemu machines get killed when shutting down the host. libvirt-guests.service is designed to suspend them during shutdown, but when it was run, the guests were all already dead. And

Re: [systemd-devel] French translation for systemd

2013-11-18 Thread Sylvain Plantefeve
Ok, thanks, I'll have a look at it. BTW, while re-reading the catalog again, I found a couple of typos... --- diff --git a/catalog/systemd-fr.catalog b/catalog/systemd-fr.catalog index 92cc15f..dd7af91 100644 --- a/catalog/systemd-fr.catalog +++ b/catalog/systemd-fr.catalog @@ -128,7 +128,7 @@

[systemd-devel] remove duplicate includes

2013-11-18 Thread Karel Zak
A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Karel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH 05/10] nss-myhostname: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/nss-myhostname/netlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/nss-myhostname/netlink.c b/src/nss-myhostname/netlink.c index 47a41f5..d61ecdf 100644 --- a/src/nss-myhostname/netlink.c +++ b/src/nss-myhostname/netlink.c @@ -31,7 +31,6 @@ #include limits.h #include

[systemd-devel] [PATCH 03/10] sysctl: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/sysctl/sysctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c index 67c7872..449e0ca 100644 --- a/src/sysctl/sysctl.c +++ b/src/sysctl/sysctl.c @@ -30,7 +30,6 @@ #include log.h #include strv.h #include util.h -#include strv.h #include

[systemd-devel] [PATCH 10/10] backlight: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/backlight/backlight.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c index 9ec29f7..bf76703 100644 --- a/src/backlight/backlight.c +++ b/src/backlight/backlight.c @@ -24,7 +24,6 @@ #include fileio.h #include libudev.h #include

[systemd-devel] [PATCH 04/10] shared: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/shared/label.c | 1 - src/shared/util.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/shared/label.c b/src/shared/label.c index 5c7cc1c..4a26ba9 100644 --- a/src/shared/label.c +++ b/src/shared/label.c @@ -20,7 +20,6 @@ ***/ #include errno.h -#include sys/stat.h #include

[systemd-devel] [PATCH 01/10] udev: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/udev/mtd_probe/probe_smartmedia.c | 1 - src/udev/v4l_id/v4l_id.c | 4 2 files changed, 5 deletions(-) diff --git a/src/udev/mtd_probe/probe_smartmedia.c b/src/udev/mtd_probe/probe_smartmedia.c index feadb50..a007cce 100644 --- a/src/udev/mtd_probe/probe_smartmedia.c

[systemd-devel] [PATCH 02/10] systemctl: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/systemctl/systemctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 737cd67..54479db 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -65,7 +65,6 @@ #include spawn-polkit-agent.h #include install.h

[systemd-devel] [PATCH 09/10] core: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/core/shutdown.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/shutdown.c b/src/core/shutdown.c index b5eb8b1..bcf2eec 100644 --- a/src/core/shutdown.c +++ b/src/core/shutdown.c @@ -24,7 +24,6 @@ #include sys/reboot.h #include linux/reboot.h #include sys/wait.h -#include

[systemd-devel] [PATCH 07/10] libudev: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/libudev/libudev-device-private.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libudev/libudev-device-private.c b/src/libudev/libudev-device-private.c index cba08d2..cb4947f 100644 --- a/src/libudev/libudev-device-private.c +++ b/src/libudev/libudev-device-private.c @@ -24,7

[systemd-devel] [PATCH 08/10] journal: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/journal/journalctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index a509104..c44be74 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -48,7 +48,6 @@ #include fileio.h #include build.h #include pager.h

Re: [systemd-devel] machines get killed when scopes are destroyed

2013-11-18 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 18, 2013 at 10:12:42AM +, Daniel P. Berrange wrote: I don't have an answer for you, but just want to ask that you file a bug against libvirt for this problem. This is an unintended regression in libvirt functionality with the switch to systemd scopes.

[systemd-devel] [PATCH] use #pragma once instead of foo*foo define guards

2013-11-18 Thread Shawn Landden
--- src/core/killall.h | 5 + src/core/switch-root.h | 5 + src/core/syscall-list.h | 5 + src/core/transaction.h | 5 + src/login/logind-action.h | 5 + src/login/logind-button.h | 5 + src/login/logind-inhibit.h | 5

Re: [systemd-devel] French translation for systemd

2013-11-18 Thread Jean-Michel Pollion
2013/11/18 Sylvain Plantefeve sylvain.plantef...@gmail.com Ok, thanks, I'll have a look at it. BTW, while re-reading the catalog again, I found a couple of typos... --- diff --git a/catalog/systemd-fr.catalog b/catalog/systemd-fr.catalog index 92cc15f..dd7af91 100644 ---

Re: [systemd-devel] systemd + ExecStart + python script

2013-11-18 Thread Abdelghani Ouchabane
On 12/11/13 18:40, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Nov 12, 2013 at 06:14:30PM +0100, Abdelghani Ouchabane wrote: On 11/11/13 17:32, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Nov 11, 2013 at 04:55:05PM +0100, Abdelghani Ouchabane wrote: ExecStart=/usr/bin/python

Re: [systemd-devel] systemd + ExecStart + python script

2013-11-18 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 18, 2013 at 05:56:47PM +0100, Abdelghani Ouchabane wrote: From my understanding I can combine PathChanged PathExists but it did not work for me. They must be *both* satisfied. I you want the unit to start when *either* is satisfied, you should use trigger conditions, written like

[systemd-devel] Patch to remap some hotkeys in Toshiba Satellite U940

2013-11-18 Thread Jose Ignacio Naranjo
Hi, I don't know if this is the right place to send this small patch. In case it is not the place, sorry for the noise (... and do you know the right place :)? Thanks). It is just just some remapping in hwdb for a few hotkeys. If you need any rework in the patch or whatever, please tell me.

[systemd-devel] [PATCH] hwdb: Support for Toshiba Satellite U940 hotkeys

2013-11-18 Thread Jose Ignacio Naranjo
--- hwdb/60-keyboard.hwdb | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hwdb/60-keyboard.hwdb b/hwdb/60-keyboard.hwdb index 995986d..72cb993 100644 --- a/hwdb/60-keyboard.hwdb +++ b/hwdb/60-keyboard.hwdb @@ -1034,6 +1034,13 @@

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-18 Thread Michael Stapelberg
Hi Martin, Martin Pitt martin.p...@ubuntu.com writes: Martin Pitt [2013-11-14 17:53 +0100]: So option 1 is to update the patch to not rely on uid, but instead always get it from PAM. I went through all instances of using the uid, username, or pw, and I cannot find any place in the PAM

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-18 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/16/2013 08:10 AM, Lennart Poettering wrote: On Thu, 14.11.13 15:43, Daniel J Walsh (dwa...@redhat.com) wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/14/2013 12:50 PM, Harald Hoyer wrote: On 11/05/2013 11:12 PM, Daniel J

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-18 Thread Michal Sekletar
On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/16/2013 08:10 AM, Lennart Poettering wrote: On Thu, 14.11.13 15:43, Daniel J Walsh (dwa...@redhat.com) wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-18 Thread Colin Walters
Hi, On Mon, 2013-11-18 at 21:59 +0100, Michael Stapelberg wrote: Therefore, I’d like to ask people with a commit bit (Colin?) to please have another look and merge the patch unless something is still wrong with it :). Thanks! This is on my radar; the patch wasn't working for me but I haven't

Re: [systemd-devel] [PATCH] use #pragma once instead of foo*foo define guards

2013-11-18 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 18, 2013 at 07:58:43AM -0800, Shawn Landden wrote: --- src/core/killall.h | 5 + src/core/switch-root.h | 5 + src/core/syscall-list.h | 5 + src/core/transaction.h | 5 + src/login/logind-action.h | 5 +

Re: [systemd-devel] remove duplicate includes

2013-11-18 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 18, 2013 at 02:48:14PM +0100, Karel Zak wrote: A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Wow. Applied in one big fell swoop. Zbyszek ___ systemd-devel

Re: [systemd-devel] [PATCH 5/7] libsystemd-bus: add sd_bus_get_selinux_ctx() and sd_bus_get_audit_session_data()

2013-11-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 15, 2013 at 07:32:21PM +0100, Daniel Mack wrote: Implementations for both org.freedesktop.DBus and kdbus are available --- src/libsystemd-bus/bus-control.c | 116 ++ src/libsystemd-bus/libsystemd-bus.sym | 2 + src/systemd/sd-bus.h

Re: [systemd-devel] [PATCH 7/7] systemd-stdio-bridge: make it socket-activatable and usable as kdbus bridge

2013-11-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 15, 2013 at 07:32:23PM +0100, Daniel Mack wrote: Augment systemd-stdio-bridge a bit to make it a 1:1 bridge from legacy DBus clients to kdbus. In particular, * allow setting the bus path of the upstream bus as command line argument * use sd_listen_fds() for systemd's socket

Re: [systemd-devel] Need help with a systemd/mdadm interaction.

2013-11-18 Thread NeilBrown
On Thu, 14 Nov 2013 11:23:30 +0600 Alexander E. Patrakov patra...@gmail.com wrote: NeilBrown пишет: On Wed, 13 Nov 2013 22:11:27 +0600 Alexander E. Patrakov patra...@gmail.com wrote: 2013/11/13 NeilBrown ne...@suse.de: On Tue, 12 Nov 2013 19:01:49 +0400 Andrey Borzenkov

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-18 Thread Martin Pitt
Hello Colin, Colin Walters [2013-11-18 19:35 -0500]: This is on my radar; the patch wasn't working for me but I haven't had time to add debug prints and figure out whether it's my (gnome-continuous) side or something else. Give me a day or two. Did you just try the original patch that I sent

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-18 Thread David Timothy Strauss
I'm pretty confident in the accuracy of the controller mask aggregation, especially given the new unit test. Here are the main review questions. Is it okay to couple realizing the cgroups and applying the attributes the way the patch does? Before, we were often applying the attributes for all of

Re: [systemd-devel] Patch to remap some hotkeys in Toshiba Satellite U940

2013-11-18 Thread Martin Pitt
Hello Jose, Jose Ignacio Naranjo [2013-11-18 19:30 +0100]: I don't know if this is the right place to send this small patch. It is. It is just just some remapping in hwdb for a few hotkeys. If you need any rework in the patch or whatever, please tell me. Looks good, thank you! Applied with