Re: [systemd-devel] [PATCH] cgroup: After MemmoryAccounting=yes running scope has no memusage

2014-04-09 Thread David Timothy Strauss
+1 from me. Seems like a good bugfix. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Move use of locale_t to different shared file, so that udev can still be built without it (MinimalBuild)

2014-04-09 Thread Samuli Suominen
On 08/04/14 19:16, Cristian Rodríguez wrote: El 08/04/14 03:04, Samuli Suominen escribió: This is the *only* patch we are carrying for udev currently, otherwise uClibc builds work fine, so please at least consider what I just said. All this locale_t thing is standarized in POSIX 2008, . it

Re: [systemd-devel] Netconsole NG

2014-04-09 Thread poma
On 08.04.2014 23:27, poma wrote: On 08.04.2014 14:25, Tom Gundersen wrote: On Tue, Apr 8, 2014 at 2:10 PM, poma pomidorabelis...@gmail.com wrote: On 08.04.2014 04:03, poma wrote: On 07.04.2014 19:55, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Apr 07, 2014 at 05:34:10PM +0200, Lukáš Nykrýn

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-09 Thread Karel Zak
On Fri, Apr 04, 2014 at 05:30:03PM -0400, Vivek Goyal wrote: What happens if nofail is specified and device is present and there are file system errors. Will fsck continue with boot or drop user into a shell during boot and force to fix file system failures? fsck cares about nofail option only

Re: [systemd-devel] [PATCH] Document CONFIG_NET_NS as a required kernel option

2014-04-09 Thread Tom Gundersen
On Mon, Mar 31, 2014 at 8:28 PM, Mike Gilbert flop...@gentoo.org wrote: Several units now utilize the PrivateNetwork parameter, which requires network namespace support. Applied. Thanks! Cheers, Tom ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-09 Thread WANG Chao
On 04/08/14 at 06:02pm, Vivek Goyal wrote: On Tue, Apr 08, 2014 at 02:14:33AM +0200, Zbigniew Jędrzejewski-Szmek wrote: [..] Defining a new target which by default waits for all the local fs target sounds interesting. Again, I have the question, what will happen to

[systemd-devel] [KDBUS PATCH] remove unused variable

2014-04-09 Thread Daniel Buch
--- connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection.c b/connection.c index 2d69f17..5e7d553 100644 --- a/connection.c +++ b/connection.c @@ -1024,7 +1024,7 @@ int kdbus_cmd_msg_recv(struct kdbus_conn *conn, /* just drop the message */

Re: [systemd-devel] [KDBUS PATCH] remove unused variable

2014-04-09 Thread Daniel Mack
On 04/09/2014 11:43 AM, Daniel Buch wrote: --- connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection.c b/connection.c index 2d69f17..5e7d553 100644 --- a/connection.c +++ b/connection.c @@ -1024,7 +1024,7 @@ int kdbus_cmd_msg_recv(struct kdbus_conn

Re: [systemd-devel] [KDBUS PATCH] remove unused variable

2014-04-09 Thread Daniel Buch
No problem :) 2014-04-09 11:46 GMT+02:00 Daniel Mack dan...@zonque.org: On 04/09/2014 11:43 AM, Daniel Buch wrote: --- connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection.c b/connection.c index 2d69f17..5e7d553 100644 --- a/connection.c

[systemd-devel] [PATCH] metadata: reflect change in task_cgroup_name

2014-04-09 Thread Hristo Venev
Change: e61734c55c24cdf11b07e52a74aec4dc4a7f4bd0. Merged: dc5ed40686a4da95881c35d913b60f867755cbe2 in 3.15-rc1. task_cgroup_name returns a pointer to the path or NULL if there is not enough space in the buffer (used to return nonnegative or -ENAMETOOLONG). On systemd systems fixes a kernel panic

Re: [systemd-devel] [PATCH] metadata: reflect change in task_cgroup_name

2014-04-09 Thread Daniel Mack
On 04/09/2014 02:16 PM, Hristo Venev wrote: Change: e61734c55c24cdf11b07e52a74aec4dc4a7f4bd0. Merged: dc5ed40686a4da95881c35d913b60f867755cbe2 in 3.15-rc1. task_cgroup_name returns a pointer to the path or NULL if there is not enough space in the buffer (used to return nonnegative or

[systemd-devel] [PATCH] fsck: Search for fsck.type in PATH

2014-04-09 Thread Mike Gilbert
Matches default behavior in recent util-linux. --- src/fsck/fsck.c| 6 -- src/shared/generator.c | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/fsck/fsck.c b/src/fsck/fsck.c index 18f2aca..24c8890 100644 --- a/src/fsck/fsck.c +++ b/src/fsck/fsck.c @@

Re: [systemd-devel] [PATCH] Document CONFIG_NET_NS as a required kernel option

2014-04-09 Thread Lennart Poettering
On Wed, 09.04.14 11:21, Tom Gundersen (t...@jklm.no) wrote: On Mon, Mar 31, 2014 at 8:28 PM, Mike Gilbert flop...@gentoo.org wrote: Several units now utilize the PrivateNetwork parameter, which requires network namespace support. BTW, this really sounds like something where we should have

Re: [systemd-devel] Move use of locale_t to different shared file, so that udev can still be built without it (MinimalBuild)

2014-04-09 Thread Lennart Poettering
On Wed, 09.04.14 09:40, Samuli Suominen (ssuomi...@gentoo.org) wrote: This is the *only* patch we are carrying for udev currently, otherwise uClibc builds work fine, so please at least consider what I just said. All this locale_t thing is standarized in POSIX 2008, . it is up to the

[systemd-devel] [PATCH] nspawn: Fix erroneous OOM when building group list

2014-04-09 Thread Philip Lorenz
change_uid_gid() never initialises sz which may cause greedy_realloc to skip the initial buffer allocation. --- src/nspawn/nspawn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index 84724d5..0bd52da 100644 --- a/src/nspawn/nspawn.c

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 9:47 PM, Richard Weinberger rich...@nod.at wrote: At least LXC does not allow the container root to change the OOM Score adjust value. Signed-off-by: Richard Weinberger rich...@nod.at --- Hi! Within Linux containers we cannot use OOMScoreAdjust nor

Re: [systemd-devel] [PATCH] metadata: reflect change in task_cgroup_name

2014-04-09 Thread Hristo Venev
On Wed, 2014-04-09 at 15:04 +0200, Daniel Mack wrote: Eh. Thanks for spotting this. However, I think we should have a compat workaround for 3.14, for at least a couple of weeks. We can drop it after that. Could you amend your patch for that? How do I check if the kernel version is 3.14.0 or

Re: [systemd-devel] [PATCH] metadata: reflect change in task_cgroup_name

2014-04-09 Thread Daniel Mack
On 04/09/2014 07:20 PM, Hristo Venev wrote: On Wed, 2014-04-09 at 15:04 +0200, Daniel Mack wrote: Eh. Thanks for spotting this. However, I think we should have a compat workaround for 3.14, for at least a couple of weeks. We can drop it after that. Could you amend your patch for that? How

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Richard Weinberger
Am 09.04.2014 19:19, schrieb Tom Gundersen: On Mon, Apr 7, 2014 at 9:47 PM, Richard Weinberger rich...@nod.at wrote: At least LXC does not allow the container root to change the OOM Score adjust value. Signed-off-by: Richard Weinberger rich...@nod.at --- Hi! Within Linux containers we

Re: [systemd-devel] [PATCH] metadata: reflect change in task_cgroup_name

2014-04-09 Thread Djalal Harouni
On Wed, Apr 09, 2014 at 07:28:42PM +0200, Daniel Mack wrote: On 04/09/2014 07:20 PM, Hristo Venev wrote: On Wed, 2014-04-09 at 15:04 +0200, Daniel Mack wrote: Eh. Thanks for spotting this. However, I think we should have a compat workaround for 3.14, for at least a couple of weeks. We can

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-09 Thread Vivek Goyal
On Wed, Apr 09, 2014 at 05:36:13PM +0800, WANG Chao wrote: On 04/08/14 at 06:02pm, Vivek Goyal wrote: On Tue, Apr 08, 2014 at 02:14:33AM +0200, Zbigniew Jędrzejewski-Szmek wrote: [..] Defining a new target which by default waits for all the local fs target sounds

[systemd-devel] Trying to debug bug 76468

2014-04-09 Thread Umut Tezduyar Lindskog
Hi, Trying to debug https://bugs.freedesktop.org/show_bug.cgi?id=76468 which seems to be sd_bus related. Problem is happening when we mark the sd_event as SD_EVENT_FINISHED and then tring to call sd_event_source_set_enabled on an event source that belongs to FINISHED sd_event. Inside the

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Tom Gundersen
On Wed, Apr 9, 2014 at 7:39 PM, Richard Weinberger rich...@nod.at wrote: Am 09.04.2014 19:19, schrieb Tom Gundersen: On Mon, Apr 7, 2014 at 9:47 PM, Richard Weinberger rich...@nod.at wrote: At least LXC does not allow the container root to change the OOM Score adjust value. Signed-off-by:

Re: [systemd-devel] LXC not working with systemd 209 or later

2014-04-09 Thread Leonid Isaev
Hi, On Sat, 05 Apr 2014 22:04:05 +0100 John Lane syst...@jelmail.com wrote: [...] Ok, now this is wierd. I have distilled the problem down to the bare bones. I have a build_container script (http://pastebin.com/raw.php?i=RhDFhRZi) that will create a container called testcontainer. It

Re: [systemd-devel] [PATCH] Add Mir to the list of session types

2014-04-09 Thread David Herrmann
Hi On Thu, Apr 3, 2014 at 10:46 PM, Robert Ancell robert.anc...@canonical.com wrote: Add Mir to the list of session types. This is implemented for LightDM in lp:~robert-ancell/lightdm/xdg-session-desktop [1]. [1]

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Richard Weinberger
Am 09.04.2014 20:28, schrieb Tom Gundersen: On Wed, Apr 9, 2014 at 7:39 PM, Richard Weinberger rich...@nod.at wrote: Am 09.04.2014 19:19, schrieb Tom Gundersen: On Mon, Apr 7, 2014 at 9:47 PM, Richard Weinberger rich...@nod.at wrote: At least LXC does not allow the container root to change

Re: [systemd-devel] [PATCH] cgroup: After MemmoryAccounting=yes running scope has no memusage

2014-04-09 Thread Lennart Poettering
On Tue, 08.04.14 12:11, Stef Walter (s...@thewalter.net) wrote: Setting the 'MemoryAccounting' unit property to true, puts the unit into the right cgroup but does the memory.usage_in_bytes does not reflect the pages already allocated to the processes in that cgroup. This is because the

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Cristian Rodríguez
El 09/04/14 16:41, Richard Weinberger escribió: e other things like this too I suppose). Okay, I'll send patches for OOMScoreAdjust and other settings to ignore failures. This way systemd can also support containers without user namespaces. No matter how useful these are. (hello docker.io

Re: [systemd-devel] [PATCH] Document CONFIG_NET_NS as a required kernel option

2014-04-09 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 09, 2014 at 07:35:15PM -0400, Mike Gilbert wrote: On Wed, Apr 9, 2014 at 12:32 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 09.04.14 11:21, Tom Gundersen (t...@jklm.no) wrote: On Mon, Mar 31, 2014 at 8:28 PM, Mike Gilbert flop...@gentoo.org wrote: Several

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-09 Thread Andrey Borzenkov
В Wed, 9 Apr 2014 13:49:47 -0400 Vivek Goyal vgo...@redhat.com пишет: On Wed, Apr 09, 2014 at 05:36:13PM +0800, WANG Chao wrote: On 04/08/14 at 06:02pm, Vivek Goyal wrote: On Tue, Apr 08, 2014 at 02:14:33AM +0200, Zbigniew Jędrzejewski-Szmek wrote: [..] Defining a new

[systemd-devel] [PATCH] units: add ConditionPathIsReadWrite for systemd-random-seed.service

2014-04-09 Thread Jonathan Liu
--- units/systemd-random-seed.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/units/systemd-random-seed.service.in b/units/systemd-random-seed.service.in index 1879b2f..cbe000c 100644 --- a/units/systemd-random-seed.service.in +++ b/units/systemd-random-seed.service.in @@ -13,6

Re: [systemd-devel] [PATCH] cgroup: After MemmoryAccounting=yes running scope has no memusage

2014-04-09 Thread Stef Walter
On 09.04.2014 23:45, Lennart Poettering wrote: On Tue, 08.04.14 12:11, Stef Walter (s...@thewalter.net) wrote: Setting the 'MemoryAccounting' unit property to true, puts the unit into the right cgroup but does the memory.usage_in_bytes does not reflect the pages already allocated to the