Re: [systemd-devel] RFC: idea for a pstore systemd service

2019-01-17 Thread Eric DeVolder
Lennart, I've some homework to do based on your feedback and will report back. As I understand it, I need to do this in C as well. Regards, eric On 1/15/19 12:49 PM, Lennart Poettering wrote: On Di, 15.01.19 11:23, Eric DeVolder (eric.devol...@oracle.com) wrote: Systemd-devel, Below

[systemd-devel] RFC: idea for a pstore systemd service

2019-01-15 Thread Eric DeVolder
Systemd-devel, Below is a write-up I've done to explain a new service for archiving pstore contents. I've attached the pstore.service files (/lib/systemd/system/pstore.service and bin/pstore-tool). These are trivial right now, but easy to build upon if periodic, rather than just on-boot,

Re: [systemd-devel] RFC: idea for a pstore systemd service

2019-02-21 Thread Eric DeVolder
On 1/16/19 12:30 PM, Lennart Poettering wrote: On Di, 15.01.19 23:39, J├│hann B. Gu├░mundsson (johan...@gmail.com) wrote: [Service] ExecStart=/bin/bash -c '/usr/bin/mv -t /var/lib/pstore /sys/fs/pstore/*' Restart=on-success While this would certainly work, I think I'd prefer a version in C

Re: [systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-06-10 Thread Eric DeVolder
Hi Lennart, I've applied the coding style guidelines, and created a pull request #12768 via GitHub. Let me know what I may have done wrong, my first attempt via GitHub. Thanks, eric On 5/16/19 9:34 AM, Lennart Poettering wrote: On Do, 16.05.19 09:28, Eric DeVolder (eric.devol...@oracle.com

[systemd-devel] [PATCH 1/6] pstore: Add new pstore tool/service to the build

2019-05-16 Thread Eric DeVolder
This change adds the src/pstore directory to the build files. Signed-off-by: Eric DeVolder --- meson.build | 29 + meson_options.txt | 2 ++ units/meson.build | 1 + 3 files changed, 32 insertions(+) diff --git a/meson.build b/meson.build index eaf0edd

[systemd-devel] [PATCH 5/6] pstore: The new pstore archive service file

2019-05-16 Thread Eric DeVolder
The necessary systemd service file which invokes the pstore archival tool upon boot as well as shutdown (poweroff, reboot). Signed-off-by: Eric DeVolder --- units/systemd-pstore.service.in | 32 1 file changed, 32 insertions(+) create mode 100644 units/systemd

[systemd-devel] [PATCH 6/6] pstore: The new documentation for the pstore configuration file

2019-05-16 Thread Eric DeVolder
The xml file for the systemd pstore tool configuration file. Signed-off-by: Eric DeVolder --- man/pstore.conf.xml | 100 1 file changed, 100 insertions(+) create mode 100644 man/pstore.conf.xml diff --git a/man/pstore.conf.xml b/man

[systemd-devel] [PATCH 2/6] pstore: Add new pstore tool/service to the build

2019-05-16 Thread Eric DeVolder
This new file is invoked by the build system to build pstore. Signed-off-by: Eric DeVolder --- src/pstore/meson.build | 21 + 1 file changed, 21 insertions(+) create mode 100644 src/pstore/meson.build diff --git a/src/pstore/meson.build b/src/pstore/meson.build new file

[systemd-devel] [PATCH 3/6] pstore: The new systemd-pstore tool to archive pstore contents

2019-05-16 Thread Eric DeVolder
to determine which dmesg it is a part - the file is either moved to archive storage or recorded in the journal - the file is appended to the reconstructed dmesg Signed-off-by: Eric DeVolder --- src/pstore/pstore.c | 736 1 file changed, 736

[systemd-devel] [PATCH 4/6] pstore: The new configuration file for systemd-pstore tool

2019-05-16 Thread Eric DeVolder
ts. The default is "/var/lib/systemd/pstore". - AllowUnlink : is one of "yes" or "no". When "yes", the default, then files in the pstore are removed once processed. When "no", processing of the pstore occurs normally, but the pstor

[systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-05-16 Thread Eric DeVolder
be an early look/review to ensure I'm headed down the desired path per maintainers. --- v1 16may2019 - sent to systemd-devel@lists.freedesktop.org for early/initial review Eric DeVolder (6): pstore: Add new pstore tool/service to the build pstore: Add new pstore tool/service to the build ps

Re: [systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-05-16 Thread Eric DeVolder
OK, will do! eric On 5/16/19 9:34 AM, Lennart Poettering wrote: On Do, 16.05.19 09:28, Eric DeVolder (eric.devol...@oracle.com) wrote: Could you please submit this via github as PR? Review is so much nicer there, in particular for complex patch sets, and this qualifies as complex I think

[systemd-devel] [RFC] pstore: options to enable kernel writing into the pstore

2020-03-11 Thread Eric DeVolder
Systemd-devel, Below is a proposal for adding a couple of settings to the systemd pstore service so that it can enable the kernel parameters that allow the kernel to write into the pstore. Regards, eric From 837d716c6e7ed02518a399356df95bf7c47e1772 Mon Sep 17 00:00:00 2001 From: Eric DeVolder

Re: [systemd-devel] [RFC] pstore: options to enable kernel writing into the pstore

2020-03-26 Thread Eric DeVolder
Hi, thought I would try again... eric On 3/11/20 2:37 PM, Eric DeVolder wrote: Systemd-devel, Below is a proposal for adding a couple of settings to the systemd pstore service so that it can enable the kernel parameters that allow the kernel to write into the pstore. Regards, eric From