Re: [systemd-devel] [PATCH] sd-dhcp-client: prevent timer related memory leaks

2014-02-21 Thread Tom Gundersen
On 21 Feb 2014 03:22, Lennart Poettering lenn...@poettering.net wrote: On Thu, 20.02.14 21:04, Umut Tezduyar Lindskog (umut.tezdu...@axis.com) wrote: Tom commited this. Thanks! Tom, please always do a quick reply on the ML so that it is easy to see what is commited and what is not! Sorry

Re: [systemd-devel] [PATCH] install: Do not enable systemd-networkd by default

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 1:53 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 21.02.14 04:38, Jason A. Donenfeld (ja...@zx2c4.com) wrote: systemd-network.service should not be started unless the administrator runs systemctl enable systemd-network.service, as it's entirely

Re: [systemd-devel] Unmentioned 209 change: 80-net-name-slot.rules is gone

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 3:29 AM, Jason A. Donenfeld ja...@zx2c4.com wrote: Hey guys, This commit caught me by surprise: http://git.zx2c4.com/systemd/commit/?id=daeb71a36a98834664e4d95773a3629b746f4db8 It wasn't in the NEWS or the mailing list post for 209, so when updating I

Re: [systemd-devel] [patch] Install 99-default.link to rootprefix instead of prefix (as required)

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 3:27 PM, Samuli Suominen ssuomi...@gentoo.org wrote: By passing --rootprefix= you can get systemd-udevd installed to /lib/systemd, as opposed to /usr/lib/systemd And by logic, network configuration is needed to accompany the daemon since /usr might not be mounted yet,

Re: [systemd-devel] [PATCH] install: networkd.service depend on !--disable

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 4:36 PM, Jason A. Donenfeld ja...@zx2c4.com wrote: It doesn't make any sense to symlink this unit file into /etc when the unit file itself isn't even installed, with --disable-networkd. This moves the GENERAL_ALIASES logic into the right if block. Applied. Thanks!

Re: [systemd-devel] [PATCH] install: Do not enable systemd-networkd by default

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 4:44 PM, Michael Biebl mbi...@gmail.com wrote: 2014-02-21 16:31 GMT+01:00 Jason A. Donenfeld ja...@zx2c4.com: On Fri, Feb 21, 2014 at 4:19 PM, Lennart Poettering lenn...@poettering.net wrote: Well, ultimately it's up the distributions to decide what they want to

Re: [systemd-devel] [PATCH] install: Do not enable systemd-networkd by default

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 4:31 PM, Jason A. Donenfeld ja...@zx2c4.com wrote: On Fri, Feb 21, 2014 at 4:19 PM, Lennart Poettering lenn...@poettering.net wrote: Well, ultimately it's up the distributions to decide what they want to enable and what not. True, but this requires manual patching

Re: [systemd-devel] [PATCH] install: Do not enable systemd-networkd by default

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 5:10 PM, Jason A. Donenfeld ja...@zx2c4.com wrote: On Fri, Feb 21, 2014 at 5:03 PM, Tom Gundersen t...@jklm.no wrote: We'd have to look in all the possible folders, and there may (and due to 99-deafult.link, always will) be files there, so we don't really have

Re: [systemd-devel] [PATCH] man: networkd typo fixes

2014-02-21 Thread Tom Gundersen
On Fri, Feb 21, 2014 at 8:54 PM, Thomas H.P. Andersen pho...@gmail.com wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --- Not too sure about the bridge - netdev change. It just seemed a strange to read since we set the type a bit later to be either bridge, bond, or vlan.

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2014-02-22 Thread Tom Gundersen
On Wed, Nov 13, 2013 at 3:58 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 12.11.13 05:49, Jan Engelhardt (jeng...@inai.de) wrote: Given a card that can do 100 Mbit/s, that would be about 12.5 MByte/s, but you cannot seriously expect me to use that value. Although it is quite

Re: [systemd-devel] Unmentioned 209 change: 80-net-name-slot.rules is gone

2014-02-23 Thread Tom Gundersen
On Sun, Feb 23, 2014 at 3:18 PM, Dave Reisner d...@falconindy.com wrote: On Fri, Feb 21, 2014 at 05:12:56PM +0100, Jason A. Donenfeld wrote: To clarify things: 1. Arch's script deals with 80-net-setup-link.rules We (Arch) made a decision back when the persistent naming was added to make it

Re: [systemd-devel] Unmentioned 209 change: 80-net-name-slot.rules is gone

2014-02-23 Thread Tom Gundersen
On Mon, Feb 24, 2014 at 12:13 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: I've now added a paragraph about this change to NEWS. Not sure what to do in the Fedora package though. Why not do the same as in the Arch package? Are there any drawbacks? I thought that should cover

Re: [systemd-devel] [PATCH] fix typo in iDRAC network interface name: irdac-idrac

2014-02-25 Thread Tom Gundersen
On Tue, Feb 25, 2014 at 12:43 PM, Tomasz Torcz to...@pipebreaker.pl wrote: --- hwdb/20-net-ifname.hwdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hwdb/20-net-ifname.hwdb b/hwdb/20-net-ifname.hwdb index 29d2633..2408dc1 100644 --- a/hwdb/20-net-ifname.hwdb +++

Re: [systemd-devel] [PATCH] sd-dhcp: implement IPv4 link-local support

2014-02-27 Thread Tom Gundersen
On Thu, Feb 27, 2014 at 11:28 PM, David Timothy Strauss da...@davidstrauss.net wrote: This is a lot of code, and this approach is largely obsoleted by link-local IPv6 addressing, which also has the benefits of being simpler, deterministic (at least with RFC 4862), and collision-proof. Both

Re: [systemd-devel] [PATCH] sd-dhcp: implement IPv4 link-local support

2014-02-28 Thread Tom Gundersen
On Fri, Feb 28, 2014 at 9:05 AM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: If an IPv4LL address has been acquired, and then a DHCP server becomes available, do we really want to drop the address entirely? At least for IPv6 there's this concept of deprecated addresses for this

Re: [systemd-devel] [PATCH] sd-dhcp: implement IPv4 link-local support

2014-02-28 Thread Tom Gundersen
On Fri, Feb 28, 2014 at 2:24 PM, Lennart Poettering lenn...@poettering.net wrote: If you stop LL state machine and start again, then you will go through the probe/announce/defend process anyways. Tell you the truth I didn't quite understand your question. Well, in embedded environments

Re: [systemd-devel] [PATCH] sd-dhcp: implement IPv4 link-local support

2014-02-28 Thread Tom Gundersen
On Fri, Feb 28, 2014 at 2:39 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 28.02.14 14:34, Tom Gundersen (t...@jklm.no) wrote: On Fri, Feb 28, 2014 at 2:24 PM, Lennart Poettering lenn...@poettering.net wrote: If you stop LL state machine and start again, then you will go

Re: [systemd-devel] Creating a Release Tarball

2014-03-01 Thread Tom Gundersen
On Sat, Mar 1, 2014 at 8:36 AM, Justin Brown justin.br...@fandingo.org wrote: commands to prep the repository before creating the tarball. Could someone enlighten me what steps need to be taken before building the RPM? $ make distcheck should create a tarball for you. Cheers, Tom

Re: [systemd-devel] Satitic IP in container

2014-03-01 Thread Tom Gundersen
On Sat, Mar 1, 2014 at 9:18 AM, arnaud gaboury arnaud.gabo...@gmail.com wrote: I set up successful a Arch container managed by systemd-nspsawn. I have an issue setting an IP for the container. My host is Arch, running custom Kernel 3.13.5-1 (userspace is set) and systemd-git (lats updated

Re: [systemd-devel] Satitic IP in container

2014-03-01 Thread Tom Gundersen
On Sat, Mar 1, 2014 at 2:28 PM, arnaud gaboury arnaud.gabo...@gmail.com wrote: I suggest simply matching on the name instead: Name=host0. I have a problem with this host0. On container, no host0 listed. If I remember correcty, I shall start systemd-nspawn with some more options, like

Re: [systemd-devel] binding tmpfiles.d to unit startup

2014-03-01 Thread Tom Gundersen
On Sat, Mar 1, 2014 at 8:04 PM, Michael Biebl mbi...@gmail.com wrote: 2014-03-01 19:47 GMT+01:00 Colin Walters walt...@verbum.org: On Sat, Mar 1, 2014 at 1:44 PM, Michael Biebl mbi...@gmail.com wrote: I vaguely remember that we exactly had this discussion a while ago. Argh, yes, possibly.

Re: [systemd-devel] [PATCH] networkd-wait-online: use automatic cleanup

2014-03-01 Thread Tom Gundersen
On Sat, Mar 1, 2014 at 10:52 PM, Thomas H.P. Andersen pho...@gmail.com wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --- Only compile tested. I just wanted to get rid of the warnings about use of the uninitialized variables. Applied. Thanks! -t Makefile.am

Re: [systemd-devel] [PATCH] man: networkd - fix typo

2014-03-03 Thread Tom Gundersen
Applied. Thanks! -t On Mon, Mar 3, 2014 at 9:13 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: --- man/systemd-networkd.service.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-networkd.service.xml b/man/systemd-networkd.service.xml index

Re: [systemd-devel] [PATCH] restore support for enslaving to bonding interface

2014-03-05 Thread Tom Gundersen
Hi Mark, On Wed, Mar 5, 2014 at 1:41 AM, Mark Oteiza mvote...@udel.edu wrote: networkd: Restore logic for enslaving to a master bonding interface. Applied. Thanks! Bonding support seems to have been removed right after being added, between 52433f6 (22 Jan) and 54abf46 (25 Jan).

Re: [systemd-devel] [PATCH] man: ipv4 link-local

2014-03-05 Thread Tom Gundersen
Applied. Thanks! -t On Wed, Mar 5, 2014 at 8:51 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: --- TODO|1 - man/systemd.network.xml |9 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/TODO b/TODO index fd75eab..dbfe48e 100644

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd src/network

2014-03-08 Thread Tom Gundersen
On Sat, Mar 8, 2014 at 6:23 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Mar 07, 2014 at 04:13:06PM -0800, Tom Gundersen wrote: src/libsystemd/sd-rtnl/rtnl-internal.h |2 +- src/network/networkd-link.c|6 ++ 2 files changed, 3 insertions(+), 5

Re: [systemd-devel] 'systemd.link.xml' recovery

2014-03-09 Thread Tom Gundersen
On Sun, Mar 9, 2014 at 5:20 PM, poma pomidorabelis...@gmail.com wrote: 'man/systemd.link.xml' recovery from: commit eac684ef1c29684b1bcd27a89c38c202e568e469 Author: Tom Gundersen t...@jklm.no Date: Tue Feb 25 19:30:40 2014 +0100 man: split out systemd.net{work,dev}(5) from systemd

Re: [systemd-devel] [PATCH] machine-id: add --root option to operate on an alternate fs tree

2014-03-14 Thread Tom Gundersen
On Fri, Mar 14, 2014 at 5:43 AM, Greg KH gre...@linuxfoundation.org wrote: This makes it possible to initialize the /etc/machine-id file on an arbitrary filesystem hierarchy. This helps systems that wish to run this at image creation time in a subdirectory, or from initramfs before pivot-root

Re: [systemd-devel] [PATCH] networkd: fix typo

2014-03-14 Thread Tom Gundersen
On Fri, Mar 14, 2014 at 6:19 PM, Michael Olbrich m.olbr...@pengutronix.de wrote: It's HAVE_SPLIT_USR not HAVE_SPLIT_USER Applied. Thanks! src/network/networkd-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/networkd-manager.c

Re: [systemd-devel] [PATCH 2/4] libsystemd-network: Add hangcheck timer for DHCP client test

2014-03-14 Thread Tom Gundersen
On Thu, Mar 13, 2014 at 12:01 PM, Patrik Flykt patrik.fl...@linux.intel.com wrote: --- src/libsystemd-network/test-dhcp-client.c | 16 1 file changed, 16 insertions(+) diff --git a/src/libsystemd-network/test-dhcp-client.c b/src/libsystemd-network/test-dhcp-client.c index

Re: [systemd-devel] The Bridge on the River PID EINS

2014-03-16 Thread Tom Gundersen
On Mon, Mar 10, 2014 at 9:12 PM, Umut Tezduyar u...@tezduyar.com wrote: I tried out a similar configuration and couldn't get the bridge up. I tried it on Arch with systemd 210. bridge.netdev [NetDev] Name=bridge0 Kind=bridge u.network [NetDev] Name=bridge0 Kind=bridge Further

Re: [systemd-devel] The Bridge on the River PID EINS

2014-03-16 Thread Tom Gundersen
On Sun, Mar 9, 2014 at 5:58 AM, poma pomidorabelis...@gmail.com wrote: % STATIC OK! $ ll /etc/systemd/network/ ... enp3s0.network $ cat /etc/systemd/network/enp3s0.network [Match] Name=enp3s0 [Network]

Re: [systemd-devel] unable to bring an interface UP with systemd-networkd

2014-03-16 Thread Tom Gundersen
On Tue, Mar 11, 2014 at 6:42 PM, arnaud gaboury arnaud.gabo...@gmail.com wrote: I run a dahlia container on a hortensia machine. Both are Arch boxes, and container is managed with nspawn and networkd. When I boot the hortensia machine, part of the ip addr output is : gabx@hortensia ➤➤ ~ % ip

Re: [systemd-devel] unable to bring an interface UP with systemd-networkd

2014-03-16 Thread Tom Gundersen
On Tue, Mar 11, 2014 at 6:42 PM, arnaud gaboury arnaud.gabo...@gmail.com wrote: Hi, I run a dahlia container on a hortensia machine. Both are Arch boxes, and container is managed with nspawn and networkd. When I boot the hortensia machine, part of the ip addr output is : gabx@hortensia ➤➤

Re: [systemd-devel] unable to bring an interface UP with systemd-networkd

2014-03-16 Thread Tom Gundersen
On Sun, Mar 16, 2014 at 6:00 PM, arnaud gaboury arnaud.gabo...@gmail.com wrote: So we were not automatically upping the bridged interface from nspawn. I pushed a change to git just now which does that. Thanks for testing. Tom Correct. The only way for me to bring it up at boot is to create a

Re: [systemd-devel] The Bridge on the River PID EINS

2014-03-17 Thread Tom Gundersen
On Mon, Mar 17, 2014 at 2:44 AM, poma pomidorabelis...@gmail.com wrote: On 17.03.2014 00:34, Kai Krakow wrote: poma pomidorabelis...@gmail.com schrieb: On 09.03.2014 11:39, Kai Krakow wrote: poma pomidorabelis...@gmail.com schrieb: BRIDGED !? $ ll /etc/systemd/network/ ... bridge0.netdev

Re: [systemd-devel] The Bridge on the River PID EINS

2014-03-17 Thread Tom Gundersen
On Mon, Mar 17, 2014 at 8:20 PM, poma pomidorabelis...@gmail.com wrote: On 17.03.2014 09:07, Tom Gundersen wrote: ... What you probably want is something like this: $ ll /etc/systemd/network/ ... bridge0.netdev ... bridge0.network ... enp3s0.network $ cat /etc/systemd/network/enp3s0

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-17 Thread Tom Gundersen
Hi Henrik, On Mon, Mar 17, 2014 at 5:01 PM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: Dear all, *SUMMARY* I am trying to replace dhcpcd with systemd-networkd. Using systemd-networkd on a single physical interface works fine. However, trying to use DHCP on a bridge fails for me. Any

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-17 Thread Tom Gundersen
On Mon, Mar 17, 2014 at 10:21 PM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: Hi Tom, Thanks for your feedback... I was briefly looking through git commits after 211 without finding anything related. But then again I did not look into too much detail. Do you know which commit would

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-18 Thread Tom Gundersen
On Tue, Mar 18, 2014 at 10:00 AM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: On 03/18/2014 09:18 AM, Henrik /KaarPoSoft wrote: On 03/17/2014 10:32 PM, Tom Gundersen wrote: On Mon, Mar 17, 2014 at 10:21 PM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: Hi Tom, Thanks for your

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-19 Thread Tom Gundersen
On Wed, Mar 19, 2014 at 1:25 PM, poma pomidorabelis...@gmail.com wrote: Still the same issue, DHCPC starts too early, before the correct MAC address is set for the bridge. git 7bf2f4397255bc8f6cf20a0f2adab4c984ea7d14 I haven't yet gotten around to this. We probably should just restart the

Re: [systemd-devel] [PATCH] V2 sd-ipv4ll: generate predictable addresses

2014-03-20 Thread Tom Gundersen
On Wed, Mar 19, 2014 at 2:36 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: --- src/libsystemd-network/sd-ipv4ll.c | 86 +--- src/network/networkd-link.c| 12 +++- src/network/networkd.h |1 + src/shared/net-util.c |

Re: [systemd-devel] [PATCH] V2 sd-ipv4ll: generate predictable addresses

2014-03-20 Thread Tom Gundersen
On Thu, Mar 20, 2014 at 6:52 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Mar 19, 2014 at 2:36 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: --- src/libsystemd-network/sd-ipv4ll.c | 86 +--- src/network/networkd-link.c| 12 +++- src/network

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-20 Thread Tom Gundersen
On Wed, Mar 19, 2014 at 2:09 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Mar 19, 2014 at 1:25 PM, poma pomidorabelis...@gmail.com wrote: Still the same issue, DHCPC starts too early, before the correct MAC address is set for the bridge. git 7bf2f4397255bc8f6cf20a0f2adab4c984ea7d14 I

Re: [systemd-devel] [PATCH] build: change tcpwrappers support to disabled by default

2014-03-20 Thread Tom Gundersen
On Thu, Mar 20, 2014 at 8:29 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 20.03.14 12:49, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: The underlying components have not seen any upstream activity since 1997 and are not particulary nice either. Those interested in

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-21 Thread Tom Gundersen
On Fri, Mar 21, 2014 at 8:51 AM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On Thu, Mar 20, 2014 at 8:29 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Mar 19, 2014 at 2:09 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Mar 19, 2014 at 1:25 PM, poma pomidorabelis...@gmail.com wrote: Still

Re: [systemd-devel] [PATCH] V2 sd-ipv4ll: generate predictable addresses

2014-03-21 Thread Tom Gundersen
On Fri, Mar 21, 2014 at 8:46 AM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On Thu, Mar 20, 2014 at 7:16 PM, Tom Gundersen t...@jklm.no wrote: On Thu, Mar 20, 2014 at 6:52 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Mar 19, 2014 at 2:36 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-21 Thread Tom Gundersen
On Fri, Mar 21, 2014 at 9:57 AM, Patrik Flykt patrik.fl...@linux.intel.com wrote: On Thu, 2014-03-20 at 20:29 +0100, Tom Gundersen wrote: My proposal is: Whenever the MAC address changes under us networkd calls sd_{dhcp_client,ipv4ll}_set_mac(), and it is the libs' responsibility to then do

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-21 Thread Tom Gundersen
On Tue, Mar 18, 2014 at 10:38 AM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: On 03/18/2014 10:10 AM, Tom Gundersen wrote: On Tue, Mar 18, 2014 at 10:00 AM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: On 03/18/2014 09:18 AM, Henrik /KaarPoSoft wrote: On 03/17/2014 10:32 PM, Tom

Re: [systemd-devel] [PATCH] network: dhcp: create explicit host route to gateway

2014-03-21 Thread Tom Gundersen
On Thu, Mar 20, 2014 at 7:53 PM, Brandon Philips bran...@ifup.co wrote: This is a better approach that was suggested by Mike and ack'd by Tom. Some DHCP servers gives you a netmask of 255.255.255.255 so the gateway is not routable. Other DHCP client implementations look through the existing

Re: [systemd-devel] [PATCH] network: dhcp: create host route if dhcp subnet is 255.255.255.255

2014-03-21 Thread Tom Gundersen
On Thu, Mar 20, 2014 at 1:16 AM, Brandon Philips bran...@ifup.co wrote: Some DHCP servers gives you a netmask of 255.255.255.255 so gateway is not routable. Make a host route instead. This fixes the issue but the implementation is very specific. It would probably be better to check the route

Re: [systemd-devel] [PATCH] network: dhcp: create explicit host route to gateway

2014-03-21 Thread Tom Gundersen
On Fri, Mar 21, 2014 at 7:34 PM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: Hi, Do we also need to drop the route within dhcp_lease_lost()? Indeed, good catch. Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] systemd-networkd bridge with DHCP not working

2014-03-21 Thread Tom Gundersen
On Fri, Mar 21, 2014 at 9:47 PM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: THANK YOU VERY MUCH! Yes, it works now for me. Logs attached. Awesome, thank's for testing! I was busy with something else, so only watched the list and git with half an eye. However, I find it disturbing

Re: [systemd-devel] systemd-networkd bridge with DHCP working

2014-03-22 Thread Tom Gundersen
On Sat, Mar 22, 2014 at 5:06 AM, poma pomidorabelis...@gmail.com wrote: systemd-networkd bridge dhcp OK https://bugzilla.redhat.com/attachment.cgi?id=877526 Thanks for reporting back. Cheers, Tom ___ systemd-devel mailing list

[systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread Tom Gundersen
Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of a bus, and introduce bus_{un,}ref(), which are only available internally, and which do not protect these queues. Make sure that sd_bus_message object do not call sd_bus_ref(), but only the internal bus_ref(). This is

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Tom Gundersen
On Sun, Mar 23, 2014 at 4:14 PM, Susant Sahani sus...@redhat.com wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs super user privileges to run and respective kernel

Re: [systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread Tom Gundersen
On Sun, Mar 23, 2014 at 11:50 PM, David Herrmann dh.herrm...@gmail.com wrote: On Sun, Mar 23, 2014 at 4:49 PM, Tom Gundersen t...@jklm.no wrote: Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of a bus, and introduce bus_{un,}ref(), which are only available

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: Introduce container parsing

2014-03-24 Thread Tom Gundersen
On Sat, Mar 22, 2014 at 5:13 PM, Susant Sahani sus...@redhat.com wrote: Introducing generic container parsing . Now supported for type FLA_INFO_KIND and IFLA_VLAN_ID which can be extended to other container parsing which is based on table based look up. ---

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: Introduce container parsing

2014-03-25 Thread Tom Gundersen
On Tue, Mar 25, 2014 at 3:16 AM, Susant Sahani sus...@redhat.com wrote: I now pushed an alternative patch. Could you have a look if it makes sense to you? If am not wrong *sd_rtnl_message_enter_container* trying to parse (rtnl_message_parse) every time a attribute is requested which is

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-25 Thread Tom Gundersen
On Tue, Mar 25, 2014 at 9:43 AM, Susant Sahani sus...@redhat.com wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are moved to a separate file and manual test as well because they require respective

Re: [systemd-devel] systemd v212 build error

2014-03-28 Thread Tom Gundersen
On Fri, Mar 28, 2014 at 12:09 PM, Michael Olbrich m.olbr...@pengutronix.de wrote: Hi, compiling systemd v212 fails here with: [...] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:462:38: error: 'IFLA_IPTUN_TTL'

Re: [systemd-devel] [PATCH] sd-dhcp: check for udp packets

2014-03-30 Thread Tom Gundersen
On Sun, Mar 30, 2014 at 7:09 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Do not try to parse ICMP packets --- src/libsystemd-network/dhcp-packet.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/libsystemd-network/dhcp-packet.c

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Tom Gundersen
On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier on segmentation fault (core dumped) If you could reproduce

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Tom Gundersen
On Sun, Mar 30, 2014 at 9:30 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier

Re: [systemd-devel] [PATCH v2] sd-rtnl: fix off-by-one

2014-03-31 Thread Tom Gundersen
On Mon, Mar 31, 2014 at 6:20 AM, Steven Siloti ssil...@gmail.com wrote: Also fix type parameter passed to new0 Thanks to both. Applied. Cheers, Tom src/libsystemd/sd-rtnl/rtnl-message.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-31 Thread Tom Gundersen
On Mon, Mar 31, 2014 at 12:28 AM, Tom Gundersen t...@jklm.no wrote: On Sun, Mar 30, 2014 at 10:18 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb

Re: [systemd-devel] git requires now linux api userspace headers = 3.13 to build?

2014-03-31 Thread Tom Gundersen
On Mon, Mar 31, 2014 at 5:08 PM, Samuli Suominen ssuomi...@gentoo.org wrote: User reported me today, http://bpaste.net/show/195803/ IFLA_VLAN_PROTOCOL is not defined before 3.12, but even with 3.12 there are different errors, so at least = 3.13 is now required snip

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-04-01 Thread Tom Gundersen
On Tue, Apr 1, 2014 at 8:41 AM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Thanks, that's useful. I'll have a look. Steven's patch should have fixed this issue (the invalid read/write, no idea about Conditional jump or move depends on uninitialised value(s

Re: [systemd-devel] [PATCH] libsystemd-network: Support setting DHCP client initial delay

2014-04-03 Thread Tom Gundersen
On Thu, Apr 3, 2014 at 9:28 AM, Patrik Flykt patrik.fl...@linux.intel.com wrote: Section 4.4.1 in RFC 2131 says that a DHCP client SHOULD wait a random time between one and ten seconds to desynchronize DHCP clients on startup. This is supported such that the application can optionally set an

Re: [systemd-devel] [PATCH] use systemd.debug on the kernel command line, not debug

2014-04-03 Thread Tom Gundersen
On Thu, Apr 3, 2014 at 12:27 AM, Greg KH gre...@linuxfoundation.org wrote: If the kernel is started with debug, that's for the kernel to switch into debug mode. We should rely on a namespace for our options, like everything else (with the exception of quiet). Just a quick note, we do in fact

Re: [systemd-devel] [PATCH] use systemd.debug on the kernel command line, not debug

2014-04-03 Thread Tom Gundersen
On Thu, Apr 3, 2014 at 11:08 AM, Tom Gundersen t...@jklm.no wrote: Is the rationale for this, simply a matter of preference, i.e., is the claim simply that we believe most users would benefit more from the 'kernel only' compared to 'all low-level stuff' behavior? If that's the case, I don't

Re: [systemd-devel] [PATCH] networkd: smooth transition from ipv4ll to dhcp address

2014-04-03 Thread Tom Gundersen
Applied. Thanks! Cheers, Tom On Wed, Apr 2, 2014 at 9:31 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Currently when both ipv4ll and dhcp are enabled, ipv4ll address (if one has been claimed) is removed when dhcp address is aquired. This is not the best thing to do since there

Re: [systemd-devel] [PATCH] networkd: drop routes when lease expires

2014-04-03 Thread Tom Gundersen
Applied. Thanks! Cheers, Tom On Tue, Apr 1, 2014 at 10:55 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: --- src/network/networkd-link.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c index

Re: [systemd-devel] sd-rtnl: broken test cases

2014-04-03 Thread Tom Gundersen
is broken. Thanks! I forgot to fix up this stuff. I had to fix up your patch as seen below to make the tests pass again. Feel free to ask if the reasoning behind any of the changes is unclear. Cheers, Tom commit 9295158ea6b04cd7fc0ac6083d4a40c9b733821a Author: Tom Gundersen t...@jklm.no Date

Re: [systemd-devel] LXC not working with systemd 209 or later

2014-04-04 Thread Tom Gundersen
On Thu, Apr 3, 2014 at 7:53 PM, John Lane syst...@jelmail.com wrote: What I find is that the login prompt never results in a prompt. I enter the correct user/password and it takes an age before redisplaying the login prompt. If apply 208 before starting the container then it works as expected.

Re: [systemd-devel] [PATCH] backlight: do nothing if max_brightness is 0

2014-04-04 Thread Tom Gundersen
On Wed, Apr 2, 2014 at 8:20 PM, Thomas Bächler tho...@archlinux.org wrote: Am 27.03.2014 23:41, schrieb Thomas Bächler: On virtually any newer Asus mainboard, the eeepc-wmi driver is loaded. It exposes a backlight device despite the lack of any physical backlight devices. This fake backlight

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-04 Thread Tom Gundersen
Hi Susant, Thanks for this, looking forward getting this merged! I have some comments below though. On Fri, Apr 4, 2014 at 11:25 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration File :

Re: [systemd-devel] Masking .network files

2014-04-05 Thread Tom Gundersen
On Sat, Apr 5, 2014 at 12:43 AM, Leonid Isaev lis...@umail.iu.edu wrote: I seem to have a strange issue with the way networkd processes its configuration files. The machine is actually a systemd-nspawn container with a static IP address, so I had to mask the default

Re: [systemd-devel] [PATCH] core: Make sure a stamp file exists for all Persistent=true timers

2014-04-05 Thread Tom Gundersen
On Wed, Apr 2, 2014 at 8:18 PM, Thomas Bächler tho...@archlinux.org wrote: If a persistent timer has no stamp file yet, it behaves just like a normal timer until it runs for the first time. If the system is always shut down while the timer is supposed to run, a stamp file is never created and

Re: [systemd-devel] Masking .network files

2014-04-05 Thread Tom Gundersen
On Sat, Apr 5, 2014 at 11:39 AM, Samuli Suominen ssuomi...@gentoo.org wrote: On 05/04/14 12:26, Tom Gundersen wrote: matching file will be applied. The 'masking' logic that you know from unit files does not really make much sense for .network files (but maybe this is something we should change

Re: [systemd-devel] [PATCH v4] use systemd.debug on the kernel command line, not debug

2014-04-05 Thread Tom Gundersen
On Sat, Apr 5, 2014 at 11:22 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Apr 05, 2014 at 01:16:12PM -0700, Greg KH wrote: On Sat, Apr 05, 2014 at 07:11:47AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Apr 03, 2014 at 04:08:15PM +0200, Hannes Reinecke wrote: From:

Re: [systemd-devel] [PATCH v4] use systemd.debug on the kernel command line, not debug

2014-04-05 Thread Tom Gundersen
On Sat, Apr 5, 2014 at 11:44 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Apr 05, 2014 at 11:32:50PM +0200, Tom Gundersen wrote: On Sat, Apr 5, 2014 at 11:22 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Apr 05, 2014 at 01:16:12PM -0700, Greg KH wrote

Re: [systemd-devel] Masking .network files

2014-04-05 Thread Tom Gundersen
On Sat, Apr 5, 2014 at 5:06 PM, Leonid Isaev lis...@umail.iu.edu wrote: Hi, On Sat, 5 Apr 2014 11:26:17 +0200 Tom Gundersen t...@jklm.no wrote: On Sat, Apr 5, 2014 at 12:43 AM, Leonid Isaev lis...@umail.iu.edu wrote: I seem to have a strange issue with the way networkd processes

Re: [systemd-devel] Masking .network files

2014-04-06 Thread Tom Gundersen
On Sun, Apr 6, 2014 at 3:25 AM, Leonid Isaev lis...@umail.iu.edu wrote: On Sun, 6 Apr 2014 01:12:45 +0200 Tom Gundersen t...@jklm.no wrote: So in general masking .network files (in the sense applied to unit files) does not make much sense, and will probably not behave as you would expect

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-07 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 6:35 AM, Susant Sahani sus...@redhat.com wrote: I have addressed all your comments. Cool. However I have some queries Please find below. Hm, we can probably reuse some of the existing address parsing functions don't you think? And we should also check the address

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 9:44 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 12:28 PM, Susant Sahani sus...@redhat.com wrote: +r = manager_init_kmod_ctx(m); Maybe just do manager-kmod_ctx = kmod_ctx_new(NULL, NULL); if (!manager-kmod_ctx) { r = -ENOMEM; etc... } and drop the wrapping function (see above). Any

Re: [systemd-devel] Netconsole NG

2014-04-08 Thread Tom Gundersen
On Tue, Apr 8, 2014 at 2:10 PM, poma pomidorabelis...@gmail.com wrote: On 08.04.2014 04:03, poma wrote: On 07.04.2014 19:55, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Apr 07, 2014 at 05:34:10PM +0200, Lukáš Nykrýn wrote: The reason why this was not rewritten a long time ago is that the

Re: [systemd-devel] [PATCH] Document CONFIG_NET_NS as a required kernel option

2014-04-09 Thread Tom Gundersen
On Mon, Mar 31, 2014 at 8:28 PM, Mike Gilbert flop...@gentoo.org wrote: Several units now utilize the PrivateNetwork parameter, which requires network namespace support. Applied. Thanks! Cheers, Tom ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 9:47 PM, Richard Weinberger rich...@nod.at wrote: At least LXC does not allow the container root to change the OOM Score adjust value. Signed-off-by: Richard Weinberger rich...@nod.at --- Hi! Within Linux containers we cannot use OOMScoreAdjust nor

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Tom Gundersen
On Wed, Apr 9, 2014 at 7:39 PM, Richard Weinberger rich...@nod.at wrote: Am 09.04.2014 19:19, schrieb Tom Gundersen: On Mon, Apr 7, 2014 at 9:47 PM, Richard Weinberger rich...@nod.at wrote: At least LXC does not allow the container root to change the OOM Score adjust value. Signed-off

Re: [systemd-devel] [PATCH] silence warning

2014-04-11 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 10:17 PM, Thomas H.P. Andersen pho...@gmail.com wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com The error message logged in finish: will not be very informative but on the other hand I don't see how this should ever happen. This can never happen, unless

Re: [systemd-devel] [PATCH] core: Make sure a stamp file exists for all Persistent=true timers

2014-04-12 Thread Tom Gundersen
On Sat, Apr 12, 2014 at 12:57 PM, Thomas Bächler tho...@archlinux.org wrote: Am 05.04.2014 17:32, schrieb Thomas Bächler: Am 05.04.2014 11:35, schrieb Tom Gundersen: On Wed, Apr 2, 2014 at 8:18 PM, Thomas Bächler tho...@archlinux.org wrote: If a persistent timer has no stamp file yet

Re: [systemd-devel] [PATCH] libnetworkd: only allow positive ifindex

2014-04-12 Thread Tom Gundersen
On Sat, Apr 12, 2014 at 7:26 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Apr 12, 2014 at 01:19:48PM +0200, Umut Tezduyar Lindskog wrote: Patch doesn't apply anymore after reference counting changes. I will re-send it along with ipv4ll tests which is coming up right away.

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-13 Thread Tom Gundersen
Hm, why? Are not error messages more useful? On 13 Apr 2014 12:53, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-13 Thread Tom Gundersen
On Sun, Apr 13, 2014 at 2:11 PM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On Sun, Apr 13, 2014 at 1:16 PM, Tom Gundersen t...@jklm.no wrote: Hm, why? Are not error messages more useful? What is going to be the mapping for DHCP_EVENT_STOP? log_dhcp_client(client, STOPPED: %s, strerror

Re: [systemd-devel] systemd-networkd bridge with DHCP *NOT*working

2014-04-13 Thread Tom Gundersen
On Mon, Apr 14, 2014 at 12:12 AM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: On 03/22/2014 10:41 AM, Tom Gundersen wrote: On Sat, Mar 22, 2014 at 5:06 AM, poma pomidorabelis...@gmail.com wrote: systemd-networkd bridge dhcp OK https://bugzilla.redhat.com/attachment.cgi?id=877526

Re: [systemd-devel] systemd-networkd bridge with DHCP *NOT*working

2014-04-14 Thread Tom Gundersen
On Mon, Apr 14, 2014 at 1:17 AM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: On 04/14/2014 12:34 AM, Tom Gundersen wrote: On Mon, Apr 14, 2014 at 12:12 AM, Henrik /KaarPoSoft hen...@kaarposoft.dk wrote: On 03/22/2014 10:41 AM, Tom Gundersen wrote: On Sat, Mar 22, 2014 at 5:06 AM, poma

Re: [systemd-devel] Masking .network files

2014-04-19 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 2:56 AM, Lennart Poettering lenn...@poettering.net wrote: On Sat, 05.04.14 11:26, Tom Gundersen (t...@jklm.no) wrote: On Sat, Apr 5, 2014 at 12:43 AM, Leonid Isaev lis...@umail.iu.edu wrote: I seem to have a strange issue with the way networkd processes its

Re: [systemd-devel] [systemd-commits] 3 commits - src/libsystemd src/network src/udev

2014-04-20 Thread Tom Gundersen
On Sun, Apr 20, 2014 at 3:16 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sun, Apr 20, 2014 at 05:45:18AM -0700, Tom Gundersen wrote: commit 6190b9f9d2574428d560458a99f2838041cfdaac Author: Tom Gundersen t...@jklm.no Date: Sun Apr 20 07:51:28 2014 +0200 sd-rtnl: log when

  1   2   3   4   5   6   7   8   9   10   >