[systemd-devel] [PATCH] sys-kernel-debug.mount: mount with mode 755

2013-10-04 Thread Ramkumar Ramachandra
Kernel hackers need access to the debugfs filesystem. For instance, see
the performance subsystem (tools/perf in the kernel tree); we should let
all users, not just root, run the perf tool to collect performance
information about their programs by default.

Cc: Lennart Poettering lenn...@poettering.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
 units/sys-kernel-debug.mount | 1 +
 1 file changed, 1 insertion(+)

diff --git a/units/sys-kernel-debug.mount b/units/sys-kernel-debug.mount
index 5369728..f90bfc1 100644
--- a/units/sys-kernel-debug.mount
+++ b/units/sys-kernel-debug.mount
@@ -17,3 +17,4 @@ Before=sysinit.target
 What=debugfs
 Where=/sys/kernel/debug
 Type=debugfs
+Options=mode=755
-- 
1.8.4.477.g5d89aa9

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] sys-kernel-debug.mount: mount with mode 755

2013-10-04 Thread Kay Sievers
On Fri, Oct 4, 2013 at 7:30 AM, Ramkumar Ramachandra artag...@gmail.com wrote:
 Kernel hackers need access to the debugfs filesystem. For instance, see
 the performance subsystem (tools/perf in the kernel tree); we should let
 all users, not just root, run the perf tool to collect performance
 information about their programs by default.

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=82aceae4f0d42f03d9ad7d1e90389e731153898f

Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] sys-kernel-debug.mount: mount with mode 755

2013-10-04 Thread Lennart Poettering
On Fri, 04.10.13 11:00, Ramkumar Ramachandra (artag...@gmail.com) wrote:

 Kernel hackers need access to the debugfs filesystem. For instance, see
 the performance subsystem (tools/perf in the kernel tree); we should let
 all users, not just root, run the perf tool to collect performance
 information about their programs by default.

There has been a constant forth and back on this topic regarding what
the default should be. 

It used to be open, and then it was requested to be closed:

https://bugzilla.redhat.com/show_bug.cgi?id=864080

The kernel folks committed this:

https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=82aceae4f0d42f03d9ad7d1e90389e731153898f

For me this settles the story for the time being: as long as that is the
default the kernel guys think is appropriate we really should stick to
it. If you don't like this default, please talk to the kernel folks and
convince them to open this up again, and we'll just inherit that then. I
don't think we should override kernel defaults in this area.

I hope this makes sense!

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] sys-kernel-debug.mount: mount with mode 755

2013-10-04 Thread Greg KH
On Fri, Oct 04, 2013 at 04:50:30PM +0200, Lennart Poettering wrote:
 On Fri, 04.10.13 11:00, Ramkumar Ramachandra (artag...@gmail.com) wrote:
 
  Kernel hackers need access to the debugfs filesystem. For instance, see
  the performance subsystem (tools/perf in the kernel tree); we should let
  all users, not just root, run the perf tool to collect performance
  information about their programs by default.
 
 There has been a constant forth and back on this topic regarding what
 the default should be. 
 
 It used to be open, and then it was requested to be closed:
 
 https://bugzilla.redhat.com/show_bug.cgi?id=864080
 
 The kernel folks committed this:
 
 https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=82aceae4f0d42f03d9ad7d1e90389e731153898f
 
 For me this settles the story for the time being: as long as that is the
 default the kernel guys think is appropriate we really should stick to
 it. If you don't like this default, please talk to the kernel folks and
 convince them to open this up again, and we'll just inherit that then. I
 don't think we should override kernel defaults in this area.

The kernel defaults for debugfs will not be changed, unless some core
debugfs and vfs changes get finished and merged, and I don't see that
happening anytime soon.

So keeping this locked down for everyone but root is a _very_ good idea,
thanks for not changing it.

greg k-h
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel