On Fri, 24.10.14 16:24, Martin Pitt (martin.p...@ubuntu.com) wrote:
Hey Zbyszek,
Zbigniew Jędrzejewski-Szmek [2014-10-24 19:45 +0200]:
This enumeration is also used below... The definition should be shared.
You might want to also consider using NULSTR_FOREACH for iteration.
Ah, thanks
On Fri, Oct 24, 2014 at 04:24:46PM -0400, Martin Pitt wrote:
The updated patch fixes both now.
Looks fine and push-worthy. Two minor nitpicks below, feel free
to fix up before pushing or ignore as you see fit.
From 1624d949c60a911f7bf578d0141c8cd0d98c54e9 Mon Sep 17 00:00:00 2001
From: Martin
Hey Zbyszek,
Zbigniew Jędrzejewski-Szmek [2014-10-24 19:45 +0200]:
This enumeration is also used below... The definition should be shared.
You might want to also consider using NULSTR_FOREACH for iteration.
Ah, thanks for pointing that out.
This function should have the prototype of 'int
