Re: [systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-06-10 Thread Eric DeVolder
Hi Lennart, I've applied the coding style guidelines, and created a pull request #12768 via GitHub. Let me know what I may have done wrong, my first attempt via GitHub. Thanks, eric On 5/16/19 9:34 AM, Lennart Poettering wrote: On Do, 16.05.19 09:28, Eric DeVolder (eric.devol...@oracle.com)

Re: [systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-05-16 Thread Eric DeVolder
OK, will do! eric On 5/16/19 9:34 AM, Lennart Poettering wrote: On Do, 16.05.19 09:28, Eric DeVolder (eric.devol...@oracle.com) wrote: Could you please submit this via github as PR? Review is so much nicer there, in particular for complex patch sets, and this qualifies as complex I think. This

Re: [systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-05-16 Thread Lennart Poettering
On Do, 16.05.19 09:28, Eric DeVolder (eric.devol...@oracle.com) wrote: Could you please submit this via github as PR? Review is so much nicer there, in particular for complex patch sets, and this qualifies as complex I think. This also has the benefit that the code is automatically analyzed by