Re: [systemd-devel] [systemd-commits] 2 commits - src/core src/journal-remote src/network

2014-12-15 Thread Lennart Poettering
On Sat, 13.12.14 08:32, Matthias Urlichs (matth...@urlichs.de) wrote: Hi, Zbigniew Jędrzejewski-Szmek: wrap a few *_FOREACH macros in curly braces cppcheck is full of errors anyway. I don't think we should make the code less pretty just to satisfy a checker, and a rarely

Re: [systemd-devel] [systemd-commits] 2 commits - src/core src/journal-remote src/network

2014-12-15 Thread Mantas Mikulėnas
On Mon, Dec 15, 2014 at 5:40 PM, Lennart Poettering mzta...@0pointer.de wrote: On Sat, 13.12.14 08:32, Matthias Urlichs (matth...@urlichs.de) wrote: Hi, Zbigniew Jędrzejewski-Szmek: wrap a few *_FOREACH macros in curly braces cppcheck is full of errors anyway. I don't think

Re: [systemd-devel] [systemd-commits] 2 commits - src/core src/journal-remote src/network

2014-12-13 Thread Thomas H.P. Andersen
On Sat, Dec 13, 2014 at 1:26 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Dec 12, 2014 at 12:58:04PM -0800, Thomas H.P. Andersen wrote: Author: Thomas Hindoe Paaboel Andersen pho...@gmail.com Date: Fri Dec 12 19:51:41 2014 +0100 wrap a few *_FOREACH macros in curly

Re: [systemd-devel] [systemd-commits] 2 commits - src/core src/journal-remote src/network

2014-12-12 Thread Matthias Urlichs
Hi, Zbigniew Jędrzejewski-Szmek: wrap a few *_FOREACH macros in curly braces cppcheck is full of errors anyway. I don't think we should make the code less pretty just to satisfy a checker, and a rarely used one. While you may be right about cppcheck, IMHO it's good style to wrap