Re: [systemd-devel] 220 regression: path_is_mount_point() for non-directories

2015-05-26 Thread Lennart Poettering
On Mon, 25.05.15 21:06, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello all, in 220, path_is_mount_point() now always fails with -20 ENOTDIR when calling it on files. This is problematic as it's perfectly valid to have bind-mounted files; in fact, systemd's machine_id_setup() itself

Re: [systemd-devel] 220 regression: path_is_mount_point() for non-directories

2015-05-25 Thread Martin Pitt
Martin Pitt [2015-05-25 21:06 +0200]: Alternatively we could pass a parent_path to fd_is_mount_point(), compute that in path_is_mountpoint(), and don't specify one (or maybe we even can specify it easily, I didn't check) in rm_rf_children() as file bind mounts don't seem relevant there. This