Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
Andrei Borzenkov [2016-07-07 11:39 +0300]: > Do not we already have "session" concept in logind? Is not session > already stopped when user logs out? Yes, but user systemd units don't "see" the system logind scopes, so you can't relate to them. And the user systemd instance continues to run after

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Andrei Borzenkov
On Thu, Jul 7, 2016 at 11:27 AM, Martin Pitt wrote: > Zbigniew Jędrzejewski-Szmek [2016-07-04 22:20 +]: >> I think we should instead enhance target units to provide missing >> functionality. The most important thing would be to have something >> like PartOf, but more

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
Zbigniew Jędrzejewski-Szmek [2016-07-04 22:20 +]: > I think we should instead enhance target units to provide missing > functionality. The most important thing would be to have something > like PartOf, but more nicely configured. PartOf=graphical-kde.target > would do the trick, but it would

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
Martin Pitt [2016-07-07 9:29 +0200]: > I'll go ahead and create a PR with the unit and a manpage, using > graphical-session.target for now. Then the name bikeshedding can be > continued there. https://github.com/systemd/systemd/pull/3678 -- Martin Pitt|

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
Hello Jóhann, Jóhann B. Guðmundsson [2016-07-06 16:22 +]: > It's more about people will be have hard time distinguish between two or > more type units with the same name but serve two different purposes. I was thinking graphical.target would be nicely symmetrical to the system-level one, but

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Jóhann B . Guðmundsson
># gnome-user-graphical.target > >[Unit] >Description=User systemd services for graphical session >StopWhenUnneeded=yes So this is just another name for "my" gnome.target/gnome-session.target. As I said I'm not too fussed about how we name those, we should just decide about some convention.

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Hello Jóhann, Jóhann B. Guðmundsson [2016-07-06 15:23 +]: > What I'm ( poorly ) trying to say is that you will need to make a clear > distinction of naming on the type units for the desktop environment and the > type units for the desktop environment user I don't understand the distinction

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Jóhann B . Guðmundsson
On 07/06/2016 02:34 PM, Martin Pitt wrote: This /usr/lib/systemd/user/graphical.target (and only that)*does* belong in to systemd, as it cannot sensibly be in any gnome-session/mate-session/kde-session/etc. package -- it's a shared resource/synchronization point between all of those. Having a

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Jóhann B. Guðmundsson [2016-07-06 14:02 +]: > Martin is proposing changes to and dependency's on the graphical.target I'm not changing anything. graphical.target as it exists in systemd today is for the *system* instance. I'm talking about the *user* instance, which has no graphical.target at

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Jóhann B . Guðmundsson
On 07/06/2016 12:51 PM, Jan Alexander Steffens wrote: On Wed, Jul 6, 2016 at 2:21 PM Jóhann B. Guðmundsson > wrote: It's questionable if such application should reside in upstream systemd since arguably systemd should have never created

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Martin Pitt [2016-07-06 13:47 +0200]: > Simon McVittie [2016-07-05 10:27 +0100]: > > Could this be done by having the .desktop file in /usr/share/xsessions > > or /usr/share/wayland-sessions start an appropriate systemd user unit > > directly, and wait for it to terminate? > > There is currently

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Hello Jan, Jan Alexander Steffens [2016-07-06 11:57 +]: > Note that systemd makes a difference between "gnome-session.service became > inactive" and "gnome-session.service gets stopped". A service terminating > by itself is the former. > > Requires= and PartOf= will only propagate the

Re: [systemd-devel] Standardizing names for graphical session units -- version 3, now working!

2016-07-06 Thread Martin Pitt
Andrei Borzenkov [2016-07-06 14:44 +0300]: > On Wed, Jul 6, 2016 at 2:25 PM, Martin Pitt wrote: > >$ cat .config/systemd/user/gnome-session.target > >[Unit] > >Description=User systemd services for GNOME graphical session > >Requires=graphical.target > >

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Jan Alexander Steffens
On Wed, Jul 6, 2016 at 2:21 PM Jóhann B. Guðmundsson wrote: > > It's questionable if such application should reside in upstream systemd > since arguably systemd should have never created the graphical.target to > begin with ( if it had not we probably would not be having this

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Jan Alexander Steffens
On Wed, Jul 6, 2016 at 1:50 PM Martin Pitt wrote: > Martin Pitt [2016-07-06 13:47 +0200]: > > I have a gut feeling that this should be expressible with systemd > > dependencies -- i. e. "if gnome-session.service stops, then stop > > gnome-session.target". Naïvely this

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Simon McVittie [2016-07-05 10:27 +0100]: > On 04/07/16 21:01, Martin Pitt wrote: > > A session type like "GNOME" or "KDE" then defines which top-level > > servcies it wants. > > Could this be done by having the .desktop file in /usr/share/xsessions > or /usr/share/wayland-sessions start an

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Martin Pitt [2016-07-06 13:47 +0200]: > I have a gut feeling that this should be expressible with systemd > dependencies -- i. e. "if gnome-session.service stops, then stop > gnome-session.target". Naïvely this would be > "PartOf=gnome-session.target" in gnome-session.service, but this does > not

Re: [systemd-devel] Standardizing names for graphical session units -- version 2

2016-07-06 Thread Andrei Borzenkov
On Wed, Jul 6, 2016 at 2:25 PM, Martin Pitt wrote: >$ cat .config/systemd/user/gnome-session.target >[Unit] >Description=User systemd services for GNOME graphical session >Requires=graphical.target >PartOf=graphical.target > Is not this redundant?

Re: [systemd-devel] Standardizing names for graphical session units -- version 2

2016-07-06 Thread Martin Pitt
Hello all, Colin, Jan, Zbigniew, thanks for your input! Based on that I have an updated proposal. Jan Alexander Steffens [2016-07-06 9:44 +]: > On Wed, Jul 6, 2016 at 10:51 AM Colin Guthrie wrote: > > Not commenting on the general approach (which I did read and

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Colin Guthrie
Jan Alexander Steffens wrote on 06/07/16 10:44: > On Wed, Jul 6, 2016 at 10:51 AM Colin Guthrie > wrote: > > Martin Pitt wrote on 04/07/16 23:08: > >> > Why would you call it graphical-<$DE>.slice as opposed to > simply <$DE>.slice

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Jan Alexander Steffens
On Wed, Jul 6, 2016 at 10:51 AM Colin Guthrie wrote: > Martin Pitt wrote on 04/07/16 23:08: > >> > Why would you call it graphical-<$DE>.slice as opposed to simply > <$DE>.slice > >> > which is part of the <$DE>.target and graphical target is link to that > >> >

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Colin Guthrie
Martin Pitt wrote on 04/07/16 23:08: >> > Why would you call it graphical-<$DE>.slice as opposed to simply >> > <$DE>.slice >> > which is part of the <$DE>.target and graphical target is link to that >> > <$DE>.target ( if shipped upstream it needs to be generic enough to cater >> > whatever is

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-05 Thread Simon McVittie
On 04/07/16 21:01, Martin Pitt wrote: > A session type like "GNOME" or "KDE" then defines which top-level > servcies it wants. Could this be done by having the .desktop file in /usr/share/xsessions or /usr/share/wayland-sessions start an appropriate systemd user unit directly, and wait for it to

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-04 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 04, 2016 at 10:01:48PM +0200, Martin Pitt wrote: > Hello all, > > a while ago I started experimenting with converting Ubuntu's upstart > graphical session to the user D-Bus and systemd session. This works > nicely and naturally for services which don't need $DISPLAY and are > not

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-04 Thread Martin Pitt
Hello Jóhann, Jóhann B. Guðmundsson [2016-07-04 20:53 +]: > Shipping an predefined desktop units arguably does not belong upstream since > it's just catering to one ( desktop ) out of three ( > embedded/server/desktop) target user base. Right, embedded/server would never start this new unit.

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-04 Thread Jóhann B . Guðmundsson
On 07/04/2016 08:01 PM, Martin Pitt wrote: Feedback appreciated! Shipping an predefined desktop units arguably does not belong upstream since it's just catering to one ( desktop ) out of three ( embedded/server/desktop) target user base. It might result in other two target user base