Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-21 Thread Paul Johnson
On Thu, Mar 6, 2014 at 3:47 AM, Martin Koppenhoefer dieterdre...@gmail.comwrote: 2014-03-05 21:25 GMT+01:00 Robin `ypid` Schneider ypi...@aol.de: There is no key öffnungszeiten, but yes it is only about the key opening_hours. As said before I am not going to change the meaning. The value

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-16 Thread Robin `ypid` Schneider
Thanks for the hint … I fixed it in this commit: https://github.com/ypid/opening_hours_map/commit/d45c8b6776091845576342f61e80dfef3bd698ba More issues can be reported here: https://github.com/ypid/opening_hours_map/issues On 12.03.2014 07:52, Peter Wendorff wrote: Hi Robin, small suggestion

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-12 Thread Peter Wendorff
Hi Robin, small suggestion for your opening-hours map (nice map, by the way): The tags list in the lower part of the markers box is (technically and visually) a table but the key is postfixed with an additional :, which is confusing because it may as well be part of the key itself. Within the

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-12 Thread Peter Wendorff
Another question to the map: do you consider POIs mapped as polygons? The Heinz Nixdorf Museumsforum [1] in Paderborn is not shown on your map although there's an opening_hours tag since months (if not years). regards Peter [1]

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-11 Thread Robin `ypid` Schneider
On 08.03.2014 16:37, fly wrote: On 06.03.2014 19:12, Stephan Knauss wrote: Robin `ypid` Schneider writes: I mean the correction '0930-0630' - '09:30-06:30'* seams quite straight forward and I guess if someone aware of the wiki page about opening_hours will find such a value he/she will

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-08 Thread fly
On 06.03.2014 19:12, Stephan Knauss wrote: Robin `ypid` Schneider writes: I mean the correction '0930-0630' - '09:30-06:30'* seams quite straight forward and I guess if someone aware of the wiki page about opening_hours will find such a value he/she will change it by hand anyway. I

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-07 Thread Dan S
2014-03-06 17:13 GMT+00:00 Robin `ypid` Schneider ypi...@aol.de: On 06.03.2014 10:47, Martin Koppenhoefer wrote: 2014-03-05 21:25 GMT+01:00 Robin `ypid` Schneider ypi...@aol.de: There is no key öffnungszeiten, but yes it is only about the key opening_hours. As said before I am not going to

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-07 Thread Richard Welty
On 3/7/14 7:03 AM, Dan S wrote: I'm sorry but if it is description-like, then it is free text and shouldn't be auto-standardised in the manner you propose. You need to decide if you think it is description-like (== free text, local language) or formalised (==set of possible labels, british

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-06 Thread Martin Koppenhoefer
2014-03-05 21:25 GMT+01:00 Robin `ypid` Schneider ypi...@aol.de: There is no key öffnungszeiten, but yes it is only about the key opening_hours. As said before I am not going to change the meaning. The value 'nach Vereinbarung' is used more often so that‘s another reason for that. I am

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-06 Thread Robin `ypid` Schneider
On 06.03.2014 10:47, Martin Koppenhoefer wrote: 2014-03-05 21:25 GMT+01:00 Robin `ypid` Schneider ypi...@aol.de: There is no key öffnungszeiten, but yes it is only about the key opening_hours. As said before I am not going to change the meaning. The value 'nach Vereinbarung' is used more

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-06 Thread Stephan Knauss
Robin `ypid` Schneider writes: I mean the correction '0930-0630' - '09:30-06:30'* seams quite straight forward and I guess if someone aware of the wiki page about opening_hours will find such a value he/she will change it by hand anyway. I assume that this will improve the data quality and will

[Tagging] Fixing wrong opening_hours automatically

2014-03-05 Thread Robin `ypid` Schneider
Hi I want to discuss the script based fixing of easy mistakes occurring in OSM. It began with a little regular expression and the question how to do automated edits: https://help.openstreetmap.org/questions/31169/how-to-change-key-values-based-on-regular-expressions-in-josm Now I have something

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-05 Thread Martin Koppenhoefer
Am 05/mar/2014 um 19:15 schrieb Robin `ypid` Schneider ypi...@aol.de: 'nach vereinbarung' - 'nach Vereinbarung' is this about the key opening_hours or the key öffnungszeiten? wouldn't it be better to change this to by appointment? cheers, Martin

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-05 Thread Frederik Ramm
Hi, On 03/05/2014 07:15 PM, Robin `ypid` Schneider wrote: I wanted to ask if that is OK with you as I will probably add more rules to the script when I come across values which meet my requirements. I would suggest that, if at all, you only make these changes in Germany and not elsewhere,

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-05 Thread Robin `ypid` Schneider
On 05.03.2014 20:28, Martin Koppenhoefer wrote: Am 05/mar/2014 um 19:15 schrieb Robin `ypid` Schneider ypi...@aol.de: 'nach vereinbarung' - 'nach Vereinbarung' is this about the key opening_hours or the key öffnungszeiten? wouldn't it be better to change this to by appointment?

Re: [Tagging] Fixing wrong opening_hours automatically

2014-03-05 Thread Robin `ypid` Schneider
On 05.03.2014 21:22, Frederik Ramm wrote: Hi, On 03/05/2014 07:15 PM, Robin `ypid` Schneider wrote: I wanted to ask if that is OK with you as I will probably add more rules to the script when I come across values which meet my requirements. I would suggest that, if at all, you only make