Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Mateusz Konieczny via Tagging
Dec 18, 2020, 17:44 by si...@poole.ch:

>
> addr:floor is an address tag and used in -(postal)-addresses-  when the 
> floor is customarily or required to be included.
>
>
> level:ref is a SIT tag used to indicate the name (or other  numbering) of 
> a level contrary to the zero based number of the  level tag.
>
>
> While both level:ref and addr:floor can have the same value,  
> semantically they are different
>
>
Thanks for clarification! Though as far as I know in practice level tag in some 
regions is used
with 1 assigned to ground floor (I am not sure whatever to consider this as a 
tagging mistake 
or not).

> replacing level:ref with  addr:floor which is what you were suggesting 
> with what boils down  to a mechanical edit with SC, will break SIT tagged 
> buildings.
>
To be clear, I was not suggesting replacing either tag with another.

And if https://github.com/streetcomplete/StreetComplete/issues/1487
would be implemented it would be adding new tags to objects where
level tag is tagged. It would not be "upgrade tags" wikifiddling.

 if I would implementit it would not delete any existing ones.
Objects tagged already with level:ref or addr:floor or level would be skipped
and this quest would not apply to them.
In this case resurvey with StreetComplete is pointless
(unlike case of opening hours), objects such as shops in general do
not move between floors while keeping their lat/lon position.

Am 18.12.2020 um 14:01 schrieb Mateusz  Konieczny via Tagging:

>> 1) this edits were not intended as changing anything but to  
>> document current tagging
>> practice
>>
>> 2) how Simple Indoor Tagging is being broken by either of  this tags?
>>
>> 3) If SIT is broken by that tags, how it can be avoided?  
>> Recommending to use 
>> level tag together with either of this two?
>>
>>
>> Dec 18, 2020, 13:34 by >> si...@poole.ch>> :
>>
>>>
>>> This doesn't make any sense outside of trying breaking the  SIT 
>>> tagging scheme If you have changes to suggest do that in  the 
>>> context of  an SIT improvement and not just so that you  can add 
>>> yet another SC challenge.
>>>
>>> Am 18.12.2020 um 13:11 schrieb Mateusz Konieczny  via Tagging:
>>>
 I heavily edited  https://wiki.openstreetmap.org/wiki/Key:addr:floor
 and created  https://wiki.openstreetmap.org/wiki/Key:level:ref

 Please, edit this pages if something can be improved.

 Review of this pages also would be welcomed.

 (edits triggered by  
 https://github.com/streetcomplete/StreetComplete/issues/1487
 and done as part of survey of a tagging situation beforea 
 potential implementation)

 ___Tagging mailing list 
 Tagging@openstreetmap.org 
 https://lists.openstreetmap.org/listinfo/tagging

>>
>>
>> ___Tagging mailing list>> 
>> Tagging@openstreetmap.org>> https://lists.openstreetmap.org/listinfo/tagging
>>

___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Simon Poole
addr:floor is an address tag and used in -(postal)-addresses- when the 
floor is customarily or required to be included.


level:ref is a SIT tag used to indicate the name (or other numbering) of 
a level contrary to the zero based number of the level tag.


While both level:ref and addr:floor can have the same value, 
semantically they are different and replacing level:ref with addr:floor 
which is what you were suggesting with what boils down to a mechanical 
edit with SC, will break SIT tagged buildings.


Am 18.12.2020 um 14:01 schrieb Mateusz Konieczny via Tagging:
1) this edits were not intended as changing anything but to document 
current tagging

practice

2) how Simple Indoor Tagging is being broken by either of this tags?

3) If SIT is broken by that tags, how it can be avoided? Recommending 
to use

level tag together with either of this two?


Dec 18, 2020, 13:34 by si...@poole.ch:

This doesn't make any sense outside of trying breaking the SIT
tagging scheme If you have changes to suggest do that in the
context of  an SIT improvement and not just so that you can add
yet another SC challenge.

Am 18.12.2020 um 13:11 schrieb Mateusz Konieczny via Tagging:

I heavily edited
https://wiki.openstreetmap.org/wiki/Key:addr:floor

and created https://wiki.openstreetmap.org/wiki/Key:level:ref


Please, edit this pages if something can be improved.

Review of this pages also would be welcomed.

(edits triggered by
https://github.com/streetcomplete/StreetComplete/issues/1487

and done as part of survey of a tagging situation before a
potential implementation)

___
Tagging mailing list
Tagging@openstreetmap.org  
https://lists.openstreetmap.org/listinfo/tagging  





___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


OpenPGP_signature
Description: OpenPGP digital signature
___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Mateusz Konieczny via Tagging



Dec 18, 2020, 14:56 by dieterdre...@gmail.com:

> Am Fr., 18. Dez. 2020 um 14:07 Uhr schrieb Mateusz Konieczny <> 
> matkoni...@tutanota.com> >:
>
>>
>> 4) I am not planning to work on deprecating either one
>>
>
>
> but you are working on cosolidating _both_
>
No, I just researched and described current state. What is needed anyway before 
any sort 
of meaningful deprecation discussion.


> "level:ref" could be described as a possible duplicate of addr:floor 
> introduced through
> undiscussed massedits or imports
>
This would require further research, to locate them - maybe this edits/imports 
were discussed.

___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Martin Koppenhoefer
Am Fr., 18. Dez. 2020 um 14:07 Uhr schrieb Mateusz Konieczny <
matkoni...@tutanota.com>:

> 1) both are in use and while level:ref has more uses most of them come
> from mass edits[1]
>
> 2) this edits were intended to document current tagging practice, not to
> create a proposal
>
> 3) addr:floor went through a proposal[2] and I am not going to mark it as
> deprecated
> without consultation
>


right, so maybe deprecate level:ref ? I agree it comes from massedits or
imports:
https://taginfo.openstreetmap.org/keys/level:ref#chronology



> 4) I am not planning to work on deprecating either one
>


but you are working on cosolidating _both_
If both have decent wiki descriptions it will be harder to deprecate them
in the future, while "level:ref" could be described as a possible duplicate
of addr:floor introduced through undiscussed massedits or imports, and last
week it was still completely undocumented ;-)

Cheers,
Martin
___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Mateusz Konieczny via Tagging
1) both are in use and while level:ref has more uses most of them come from 
mass edits[1]

2) this edits were intended to document current tagging practice, not to create 
a proposal

3) addr:floor went through a proposal[2] and I am not going to mark it as 
deprecated
without consultation

4) I am not planning to work on deprecating either one

5) I am not aware about any subtle differences except what was mentioned at 
wiki page 
(tagging trash can with level:ref seems reasonable, tagging trash can with 
addr:floor seems
weird, similar with other tags not carrying addresses)

6) If someone wants to make a proposal related to this tags (including 
deprecations)
- feel free, I am not planning to do this

[1] note spikes in usage count at 
https://taginfo.openstreetmap.org/keys/level%3Aref#chronology
indicating large numbers of tags added in very short time, with barely any use 
otherwise -
typical for imports and mass retaggings
[2] https://wiki.openstreetmap.org/wiki/Proposed_features/addr_keys_(2011-04)


Dec 18, 2020, 13:35 by dieterdre...@gmail.com:

> Your edit makes sense, at least as a first step, but we should reflect how to 
> explain why addr:floor is described as an alternative to level:ref, and not 
> as a "possible tagging mistake". Are there subtle differences? If not, I 
> would prefer to choose one and discourage the other. 10.000 uses are not 
> completely ignorable, but they still indicate this is in the beginning, given 
> that we have millions of POIs.
>
> Cheers
> Martin
>

___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Mateusz Konieczny via Tagging
1) this edits were not intended as changing anything but to document current 
tagging
practice

2) how Simple Indoor Tagging is being broken by either of this tags?

3) If SIT is broken by that tags, how it can be avoided? Recommending to use 
level tag together with either of this two?


Dec 18, 2020, 13:34 by si...@poole.ch:

>
> This doesn't make any sense outside of trying breaking the SIT  tagging 
> scheme If you have changes to suggest do that in the  context of  an SIT 
> improvement and not just so that you can add  yet another SC challenge.
>
> Am 18.12.2020 um 13:11 schrieb Mateusz  Konieczny via Tagging:
>
>> I heavily edited >> https://wiki.openstreetmap.org/wiki/Key:addr:floor
>> and created >> https://wiki.openstreetmap.org/wiki/Key:level:ref
>>
>> Please, edit this pages if something can be improved.
>>
>> Review of this pages also would be welcomed.
>>
>> (edits triggered by >> 
>> https://github.com/streetcomplete/StreetComplete/issues/1487
>> and done as part of survey of a tagging situation before apotential 
>> implementation)
>>
>> ___Tagging mailing list>> 
>> Tagging@openstreetmap.org>> https://lists.openstreetmap.org/listinfo/tagging
>>

___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Martin Koppenhoefer
Your edit makes sense, at least as a first step, but we should reflect how
to explain why addr:floor is described as an alternative to level:ref, and
not as a "possible tagging mistake". Are there subtle differences? If not,
I would prefer to choose one and discourage the other. 10.000 uses are not
completely ignorable, but they still indicate this is in the beginning,
given that we have millions of POIs.

Cheers
Martin
___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


Re: [Tagging] addr:floor and level:ref - Wiki review welcomed

2020-12-18 Thread Simon Poole
This doesn't make any sense outside of trying breaking the SIT tagging 
scheme If you have changes to suggest do that in the context of  an SIT 
improvement and not just so that you can add yet another SC challenge.


Am 18.12.2020 um 13:11 schrieb Mateusz Konieczny via Tagging:
I heavily edited https://wiki.openstreetmap.org/wiki/Key:addr:floor 

and created https://wiki.openstreetmap.org/wiki/Key:level:ref 



Please, edit this pages if something can be improved.

Review of this pages also would be welcomed.

(edits triggered by 
https://github.com/streetcomplete/StreetComplete/issues/1487 

and done as part of survey of a tagging situation before a potential 
implementation)


___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging


OpenPGP_signature
Description: OpenPGP digital signature
___
Tagging mailing list
Tagging@openstreetmap.org
https://lists.openstreetmap.org/listinfo/tagging