Re: [Tails-dev] Please review'n'merge feature/dont_autostart_iceweasel + test/dont_autostart_iceweasel

2014-01-10 Thread bertagaz
On Thu, Jan 09, 2014 at 05:53:49PM +0100, berta...@ptitcanardnoir.org wrote: > On Thu, Jan 09, 2014 at 11:52:20AM +0100, intrigeri wrote: > > Hi, > > > > intrigeri wrote (09 Jan 2014 10:26:11 GMT) : > > >> I patched it so it needs another review before merging. Sorry... > > > > > I'll take care o

Re: [Tails-dev] Please review'n'merge feature/dont_autostart_iceweasel + test/dont_autostart_iceweasel

2014-01-09 Thread bertagaz
On Thu, Jan 09, 2014 at 11:52:20AM +0100, intrigeri wrote: > Hi, > > intrigeri wrote (09 Jan 2014 10:26:11 GMT) : > >> I patched it so it needs another review before merging. Sorry... > > > I'll take care of it. Updated the ticket. > > Done and merged. > > Now, what about the test/dont_autostar

Re: [Tails-dev] Please review'n'merge feature/dont_autostart_iceweasel + test/dont_autostart_iceweasel

2014-01-09 Thread intrigeri
Hi, intrigeri wrote (09 Jan 2014 10:26:11 GMT) : >> I patched it so it needs another review before merging. Sorry... > I'll take care of it. Updated the ticket. Done and merged. Now, what about the test/dont_autostart_iceweasel branch? Cheers, -- intrigeri | GnuPG key @ https://gaffer.pti

Re: [Tails-dev] Please review'n'merge feature/dont_autostart_iceweasel + test/dont_autostart_iceweasel

2014-01-09 Thread intrigeri
sajol...@pimienta.org wrote (09 Jan 2014 10:14:01 GMT) : > I tested that between yesterday and this morning. I'm glad I lunched out > yesterday because this morning I discovered a new bug. The "Tor is > ready" message was appearing too early, when Iceweasel would still tell > you that "Tor is not r

Re: [Tails-dev] Please review'n'merge feature/dont_autostart_iceweasel + test/dont_autostart_iceweasel

2014-01-09 Thread sajolida
intrigeri: > Anyway, I think I've managed to make it good enough to release, and > sajolida agreed to take care of the review'n'merge. I guess he > wouldn't mind someone else (bertagaz, hint, hint :) to have a look at > the branch that updates the test suite. I tested that between yesterday and th

[Tails-dev] Please review'n'merge feature/dont_autostart_iceweasel + test/dont_autostart_iceweasel

2014-01-07 Thread intrigeri
Hi, as discussed on the incremental upgrades thread, we've decided that #5735 (Do not start the browser automatically) is blocking the activation of incremental upgrades by default, so I've settled to complete this branch. It was "a little" more complicated than I expected when I committed to do t