Re: [OSM-talk] OSM tagging validation lib

2017-12-26 Thread Simon Poole
On 26.12.2017 14:10, Colin Smale wrote: > > Why bother anyway? Why not just leave it to FvGordon? 90k changesets > fixing other people's tagging errors... > What wasn't clear about ".. preventing inadvertent mistakes to start with ..". After the fact validation just doesn't really work IMHO (as

Re: [OSM-talk] OSM tagging validation lib

2017-12-26 Thread Colin Smale
Why bother anyway? Why not just leave it to FvGordon? 90k changesets fixing other people's tagging errors... http://www.openstreetmap.org/user/FvGordon/history Actually, an analysis of all these changesets might produce some interesting insights into "frequently made errors". //colin On

Re: [OSM-talk] OSM tagging validation lib

2017-12-26 Thread Simon Poole
We already have validation tools in many forms for post-editing validation and already know how difficult they are to get "right" (see OSMOSE complaining about P+R facilities for a trivial example). I don't quite see why there is a need to create yet another one/system. On the other hand

Re: [OSM-talk] OSM tagging validation lib

2017-12-26 Thread Frederik Ramm
Hi, On 24.12.2017 21:03, Colin Smale wrote: > The real challenge here is not for the coders, but a perennial challenge > for the OSM community. How do we get to such a consensus about tagging > patterns, that we can actually say "this is correct" and "this is wrong > enough to warrant correction"

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Yuri Astrakhan
Colin, I think we should look at JOSM's validations as a good example of what is needed. For some validations, it extended MapCSS with its own custom quirks, and even added its own unit testing. For other types of validations (e.g. geometries), it seems to fall back to full code. Having a single

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Colin Smale
Hi Yuri, We have to decide what is most important - fidelity to the infinite number of tagging styles out there, or the ability to get a basic set of tagging grammar accepted in as many tools as possible. Any rules grammar will always have limits of course. If the rules are too complex to

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Yuri Astrakhan
Declarative rules are usually not very good. Every tool must understand every type of rule, and must be updated when new rule types are introduced. Plus declarative grammar is either too limiting, or eventually starts looking like a scripting language itself, and we end up building an execution

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread john whelan
The problem with HOT inspired maperthons is half the participants will not return. So restricting their choices to the most common is helpful. Typically I see highway=primary between two small settlements, highway=living_steet by mappers mapping from imagery in African countries that do not have

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Andy Townsend
On 24/12/17 18:41, john whelan wrote: True but it's to do with data quality and avoiding the need to validate. I don't think that different presets will "avoid the need to validate" in any scenario (HOT or otherwise) - the only thing that will do that is education and training - and having

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread john whelan
True but it's to do with data quality and avoiding the need to validate. Thank you for the comment. Cheerio John On 24 Dec 2017 1:37 pm, "Bryan Housel" wrote: > What you are describing has nothing to do with validation. This could be > done now without any new

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Bryan Housel
What you are describing has nothing to do with validation. This could be done now without any new development just by running a copy of iD with different presets. Sent from my iPhone > On Dec 24, 2017, at 12:08 PM, john whelan wrote: > > But what I suspect could be

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread François Lacombe
Hi Bryan Le 24 déc. 2017 4:45 PM, "Bryan Housel" a écrit : Have you looked at https://github.com/osmlab/osmlint ? Of all the current validation efforts, that seems like the most promising. I didn't know OSMLint and OSM QA tiles before Very promising indeed for parallel

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread john whelan
But what I suspect could be done is when iD in invoked from a HOT project it could restrict the options on things like highways to those in the wiki https://wiki.openstreetmap.org/wiki/Highway_Tag_Africa which would save a lot of living_streets etc. being added in parts of Africa where there

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Bryan Housel
Have you looked at https://github.com/osmlab/osmlint ? Of all the current validation efforts, that seems like the most promising. I’d definitely echo what other people are saying about avoiding the osm wiki if possible. It works on vector tiles though, so

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread François Lacombe
Thanks for answers :) I said a lib, but indeed the diversity of projects would be too problematic for implementation and rollouts. JSON, xml, text are fine https://twitter.com/VincentPrivat/status/944923315831033856 As Simon said, taginfo is a great tool to extract data from wiki. Even if it's

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Simon Poole
On the one hand lots of the in principle useful information in the wiki is not really easily extractable and on the other hand it is prone to manipulation in more than one way (current fad is to add big warnings about tagging errors what are not). IMHO addressing the first issue would likely be

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Colin Smale
The technical differences between java and JS do not preclude generic thinking. Consider tzdata[1] for example, which does something analogous for time zone data. The "rules database" can be made portable, in the form of XML or JSON for example. The logic for using these rules can be described

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Andy Townsend
On 24/12/17 11:49, Darafei "Komяpa" Praliaskouski wrote: It would be cool to have such library running on osm2pgsql import, fixing and complaining/skipping all the mistaked tag usage it can detect. This can possibly resurrect some objects that are lost because of typos or old tagging

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Mateusz Konieczny
> conform validation to wiki Sometimes wiki is wrong and should be changed. Note also that authors of different tools have different opinions how and what should be reported as errors. On 24 Dec 2017 11:12 a.m., "François Lacombe" wrote: Hi Here is an idea I got

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread Komяpa
Hi, What language would that library be in, if level0 and iD are in javascript, JOSM and Vespucci are in Java, and many random console tools are in python and perl? It would be cool to have such library running on osm2pgsql import, fixing and complaining/skipping all the mistaked tag usage it

Re: [OSM-talk] OSM tagging validation lib

2017-12-24 Thread James
ID is javascript, JOSM is java. So right there I already see a intercompatibility issue On Dec 24, 2017 6:12 AM, "François Lacombe" wrote: > Hi > > Here is an idea I got regarding tagging validation in editors (iD, JOSM, > others). > Subsequently to wiki proposal

[OSM-talk] OSM tagging validation lib

2017-12-24 Thread François Lacombe
Hi Here is an idea I got regarding tagging validation in editors (iD, JOSM, others). Subsequently to wiki proposal voting and cleanups, it's currently necessarily to open issues in each editor repository to ask for new tagging validation rules. It can sometimes be time consuming to develop those