Re: [Talk-gb-westmidlands] [Talk-GB] Drinking Map of UK

2011-11-07 Thread Andy Mabbett
Such a collection of records would, presumably, be copyright.

On 4 November 2011 10:14, Ed Loach e...@loach.me.uk wrote:
 It might be a bit over the top, but for pubs that make the CAMRA Good Beer
 Guide (or for some branches their local guide) lots of details have to be
 collected. See for example the key on this example page:

 http://www.tendringcamra.org.uk/pubdetails.html?uid=10856

 (there is an iframe or something to pull the middle bit from the Essex CAMRA
 Pubs database).



 Things like nearest bus route and nearest station don’t need surveying of
 course, assuming these are already mapped in OSM.



 The above pub may not have been the best example. Opening hours and Food
 hours often aren’t the same (opening_hours:food=?) – see for example

 http://www.tendringcamra.org.uk/pubdetails.html?uid=10940



 CAMRA members can visit
 http://www.hertsale.org.uk/essex/GetPubsByLocation.php and log in using
 their national login to see still more details which are generally hidden.
 Thing such as lat/lon, owner, tied or not, licensee, licensing area, Good
 Beer Guide years, who did the survey (not logged in you only see survey
 date), and some remarks which are usually used to store news about pubs
 closing, reopening, changing hands, poor service, or whatever. These
 regional database sites are due to feed into a national database, but I’ve
 not heard how that is progressing.



 Ed



 From: Brian Prangle [mailto:bpran...@gmail.com]
 Sent: 04 November 2011 08:58
 To: Andy Robinson
 Cc: talk...@openstreetmap.org; Richard Fairhurst

 Subject: Re: [Talk-GB] Drinking Map of UK



 Hi everyone



 Thanks to everyone who made suggestions. If we can build on Graham's initial
 efforts I think we can get a great map  and do some
 some interesting surveying with an incentive to get people out mapping!  As
 a first pass on a tagging scheme can I suggest we follow the wiki page
 at http://wiki.openstreetmap.org/wiki/Key:brewery for showing which beers
 are on sale at pubs ( i.e NOT guest beers)

 and that we encourage the use of the extra tags suggested on the wiki page
 for pubshttp://wiki.openstreetmap.org/wiki/Tag:amenity%3Dpub

 We can also make us of the microbrewey tag described
 on http://wiki.openstreetmap.org/wiki/Tag:microbrewery%3Dyes  for those
 places that only sell their beer on their own premises.



 Using that as a basis we could tag



 building=distillery

 building=brewery

 building=cider_press

 building=perry_press

 (that should remove any spurious entries like Brewery Apartments if we
 just do a search on names)



 For specialist off-licences which sell real ale we could use the realale tag
 from the pub wiki page



 Some breweries don't have visiting facilities so we need a tag to describe
 this. Any suggestions? Opening hours could do it maybe?



 To cover all these establishments should we have an industry sector tag
 industry=alcohol or commercial=alcohol?  Perhaps alcoholic_beverage would be
 better to distinguish it from industrial alcohol?



 How to distinguish real ale from industrial mass market breweries?



 How to list awards e.g  CAMRA Pub of the Year 2010



 Once we can get a consensus I can get a wiki page up within the UK projects
 section





 Regards



 Brian





 ___
 Talk-GB mailing list
 talk...@openstreetmap.org
 http://lists.openstreetmap.org/listinfo/talk-gb



 ___
 Talk-GB mailing list
 talk...@openstreetmap.org
 http://lists.openstreetmap.org/listinfo/talk-gb





-- 
Andy Mabbett
@pigsonthewing
http://pigsonthewing.org.uk

___
Talk-gb-westmidlands mailing list
Talk-gb-westmidlands@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-gb-westmidlands


Re: [Talk-GB] How to tag marine lights on posts

2011-11-07 Thread David Groom



- Original Message - 
From: Andy Mabbett a...@pigsonthewing.org.uk

To: Talk-GB@openstreetmap.org talk-gb@openstreetmap.org
Sent: Monday, November 07, 2011 3:48 PM
Subject: [Talk-GB] How to tag marine lights on posts




I've just tagged a row of 18 marine hazard lights, on tall posts, as
highway=street_lamp

For example:

 http://www.openstreetmap.org/browse/node/1494256519

Clearly that's not correct; what tag would folk suggest?

--


Something from

http://wiki.openstreetmap.org/wiki/OpenSeaMap/Seamark_Tag_Values

depending on exactly what the light characteristsics are

David


Andy Mabbett
@pigsonthewing
http://pigsonthewing.org.uk







___
Talk-GB mailing list
Talk-GB@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-gb


Re: [Talk-GB] Drinking Map of UK

2011-11-07 Thread Jonathan Bennett

On 05/11/2011 21:48, Graham Jones wrote:


I know that tagging for the renderer is frowned upon, but I really do
not like all these colons in key names, because (as far as I know) that
means having an extra column in the database produced by osm2pgsql for
renderingand every time I want to add an extra column it means an
entire re-import of the databse.


I don't claim to be an osm2pgsql expert, but I think that's a 
misunderstanding of the situation. I think *any* new tag added to 
osm.xml results in an extra column, whether it has a colon or not.


Generally you shouldn't consider any performance implications when 
creating a tag, because you don't know what will change in the next 
version of the code. The 
easy-for-mappers-but-maybe-a-bit-computationally-intensive scheme you're 
trying to avoid may become a non-issue with a few lines of code changed. 
Equally the opposite may happen.


For information, I'm assured that extra columns produce next to no 
performance degradation anyway since osm2pgsql started using hstore.


Jonathan.

___
Talk-GB mailing list
Talk-GB@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-gb


Re: [Talk-GB] How to tag marine lights on posts

2011-11-07 Thread Malcolm Herring
These are warning beacons to mark the line of reefs. The appropriate 
OpenSeaMap tagging would be:


seamark:type=beacon_special_purpose
seamark:beacon_special_purpose:category=artificial_reef
seamark:special_purpose_beacon:shape=pile
seamark:light:colour=whatever the colour of the light is
seamark:light:character=whatever the flashing pattern is
seamark:topmark:shape=if it has a topmark, the shape
seamark:topmark:colour=if it has a topmark, the colour

NB: these tags will only be rendered on OpenSeaMap (an overlay to the 
StreetMap).


man_made=beacon would be appropriate for the StreetMap, although I don't 
know whether this tag is rendered.




___
Talk-GB mailing list
Talk-GB@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-gb


Re: [Talk-GB] Drinking Map of UK

2011-11-07 Thread Graham Jones
Hi Jonathan,

 I don't claim to be an osm2pgsql expert, but I think that's a
 misunderstanding of the situation. I think *any* new tag added to osm.xml
 results in an extra column, whether it has a colon or not.

You are right, the colons are not significant.  What I should have said is
that I do not like inventing new keys when they are not necessary because
they end up needing to be an extra column in the database - adding a colon
to an existing key may appear to be some sort of lower level in a
hierarchy, but as far as I can tell it is just creating a new key that
looks similar to the existing one - at least in the osm2pgsql schema.

In this specific case we have two options:
 - craft = brewery
 - craft = cider
 - craft = brewery; cider etc. etc...

or
 - craft:brewery = true
 - craft:cider = true

both achieve the same thing, but the first uses only a single, pre-existing
key, whereas the second creates two new ones.
If the second version ended up storing boolean values, I could see an
argument for it because it could reduce storage space, but everything is
just text, so there is not much in it.



 Generally you shouldn't consider any performance implications when
 creating a tag, because you don't know what will change in the next version
 of the code. The easy-for-mappers-but-maybe-a-**bit-computationally-intensive
 scheme you're trying to avoid may become a non-issue with a few lines of
 code changed. Equally the opposite may happen.

 Not too sure about that - I don't think either of the options is
significantly harder for mappers!


 For information, I'm assured that extra columns produce next to no
 performance degradation anyway since osm2pgsql started using hstore.

I am thinking about scrapping my hstore enabled database because things
seem to have got a lot slower since I added it, but might do a bit more
testing first.

It is as much about neatness as performance - with a simple 'craft=' schema
I can have a single sql query that extracts everything with a craft= tag,
then just filter on the value of craft to decide how to render it.   With
craft, craft:brewery, craft:cider etc., they will each need a  different
bit of sql.

All quite possible, just the simpler one seems neater to me.

Graham.

-- 
Graham Jones
Hartlepool, UK.
___
Talk-GB mailing list
Talk-GB@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-gb


Re: [Talk-GB] How to tag marine lights on posts

2011-11-07 Thread Andy Mabbett
On 7 November 2011 18:28, Malcolm Herring
malcolm.herr...@btinternet.com wrote:
 These are warning beacons to mark the line of reefs. The appropriate
 OpenSeaMap tagging would be:

 seamark:type=beacon_special_purpose
 seamark:beacon_special_purpose:category=artificial_reef
 seamark:special_purpose_beacon:shape=pile
 seamark:light:colour=whatever the colour of the light is
 seamark:light:character=whatever the flashing pattern is
 seamark:topmark:shape=if it has a topmark, the shape
 seamark:topmark:colour=if it has a topmark, the colour

 NB: these tags will only be rendered on OpenSeaMap (an overlay to the
 StreetMap).

 man_made=beacon would be appropriate for the StreetMap, although I don't
 know whether this tag is rendered.

Thank you. I've used some of those, but I only saw them during
daytime, so can't comment on the colour or pattern of the lights.

I'd tagged what you all reefs as islands; I've now added reef as well.

-- 
Andy Mabbett
@pigsonthewing
http://pigsonthewing.org.uk

___
Talk-GB mailing list
Talk-GB@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-gb