Re: [tboot-devel] [PATCH] Fix crash when TPM is missing

2014-02-20 Thread Ed Swierk
Signed-off-by: Ed Swierk On Thu, Feb 20, 2014 at 9:23 PM, Wei, Gang wrote: > Ed Swierk wrote on 2014-02-21: >> The latest tboot crashes during boot if there's no TPM at all, because >> write_tb_error_code() tries to dereference the null g_tpm pointer. >> >> IMHO all the functions that dereferen

Re: [tboot-devel] [PATCH] Fix crash when TPM is missing

2014-02-20 Thread Wei, Gang
Ed Swierk wrote on 2014-02-21: > The latest tboot crashes during boot if there's no TPM at all, because > write_tb_error_code() tries to dereference the null g_tpm pointer. > > IMHO all the functions that dereference g_tpm should first check if > it's null, and return an error code. This patch fixe

[tboot-devel] [PATCH] Fix crash when TPM is missing

2014-02-20 Thread Ed Swierk
The latest tboot crashes during boot if there's no TPM at all, because write_tb_error_code() tries to dereference the null g_tpm pointer. IMHO all the functions that dereference g_tpm should first check if it's null, and return an error code. This patch fixes only one instance. diff --git a/tboot/