Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
, g_feat_ctrl_msr); +} -Original Message- From: Bandan Das [mailto:b...@redhat.com] Sent: Tuesday, May 10, 2016 3:03 PM To: Sun, Ning Cc: Tony Camuso ; tboot-devel@lists.sourceforge.net Subject: Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR &q

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
[mailto:b...@redhat.com] Sent: Tuesday, May 10, 2016 2:37 PM To: Sun, Ning Cc: Tony Camuso ; tboot-devel@lists.sourceforge.net Subject: Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR "Sun, Ning" writes: > Tboot should run on bare-metal TXT ena

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
Subject: Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR "Sun, Ning" writes: >> BTW, table 35-2 in the spec says the msr is present if >> cpuid.01h.ecx(bit 5 or 6) is 1. I think we should check for both vmx >> and smx before t

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
--- From: Bandan Das [mailto:b...@redhat.com] > Sent: Thursday, May 05, 2016 10:02 AM To: Sun, Ning > Cc: Tony Camuso ; > tboot-devel@lists.sourceforge.net Subject: Re: [tboot-devel] [PATCH] > Check for VMX support before reading feature control MSR > > "Sun, Ning"

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Tony Camuso
On 05/10/2016 09:58 AM, Sun, Ning wrote: > > > We got similar tboot log as yours, this was a failure in creating a trusted > environment. > Please try my patch for your reported issue, which was tested pass on our > machines. Thanks, Ning. You are correct. I was unable to set a successful polic

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
We got similar tboot log as yours, this was a failure in creating a trusted environment. Please try my patch for your reported issue, which was tested pass on our machines. > On May 10, 2016, at 6:14 AM, Tony Camuso wrote: > >> On 05/09/2016 07:51 PM, Sun, Ning wrote: >> BanDan, Tony, >> >>

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Tony Camuso
On 05/09/2016 07:51 PM, Sun, Ning wrote: > BanDan, Tony, > > We tried out your patch, unfortunately it did not work on our > machines, did you test your patch before submitting it?> > -ning Yes, I did test it, and I just tested it again, on bare metal and on the virtual guest. Below is what I g

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-09 Thread Sun, Ning
@lists.sourceforge.net Subject: Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR "Sun, Ning" writes: > Hi Tony, Bandan, > > Thanks very much for pointing out the bug and providing the fix. > Here is an alternative patch, in which just one func

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-04 Thread Sun, Ning
Hi Tony, Bandan, Thanks very much for pointing out the bug and providing the fix. Here is an alternative patch, in which just one function was modified, let me know if there is any question about it: diff -r 1ed81e157733 tboot/txt/verify.c --- a/tboot/txt/verify.cWed Apr 20 16:31:18 2016