Re: [tboot-devel] [PATCH 1/7] x86, acpi, tboot: Have a ACPI os prepare sleep instead of calling tboot_sleep.

2012-01-11 Thread Cihula, Joseph
ACK > -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Tuesday, January 03, 2012 9:13 AM > To: linux-ker...@vger.kernel.org; r...@sisk.pl; x...@kernel.org; Brown, Len; > Cihula, Joseph; linux- > p...@lists.linux-foundation.org; tboot-devel@lists.sou

Re: [tboot-devel] [PATCH 2/7] tboot: Add return values for tboot_sleep

2012-01-11 Thread Cihula, Joseph
ACK, but tboot_sleep() calls tboot_shutdown() and there are error conditions in that which you are not reflecting upward--i.e. you should make tboot_shutdown() return an 'int' and propagate its errors through tboot_sleep(). Joe > -Original Message- > From: Konrad Rzeszutek Wilk [mailto: