Re: [tboot-devel] Fallback to regular boot on previous TXT launch failure

2017-04-04 Thread Sun, Ning
Thanks for the patch. On client TXT platform, we observed system reset during S3 resume with this patch when ignore_prev_err=false|true was added to tboot cmdline. If this cmdline option is not included in tboot cmdline, Client system can be resumed from s3 successfully. -Ning -Origin

Re: [tboot-devel] Fixed an expression and output format problem

2017-04-04 Thread Sun, Ning
Thanks for the patch. AFAIK, there are some TPM 2.0 support 2 banks, some TPM 2.0 support 3 banks. Do you mean tboot just print out 2 banks on a TPM 2.0 with 3 banks? -ning From: shiwan...@gohighsec.com [mailto:shiwan...@gohighsec.com] Sent: Monday, April 03, 2017 5:36 AM To: tboot-devel Subject

Re: [tboot-devel] Fixed an expression and output format problem

2017-04-04 Thread shiwan...@gohighsec.com
Whether TPM 2.0 support 2 banks or 3 banks,but tboot code only supports two algorithms at present,as follows: u16 tboot_alg_list[] = {TB_HALG_SHA1, TB_HALG_SHA256}; After with my patch,tboot log out is as follows: TBOOT: TPM: supported bank count = 3 TBOOT: TPM: bank alg = 0004 TBOOT: TPM: ba