[tboot-devel] null pointer dereference bug

2017-01-14 Thread shiwan...@gohighsec.com
Hi, There is a null pointer dereference bug in the latest version of tboot-1.9.5. The g_sinit of global variable is used in the function (tpm_detect()),but the g_sinit is a null pointer at this time. The detail of this prosess can be described as follows: tpm_detect() return g_tpm->init(g_tp

[tboot-devel] an issue in function (was_last_boot_error(void))

2017-01-15 Thread shiwan...@gohighsec.com
Hi, There is an issue in function (was_last_boot_error(void)). In begin_launch() , there is a was_last_boot_error().In was_last_boot_error() , there is a read_tb_error_code(). When read_tb_error_code() runs successfully and the value of parameter error is TB_ERR_NONE,the was_last_boot_error() wi

Re: [tboot-devel] an issue in function (was_last_boot_error(void))

2017-01-18 Thread shiwan...@gohighsec.com
*/ if ( read_tb_error_code(&error) ) { -if ( error != TB_ERR_FIXED ) +if ( error != TB_ERR_FIXED && error != TB_ERR_NONE ) return true; } Thanks Wangyi From: Sun, Ning Date: 2017-01-18 02:36 To: shiwan...@gohighsec.com; tboot-devel Subject: RE: [tb

[tboot-devel] null pointer dereference bug

2017-01-19 Thread shiwan...@gohighsec.com
Hi, There is a null pointer dereference bug when Intel TXT disable within BIOS. The variable sinit_region_base is used in the function (get_bios_sinit),but it is a null pointer dereference when Intel TXT disable within BIOS. The detail of this prosess can be described as follows: begin_launch

[tboot-devel] No module images name when the latest tboot is used in Centos 7.2

2017-03-11 Thread shiwan...@gohighsec.com
Hi, There is no module images name when the latest tboot is used in Centos 7.2. In Centos 7.2, it seems that grub2 does not pass boot image name to tboot. When loading module images in Centos 7.2, the tboot shows "TBOOT: checking if module is an SINIT for this platform..." in tboot log. But in Ce

[tboot-devel] Fixed an expression and output format problem

2017-04-03 Thread shiwan...@gohighsec.com
Hi, There is an expression and output format problem. Firstly,number of algorithms should be %d instead of %08X,it will be more readable. Secondly,log expression is not accurate.Tpm2.0 supports three algorithms,as follows: TBOOT: TPM: supported bank count = 3 TBOOT: TPM: bank alg = 0004 TBOO

Re: [tboot-devel] Fixed an expression and output format problem

2017-04-04 Thread shiwan...@gohighsec.com
= 000b TBOOT: TPM: bank alg = 0012 TBOOT: TPM: supported alg count = 0002 TBOOT: 0004 TBOOT: 000B Thanks, Wangyi From: Sun, Ning Date: 2017-04-05 07:58 To: shiwan...@gohighsec.com; tboot-devel Subject: RE: [tboot-devel] Fixed an expression and output format problem Thanks

[tboot-devel] Fix an logical error in function (bool evtlog_append(uint8_t pcr, hash_list_t *hl, uint32_t type))

2017-07-12 Thread shiwan...@gohighsec.com
Hi, There is a logical error in function(bool evtlog_append(uint8_t pcr, hash_list_t *hl, uint32_t type)). In function evtlog_append,here always returns true whether it's TPM1.2 or TPM2.0. Signed-off-by: Shi Wangyi diff -r 4fbb0a7d2f57 -r 950c7f260cfe tboot/txt/txt.c --- a/tboot/txt/txt.c Tue

[tboot-devel] Fix a bug in hash_module function

2018-02-26 Thread shiwan...@gohighsec.com
Hi, There is a bug in hash_module function. My machine is tpm2.0. As I have no machine of tpm1.2, I don't know whether it has the same issue for the machine of tpm1.2. When I set extpol=agile in the command line of tboot, module 1 can't be measured. Below is the related section of the TBOOT outp

[tboot-devel] Add centos7 instructions for Use in EFI boot mode

2018-03-19 Thread shiwan...@gohighsec.com
Hi, Add centos7 instructions for Use in EFI boot mode. Signed-off-by: Shi Wangyi diff -r d4452e9380b8 -r 0fccca25f36a README --- a/READMEThu Mar 15 09:38:04 2018 -0700 +++ b/READMEMon Mar 19 22:13:36 2018 -0400 @@ -224,6 +224,23 @@ Reboot to choose tboot grub option for TXT lau