Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-05-13 Thread Petr Vorel via tcpdump-workers
--- Begin Message --- Hi Guy, > BTW, having just implemented SLL2 support in Wireshark, the layout of the > header really doesn't work as well as I'd like with ARPHRD_NETLINK packets. > I'd prefer something like > struct header { > uint16_t hatype;/* link-layer address

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-03-30 Thread Petr Vorel via tcpdump-workers
--- Begin Message --- Hi Guy, > > BTW man pages (pcap.3pcap.in, pcap_datalink.3pcap.in, pcap_loop.3pcap and > > pcap_next_ex.3pcap) mention only DLT_LINUX_SLL. > Fixed in commit ffb99eceefd31771a4aa89f0da5d02a3c53cfd03. Thanks a lot! BTW how about DLT_LINUX_SLL2 as the default? What does it

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-03-30 Thread Petr Vorel via tcpdump-workers
--- Begin Message --- Hi Francois, > > The "-y" flag to tcpdump allows you to specify capturing with > > DLT_LINUX_SLL2. > Should DLT_LINUX_SLL2 be now the default when tcpdump is built with a libpcap > that support it ? I'd be glad if it was so, but not sure if first wireshark needs to

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-03-30 Thread Petr Vorel via tcpdump-workers
--- Begin Message --- Hi Bill, > The "-y" flag to tcpdump allows you to specify capturing with > DLT_LINUX_SLL2. Thanks a lot! Kind regards, Petr --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org

[tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-03-11 Thread Petr Vorel via tcpdump-workers
--- Begin Message --- Hi Guy, some time ago we did together DLT_LINUX_SLL2 support for libpcap. I don't remember the details, but IMHO it was enabled by default. When now I compile libpcap and tcpdump, it's still using DLT_LINUX_SLL: tcpdump: listening on any, link-type LINUX_SLL (Linux cooked

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 2/2] Add sll_ifindex into sll_header + use it to print ifname

2018-07-18 Thread Petr Vorel
Hi Denis, > On Fri, 13 Jul 2018 08:40:47 +0100 Denis Ovsienko > wrote > > On Thu, 12 Jul 2018 20:38:08 +0100 Guy Harris > wrote > > > On Jul 12, 2018, at 11:33 AM, Petr Vorel wrote: > > > > +#ifdef PCAP_SUPPORT_SLL_V2 &g

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 2/2] Add sll_ifindex into sll_header + use it to print ifname

2018-07-12 Thread Petr Vorel
Hi Guy, > What happens if you capture traffic on machine A and print it on machine B, > where machines A and B have different sets of network interfaces? > (This is why pcapng has Interface Description Blocks - so that the list of > interfaces is part of the file, so you use *that*, rather

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 0/2] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi Guy, > On Jul 12, 2018, at 11:33 AM, Petr Vorel wrote: > > Main problem is that libpcap supports only one from LINKTYPE_LINUX_SLL > > and LINKTYPE_LINUX_SLL2 > Not in the version in the libpcap Git repository; both are supported. > > Tests (make check) are broken as

Re: [tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi Guy, > On Jul 12, 2018, at 11:02 AM, Petr Vorel wrote: > > Unfortunately I haven't found a way how to coexist in runtime library > > both LINKTYPE_LINUX_SLL and LINKTYPE_LINUX_SLL2, > See libpcap commit 8cff296dc7c321c76933359d586dbde5b580ce8c, which adds

[tcpdump-workers] [RFC TCPDUMP PATCH 2/2] Add sll_ifindex into sll_header + use it to print ifname

2018-07-12 Thread Petr Vorel
From: Petr Vorel Implements: GH the-tcpdump-group/libpcap#127 Signed-off-by: Petr Vorel --- config.h.in | 4 configure | 20 configure.ac | 10 ++ missing/dlnames.c | 3 +++ print-sll.c | 27 +-- print.c

[tcpdump-workers] [RFC TCPDUMP PATCH 1/2] Update configure

2018-07-12 Thread Petr Vorel
Signed-off-by: Petr Vorel --- This commit is just to make changes in configure in next commit clearer. Getting rid of configure in git might be accepted faster than this patch. --- configure | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/configure b/configure

[tcpdump-workers] [RFC TCPDUMP PATCH 0/2] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
] https://lists.sandelman.ca/pipermail/tcpdump-workers/2018-July/001011.html [2] https://travis-ci.org/pevik/tcpdump/jobs/403216728 Petr Vorel (2): Update configure Add sll_ifindex into sll_header + use it to print ifname config.h.in | 4 configure | 34

Re: [tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi, > For users which needs, who needs to have LINKTYPE_LINUX_SLL, they have > to compile libpcap with --enable-sll-v2 option. Sorry, I meant --disable-sll-v2. Kind regards, Petr ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org

[tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
cpdump.org/linktypes/LINKTYPE_LINUX_SLL.html Petr Vorel (1): Implement DLT_LINUX_SLL2 INSTALL.md | 2 +- cmakeconfig.h.in | 3 +++ config.h.in | 4 configure| 20 configure.ac | 10 ++ gencode.c| 3 +++ pcap-common.c| 1 + p

[tcpdump-workers] [RFC LIBPCAP PATCH 1/1] Implement DLT_LINUX_SLL2

2018-07-12 Thread Petr Vorel
From: Petr Vorel Implements: GH the-tcpdump-group/libpcap#127 Signed-off-by: Petr Vorel Signed-off-by: Petr Vorel --- INSTALL.md | 2 +- cmakeconfig.h.in | 3 +++ config.h.in | 4 configure| 20 configure.ac | 10 ++ gencode.c

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Petr Vorel
Hi, > > 1) Keeping LINKTYPE_LINUX_SLL [2] altogether with LINKTYPE_LINUX_SLL2, > > compile > > both (having one of them as default for linux, second allow to use with -y > > switch > > in tcpdump). > > 2) Keeping LINKTYPE_LINUX_SLL [2] altogether with LINKTYPE_LINUX_SLL2 but > > compile only

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Petr Vorel
Hi, > Libpcap's configure script is outdated. > Although I'd prefer remove configure from git and ask user to run autoconf > manually (+ update travis and coverity to run it, of course), but maybe you > have > some reason for it (problematic autotools instalation on windows?), so I just > update

[tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Petr Vorel
Hi, Libpcap's configure script is outdated. Although I'd prefer remove configure from git and ask user to run autoconf manually (+ update travis and coverity to run it, of course), but maybe you have some reason for it (problematic autotools instalation on windows?), so I just update it in this

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Petr Vorel
Hi, > > This requires a numerical value to be assigned to LINKTYPE_LINUX_SLL2 and > > DLT_LINUX_SLL2; no such value has yet been assigned. > It seems it should be 276 (next free number). > I've sent it as a pull request to github (I prefer using git format-patch && > git > send-email to ML as

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Petr Vorel
Hi Guy, > (Re-sending, from my real e-mail address rather than my forwarding-for-life > e-mail address, because the latter had issues and required moderation.) I had some issues with not appearing messages as well :(. > On Jul 10, 2018, at 9:34 AM, Petr Vorel wrote: > &

[tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-10 Thread Petr Vorel
Hi, I've sent my first email into ML yesterday, but it's not in ML. I'm sorry to these who might read it twice. I'm playing with implementing LINKTYPE_LINUX_SLL2 [1] as a part of [3] in libpcap and using it in tcpdump. I wonder what is a correct solution for libpcap: 1) Keeping