--- Begin Message ---
On Tue, Jan 5, 2021 at 8:10 PM Denis Ovsienko via tcpdump-workers <
tcpdump-workers@lists.tcpdump.org> wrote:
> Bill Fenner via tcpdump-workers
> wrote:
>
> > I just wanted to share some of my thinking about how to proceed with
> > the truncation-related changes on the road
--- Begin Message ---
On Mon, 4 Jan 2021 12:35:29 -0500
Bill Fenner via tcpdump-workers
wrote:
> I just wanted to share some of my thinking about how to proceed with
> the truncation-related changes on the road to 5.0.0.
>
> 1. Improve code coverage for the printer that's being modified. (This
--- Begin Message ---
I just wanted to share some of my thinking about how to proceed with the
truncation-related changes on the road to 5.0.0.
1. Improve code coverage for the printer that's being modified. (This
ensures that the code being modified has a corresponding test pcap that can
be
--- Begin Message ---
On 18/12/2020 21:36, Francois-Xavier Le Bail via tcpdump-workers wrote:
> The post setjmp/longjmp updates take more time than expected. About 30% of
> the work is done.
> To avoid keeping too long the other updates in the master branch, we plan to
> release soon a 4.99.0
>
--- Begin Message ---
On 05/09/2020 18:20, Francois-Xavier Le Bail via tcpdump-workers wrote:
> Hello,
>
> Some people ask for a new version of tcpdump.
>
> To understand why we cannot release now, here is some information:
>
> We are in the process to harden the tcpdump code with use of new
--- Begin Message ---
On 24/09/2020 21:51, Denis Ovsienko via tcpdump-workers wrote:
> On Sat, 5 Sep 2020 18:20:42 +0200
> Francois-Xavier Le Bail via tcpdump-workers
> wrote:
>
> [...]
>> 2) Process all the truncated cases with:
>> ndo->ndo_ll_hdr_len = 0;
>> longjmp(ndo->ndo_truncated, 1);
>>
--- Begin Message ---
On Fri, 25 Sep 2020 03:04:21 +0100
Denis Ovsienko via tcpdump-workers
wrote:
[...]
> == Summary: the method seems to work well, there is a clean reference
> implementation, it should be easy to apply to other printers that
> implement similar encodings, there may be
--- Begin Message ---
On Thu, 17 Sep 2020 15:15:25 +0100
Denis Ovsienko via tcpdump-workers
wrote:
> On Sat, 5 Sep 2020 18:20:42 +0200
> Francois-Xavier Le Bail via tcpdump-workers
> wrote:
>
> > 2) Process all the truncated cases with:
> > ndo->ndo_ll_hdr_len = 0;
> >
--- Begin Message ---
On Fri, 18 Sep 2020 10:25:13 +0200
Francois-Xavier Le Bail wrote:
[...]
> switch (setjmp(ndo->early_end)) {
> case 0:
> /* Print the packet. */
> (ndo->ndo_if_printer)(ndo, h, sp);
> break;
> case
--- Begin Message ---
On Sat, 5 Sep 2020 18:20:42 +0200
Francois-Xavier Le Bail via tcpdump-workers
wrote:
[...]
> 2) Process all the truncated cases with:
> ndo->ndo_ll_hdr_len = 0;
> longjmp(ndo->ndo_truncated, 1);
> (With a new macro, like 'ND_TRUNCATED' or 'ND_IS_TRUNCATED')
[...]
It could
--- Begin Message ---
On 20/09/2020 18:28, Michael Richardson wrote:
>
> Given:
>
> case CTRL_BA:
> (*) ND_TCHECK_LEN(p, CTRL_BA_HDRLEN);
> if (!ndo->ndo_eflag)
> ND_PRINT(" RA:%s ",
> GET_ETHERADDR_STRING(((const
--- Begin Message ---
On 20/09/2020 18:25, Michael Richardson wrote:
>
> Also, please confirm for me that these lines like this are redundant:
>
> ND_TCHECK_LEN(p, IEEE802_11_REASON_LEN);
> if (length < IEEE802_11_REASON_LEN)
> goto trunc;
>
> In fact, we don't
--- Begin Message ---
On Fri, 18 Sep 2020 10:25:13 +0200
Francois-Xavier Le Bail wrote:
[...]
> Or perhaps better (no need for a 'early_end_reason' field):
> switch (setjmp(ndo->early_end)) {
> case 0:
> /* Print the packet. */
>
--- Begin Message ---
On 17/09/2020 22:05, Francois-Xavier Le Bail via tcpdump-workers wrote:
> On 17/09/2020 16:15, Denis Ovsienko via tcpdump-workers wrote:
>> On Sat, 5 Sep 2020 18:20:42 +0200
>> Francois-Xavier Le Bail via tcpdump-workers
>> wrote:
>>
>>> 2) Process all the truncated cases
--- Begin Message ---
On Thu, 17 Sep 2020 22:05:30 +0200
Francois-Xavier Le Bail wrote:
[...]
> Should we have something like:
>
> if (setjmp(ndo->early_end) == 0) {
> /* Print the packet. */
> (ndo->ndo_if_printer)(ndo, h, sp);
> } else {
>
--- Begin Message ---
On 17/09/2020 16:15, Denis Ovsienko via tcpdump-workers wrote:
> On Sat, 5 Sep 2020 18:20:42 +0200
> Francois-Xavier Le Bail via tcpdump-workers
> wrote:
>
>> 2) Process all the truncated cases with:
>> ndo->ndo_ll_hdr_len = 0;
>> longjmp(ndo->ndo_truncated, 1);
>> (With a
--- Begin Message ---
On Sat, 5 Sep 2020 18:20:42 +0200
Francois-Xavier Le Bail via tcpdump-workers
wrote:
> 2) Process all the truncated cases with:
> ndo->ndo_ll_hdr_len = 0;
> longjmp(ndo->ndo_truncated, 1);
> (With a new macro, like 'ND_TRUNCATED' or 'ND_IS_TRUNCATED')
The master branch now
--- Begin Message ---
On Sat, 5 Sep 2020 18:20:42 +0200
Francois-Xavier Le Bail via tcpdump-workers
wrote:
[...]
> We have:
> 1) The "old" way, before the patch, returning from all functions and
> at the end returning the header length to the link-layer dissector
> (xxx_if_print), updating the
--- Begin Message ---
On Mon, 7 Sep 2020 17:26:28 +0200
Francois-Xavier Le Bail wrote:
> On 07/09/2020 16:43, Denis Ovsienko via tcpdump-workers wrote:
> > On Sat, 5 Sep 2020 18:20:42 +0200
> > Thank you for posting a detailed explanation and making the first
> > round of changes. I am looking
--- Begin Message ---
On 07/09/2020 16:43, Denis Ovsienko via tcpdump-workers wrote:
> On Sat, 5 Sep 2020 18:20:42 +0200
> Thank you for posting a detailed explanation and making the first round
> of changes. I am looking into the logic of this work. As soon as it
> feels I can tell the right
--- Begin Message ---
On Sat, 5 Sep 2020 18:20:42 +0200
Francois-Xavier Le Bail via tcpdump-workers
wrote:
Hello Francois-Xavier.
Thank you for posting a detailed explanation and making the first round
of changes. I am looking into the logic of this work. As soon as it
feels I can tell the
--- Begin Message ---
Hello,
Some people ask for a new version of tcpdump.
To understand why we cannot release now, here is some information:
We are in the process to harden the tcpdump code with use of new (GET_) macros
(with setjmp/longjmp
logic) to fetch the packet data without have to do
22 matches
Mail list logo
