Re: [tcpdump-workers] scan_sys_class_net bug in pcap-linux.c

2012-12-06 Thread Paul Sheer
cool i would encourage tcpdump-workers to try to eventually support opening up multiple devices and listening on all of them for instance, the command, tcpdump -e -i any that would show output like: 11:42:25.170257 eth100:24:bf:5b:d4:d6 00:0c:29:f7:7f:e9, ethertype IPv4

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Ani Sinha
On Wed, Oct 31, 2012 at 5:50 PM, Guy Harris g...@alum.mit.edu wrote: On Oct 31, 2012, at 3:35 PM, Ani Sinha a...@aristanetworks.com wrote: yes but if the packet is passed to the filter within libpcap (when we are not using the kernel filter) before the reinsertion, ...that would be a bug.

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Eric W. Biederman
Ani Sinha a...@aristanetworks.com writes: On Sat, Nov 17, 2012 at 3:33 PM, Eric W. Biederman ebied...@xmission.com wrote: the vlan header in packets as we receive them. The code is correct except for the case of packets in vlan 0. Currently the packet reconstruction is ambiguous. The most

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Ani Sinha
On Thu, Dec 6, 2012 at 2:19 PM, Eric W. Biederman ebied...@xmission.com wrote: Ani Sinha a...@aristanetworks.com writes: On Sat, Nov 17, 2012 at 3:33 PM, Eric W. Biederman ebied...@xmission.com wrote: the vlan header in packets as we receive them. The code is correct except for the case of

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Ani Sinha
On Thu, Dec 6, 2012 at 2:19 PM, Eric W. Biederman ebied...@xmission.com wrote: Ani Sinha a...@aristanetworks.com writes: May be this? Two things. - TP_STATUS_VLAN_VALID lives in the tp_status field not the tp_vlan_tci field. - To work on older kernels with binaries compiled with newer

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Eric W. Biederman
Ani Sinha a...@aristanetworks.com writes: On Thu, Dec 6, 2012 at 2:19 PM, Eric W. Biederman ebied...@xmission.com wrote: Ani Sinha a...@aristanetworks.com writes: May be this? Two things. - TP_STATUS_VLAN_VALID lives in the tp_status field not the tp_vlan_tci field. - To work on

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Ani Sinha
The patch is whitespace damaged. And one of your test is using || instead of OK, using alpine now :-) The test should be not ||. aargh! I am retarded! Fixed. Hopefully 3rd time is a charm :-) ani pcap-linux.c | 50 +++--- 1 files

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Ani Sinha
The patch is whitespace damaged. And one of your test is using || instead of OK, using alpine now :-) The test should be not ||. aargh! I am retarded! Fixed. Hopefully 3rd time is a charm :-) ani pcap-linux.c | 50 +++--- 1 files changed,

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Eric W. Biederman
Ani Sinha a...@aristanetworks.com writes: The patch is whitespace damaged. And one of your test is using || instead of OK, using alpine now :-) The test should be not ||. aargh! I am retarded! Fixed. Hopefully 3rd time is a charm :-) Acked-by: Eric W. Biederman ebied...@xmission.com

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-06 Thread Michael Richardson
Eric == Eric W Biederman ebied...@xmission.com writes: Eric It is a bit odd that you are indenting with spaces instead of tabs Eric in a file that is indented with tab. Again libpcap isn't my code so I Eric don't care but someone else might. tabs are hysterical raisens. Send two