Re: free() sizes for ahc(4)

2019-05-14 Thread Jan Klemkow
On Tue, May 14, 2019 at 10:35:22AM +, Miod Vallat wrote: > Note ahc_set_name() gets invoked with the dv_xname field of a struct > device, so it's not a good idea to free anything, should it be invoked > more than once. > > Tested on: > ahc0 at pci0 dev 1 function 0 "Adaptec AIC-7880" rev

Re: softraid(4): fix wrong malloc size and zero sized free calls

2019-05-13 Thread Jan Klemkow
On Mon, May 13, 2019 at 07:25:37PM -0400, Ted Unangst wrote: > Jan Klemkow wrote: > > The diff mainly add sizes to free(9) calls. But, while here fix a > > malloc(9) call with the wrong size in sr_ioctl_installboot(). > > omi->omi_som is allocated with size of struct

softraid(4): fix wrong malloc size and zero sized free calls

2019-05-13 Thread Jan Klemkow
Hi, The diff mainly add sizes to free(9) calls. But, while here fix a malloc(9) call with the wrong size in sr_ioctl_installboot(). omi->omi_som is allocated with size of struct sr_meta_crypto, but used as struct sr_meta_boot later. One free(9) with size zero left over in sr_discipline_free().

enable cy(4) by default on amd64

2019-05-12 Thread Jan Klemkow
Hi, I use tree cy(4) cards on amd64 for several releases. Its totally stable and works fine beside known bugs already mentioned in the manpage. Thus, I would prefer to enabled it by default in amd64 as it is in i386. Bye, Jan Index: arch/amd64/conf/GENERIC

sv(4): fix free with zero size

2019-05-12 Thread Jan Klemkow
Hi, The following diff fixes "free with zero size" in sv(4). Builds and stats the kernel with sv at pci and audio at sv enabled. bye, Jan Index: dev/pci/sv.c === RCS file: /cvs/src/sys/dev/pci/sv.c,v retrieving revision 1.34 diff

Re: ftpd(8): rm dead code and simplifies popen clone

2019-05-08 Thread Jan Klemkow
On Wed, May 08, 2019 at 07:10:37PM -0400, Ted Unangst wrote: > Jan Klemkow wrote: > > - * Special version of popen which avoids call to shell. This ensures noone > > + * Special version of popen which avoids call to shell. This ensures none > > If we don't like noone,

ftpd(8): rm dead code and simplifies popen clone

2019-05-08 Thread Jan Klemkow
Hi, This diff removes dead code from ftpd(8). In the past ftpd executes ls(1) for directory listings. But, quite a while now It justs calls the main function of the linked in ls(1) directly. The code path to the main function of ls(1) as well as the read-only mode are hard coded in the current

diff: reboot(8): document the -l option

2019-03-25 Thread Jan Klemkow
Hi, The following diff adds missing documentation for the -l option of reboot(8) as its done in NetBSD. Bye, Jan Index: reboot.8 === RCS file: /cvs/src/sbin/reboot/reboot.8,v retrieving revision 1.50 diff -u -p -r1.50 reboot.8 ---

diff: add support for ANT-USBStick2 to uscom(4)

2019-02-22 Thread Jan Klemkow
Hi, The diff below adds support for the Dynastream "ANT USBStick2" to uscom(4). The device attached with the following message: uscom0 at uhub0 port 2 configuration 1 interface 0 "Dynastream Innovations ANT USBStick2" rev 2.00/1.00 addr 2 ucom0 at uscom0 portno 0 Additionally, I tested the

diff: add missing bit description for pkthdr_pf.flags

2019-02-08 Thread Jan Klemkow
Hi, The following diff adds the description of the second bit of the struct pkthdr_pf field flags. bye, Jan Index: sys/sys/mbuf.h === RCS file: /cvs/src/sys/sys/mbuf.h,v retrieving revision 1.241 diff -u -p -r1.241 mbuf.h ---

snmpd: dup open ttys to /dev/null in demons mode

2019-01-07 Thread Jan Klemkow
Hi, This diff is similar to bluhm@'s fix for httpd and relayd, but for snmpd. > During the fork+exec implementation, daemon(3) was moved after > proc_init(). As a consequence httpd(8) and relayd(8) child processes > do not detach from the terminal anymore. Dup /dev/null to the stdio > file

diff: new PCI Vendor and Product ID for RocketPort serial card

2019-01-07 Thread Jan Klemkow
Hi, the following diff adds the PCI vendor and product ID for a PCI multiport serial card. dmesg shows the device as: "Comtrol Corporation RocketPort PCI 16-port Serial" rev 0x01 at pci1 dev 1 function 0 not configured bye, Jan Index: pci/pcidevs

diff: fix missing include guard in dev/biovar.h

2018-12-19 Thread Jan Klemkow
Hi, I run into double definition problems because of a missing include guard in dev/biovar.h. The diff below should fix that issue. Bye, Jan Index: sys/dev/biovar.h === RCS file: /cvs/src/sys/dev/biovar.h,v retrieving revision

Re: diff: ftpd(8): fix for sign-compare compiler warnings

2018-12-06 Thread Jan Klemkow
On Tue, Nov 27, 2018 at 09:03:15AM +0100, Theo Buehler wrote: > On Sun, Nov 25, 2018 at 12:32:23AM +0100, Jan Klemkow wrote: > > This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by > > using the right types for 'i' and 'len'. One warning is left, but I > >

diff: ftpd(8): fix for sign-compare compiler warnings

2018-11-24 Thread Jan Klemkow
Hi, This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by using the right types for 'i' and 'len'. One warning is left, but I don't see that it's fixable without suppressing the warning by a cast of len to size_t. And casting might be controversial in this case?!

Re: diff: Fix send(2) EACCES mistake

2018-11-10 Thread Jan Klemkow
On Sat, Nov 10, 2018 at 11:22:48AM +0100, Claudio Jeker wrote: > On Fri, Nov 09, 2018 at 03:49:32PM -0700, Alexander Bluhm wrote: > > On Fri, Nov 09, 2018 at 09:03:20PM +0100, Jan Klemkow wrote: > > > On Fri, Nov 09, 2018 at 12:36:20PM -0700, Alexander Bluhm wrote: > >

Re: diff: Fix send(2) EACCES mistake

2018-11-09 Thread Jan Klemkow
On Fri, Nov 09, 2018 at 12:36:20PM -0700, Alexander Bluhm wrote: > On Fri, Nov 09, 2018 at 08:24:47PM +0100, Jan Klemkow wrote: > > Perfect, I also think its more intuitive to get a "permission denied" > > in case of a pf(4) block then a "Host is unreachable".

Re: diff: Fix send(2) EACCES mistake

2018-11-09 Thread Jan Klemkow
On Fri, Nov 09, 2018 at 06:57:16PM +0100, Claudio Jeker wrote: > On Fri, Nov 09, 2018 at 06:09:34PM +0100, Jan Klemkow wrote: > > I printed the code path below to make it easier to review the diff. > > While I was following the code path again, I found an inconsistency > &g

Re: diff: Fix send(2) EACCES mistake

2018-11-09 Thread Jan Klemkow
On Tue, Oct 30, 2018 at 07:13:24AM +, Jason McIntyre wrote: > On Mon, Oct 29, 2018 at 11:55:52PM +0100, Jan Klemkow wrote: > > On Sun, Oct 28, 2018 at 10:58:34PM +, Jason McIntyre wrote: > > > On Sun, Oct 28, 2018 at 09:40:33PM +0100, Jan Klemkow wrote: > > >

Re: diff: Fix send(2) EACCES mistake

2018-10-29 Thread Jan Klemkow
On Sun, Oct 28, 2018 at 10:58:34PM +, Jason McIntyre wrote: > On Sun, Oct 28, 2018 at 09:40:33PM +0100, Jan Klemkow wrote: > > Unlike the manpage saids or one might think , sendto(2) sets errno to > > EHOSTUNREACH instead of EACCES in cases of blocking by pf(4) or not > &g

diff: Fix send(2) EACCES mistake

2018-10-28 Thread Jan Klemkow
Hi, Unlike the manpage saids or one might think , sendto(2) sets errno to EHOSTUNREACH instead of EACCES in cases of blocking by pf(4) or not enabled broadcasts. Finally I ran into both cases and think, its time to fix this issue. The diff suggests a new explanation that should cover all error

Re: inteldrm(4): uvm write-combining support

2018-10-28 Thread Jan Klemkow
On Sat, Oct 27, 2018 at 12:31:48PM +0200, Mark Kettenis wrote: > > Date: Sat, 27 Oct 2018 17:16:57 +1100 > > From: Jonathan Gray > > > > On Fri, Oct 26, 2018 at 09:47:51PM +0200, Mark Kettenis wrote: > > > Diff below adds support to uvm to create wtite-combining mappings and > > > uses this to

Re: Add acpipci(4) on amd64

2018-10-23 Thread Jan Klemkow
Hi Mark, On Tue, Oct 23, 2018 at 07:32:16PM +0200, Mark Kettenis wrote: > > Date: Tue, 23 Oct 2018 18:40:42 +0200 > > From: Jan Klemkow > > On Mon, Oct 22, 2018 at 09:45:06PM +0200, Mark Kettenis wrote: > > > Diff below adds an acpipci(4) driver on amd64. For

Re: Add acpipci(4) on amd64

2018-10-23 Thread Jan Klemkow
Hi Mark, On Mon, Oct 22, 2018 at 09:45:06PM +0200, Mark Kettenis wrote: > Diff below adds an acpipci(4) driver on amd64. For now the main > purpose of this driver is to make the PCI-specific _OSC calls to > advertise the functionality we support. Most notably this advertises > support for PCIE

diff: ndp(8): hostname lookup via /etc/ethers

2018-10-22 Thread Jan Klemkow
Hi, The following diff adds the option -e to ndp(8), which resolved printed hostnames via /etc/ethers. You are able to recognise hosts with IPv6 auto privacy extension addresses on local IPv6 routers. Also hosts inside of a yp(8) domain are able to lookup their neighbors via the shared

fix: unveil(2) error handling

2018-08-30 Thread Jan Klemkow
Hi, I found a little bug in the unveil(2) error handling. After blocking unveil(2) by unveil(NULL, NULL), an additional unveil(2) call sets errno to EINVAL instead of EPERM as the manpage saids: EPERM An attempt to increase permissions was made, or the path was not accessible, or

diff: add USB ANT-m Stick via uscom(4)

2018-08-09 Thread Jan Klemkow
Hi, the following diff adds support for an USB ANT+ receiver which is used to communicate with wireless fitness tracking devices. The USB device appears as a serial interface. I just add the device ID to the existing uscom(4) driver and enabled it in GENERIC. I don't know why it was

Re: diff: add if group table to snmpd

2018-05-18 Thread Jan Klemkow
On Mon, May 14, 2018 at 09:21:13PM +0200, Jan Klemkow wrote: > On Mon, May 14, 2018 at 06:53:20PM +0100, Stuart Henderson wrote: > > On 2018/05/14 17:59, Jan Klemkow wrote: > > > The following diff adds an interface group table to the OpenBSD MIBs and > > > the OpenSNMPd

Re: [patch] httpd: add tls client certificate authentication

2018-05-16 Thread Jan Klemkow
Hi Jack, On Wed, May 16, 2018 at 05:32:56PM +0930, Jack Burton wrote: > I figured that if we can agree on this much, so httpd can be used for > the authentication-only case (which is all non-fastcgi sites would want) > straight away, that's be a good first step -- then we can come back and >

Re: diff: add if group table to snmpd

2018-05-14 Thread Jan Klemkow
Hi Stuart, On Mon, May 14, 2018 at 06:53:20PM +0100, Stuart Henderson wrote: > On 2018/05/14 17:59, Jan Klemkow wrote: > > The following diff adds an interface group table to the OpenBSD MIBs and > > the OpenSNMPd. The new snmp table helps to keep track of the demote > > v

diff: add if group table to snmpd

2018-05-14 Thread Jan Klemkow
Hi, The following diff adds an interface group table to the OpenBSD MIBs and the OpenSNMPd. The new snmp table helps to keep track of the demote values of more complex carp setups. To iterate directly through all interface groups, the diff has to extent ioctl interface by a new command

Re: diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-03 Thread Jan Klemkow
On Sat, Dec 02, 2017 at 08:37:34PM +0100, Jan Klemkow wrote: > On Sat, Dec 02, 2017 at 08:17:15PM +0100, Jan Klemkow wrote: > > On Fri, Dec 01, 2017 at 04:17:42PM -0700, Theo de Raadt wrote: > > > So two comments: Calling this thing by the right name (escape), > > >

Re: diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-02 Thread Jan Klemkow
On Sat, Dec 02, 2017 at 08:17:15PM +0100, Jan Klemkow wrote: > On Fri, Dec 01, 2017 at 04:17:42PM -0700, Theo de Raadt wrote: > > So two comments: Calling this thing by the right name (escape), > > would allow you to search other programs which have similar functions, > &g

Re: diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-02 Thread Jan Klemkow
On Fri, Dec 01, 2017 at 04:17:42PM -0700, Theo de Raadt wrote: > > The diff adds the option -k (for kiosk mode) > > Congratulations, you win some sort of prize. That is the worst-named > option I have seen in more than a decade. Thanks. :-) > Good idea though, but I think we have better

diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-01 Thread Jan Klemkow
Hi, I run cu(1) as ssh forced command for other users on my machine. This allows them to reach the serial port of their machines over mine. To prevent them of doing filesystem operations or further command executions I implement this diff. The diff adds the option -k (for kiosk mode) to cu(1)

Re: tftpd(8): diff for ip path rewrite

2017-10-27 Thread Jan Klemkow
On Wed, Oct 25, 2017 at 04:54:01PM +, Jeremie Courreges-Anglas wrote: > On Tue, Oct 24 2017, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > > On Mon, Oct 23 2017, Jan Klemkow <j.klem...@wemelug.de> wrote: > >> On Sun, Oct 22, 2017 at 09:32:54PM +,

Re: tftpd(8): diff for ip path rewrite

2017-10-23 Thread Jan Klemkow
On Sun, Oct 22, 2017 at 09:32:54PM +, Jeremie Courreges-Anglas wrote: > On Sat, Oct 21 2017, Jan Klemkow <j.klem...@wemelug.de> wrote: > > On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: > >> On Fri, Oct 20 2017, Sebastien Marie &

Re: tftpd(8): diff for ip path rewrite

2017-10-21 Thread Jan Klemkow
On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: > On Fri, Oct 20 2017, Sebastien Marie <sema...@online.fr> wrote: > > On Thu, Oct 19, 2017 at 08:58:12PM +0200, Jan Klemkow wrote: > >> + char nfilename[PATH_MAX]; > >> + > >

Re: tftpd(8): diff for ip path rewrite

2017-10-19 Thread Jan Klemkow
On Thu, Oct 19, 2017 at 09:36:50AM +, Jeremie Courreges-Anglas wrote: > On Wed, Oct 18 2017, Jan Klemkow <j.klem...@wemelug.de> wrote: > > On Wed, Oct 18, 2017 at 08:37:48PM +, Jason McIntyre wrote: > >> On Wed, Oct 18, 2017 at 10:25:13PM +0200, Jan Klemkow wrot

Re: tftpd(8): diff for ip path rewrite

2017-10-18 Thread Jan Klemkow
On Wed, Oct 18, 2017 at 08:37:48PM +, Jason McIntyre wrote: > On Wed, Oct 18, 2017 at 10:25:13PM +0200, Jan Klemkow wrote: > > This diff adds an option for client IP address path prefixes to the > > tftpd(8). First, I used the -r rewrite socket for this, but... > > >

tftpd(8): diff for ip path rewrite

2017-10-18 Thread Jan Klemkow
Hi, This diff adds an option for client IP address path prefixes to the tftpd(8). First, I used the -r rewrite socket for this, but... If you use the rewrite socket feature, the tftpd(8) will exit with an error when the rewrite socket is closed. A reopen of the socket is not possible, if its

ugold(4): add support for TEMPer1F_H1V1.5F

2017-10-04 Thread Jan Klemkow
Hi, This diff adds support for the "TEMPer1F_H1V1.5F" USB temperature and humidity sensor to the ugold(4) driver. I got reasonable values from the device, but as mentioned in this github issue [1] they are not very accurate. [1]: https://github.com/edorfaus/TEMPered/issues/39 stsp@ : Thanks

Re: [diff] httpd: tls client cert & CRL checks

2017-07-29 Thread Jan Klemkow
Hi Jack, On Fri, Jul 28, 2017 at 02:05:34AM +0930, Jack Burton wrote: > On Thu, 27 Jul 2017 13:10:14 +0200 > > > But, I found a bug in the part of the FastCGI variables. The > > following condition is always false. > > > > > Index: usr.sbin/httpd/server_fcgi.c > > >

Re: [diff] httpd: tls client cert & CRL checks

2017-07-27 Thread Jan Klemkow
Hi Jack, On Fri, Jul 21, 2017 at 06:33:43PM +0930, Jack Burton wrote: > Thoughts? I've tested your diff. The main feature looks fine to me. TLS connections with and with out Clients certs, as well as with and without certificate revocation lists seams to work. Also, the tests are passing.

Re: diff: add missing rtm_send to nd6

2017-06-08 Thread Jan Klemkow
Hi Martin, On Thu, Jun 08, 2017 at 09:44:37AM +0200, Martin Pieuchot wrote: > On 08/06/17(Thu) 00:47, Jan Klemkow wrote: > > This diff adds a missing routing message to the neighbor discovery code. > > The message informs the userland about new reachable IPv6 nodes on the > &g

diff: add missing rtm_send to nd6

2017-06-07 Thread Jan Klemkow
Hi, This diff adds a missing routing message to the neighbor discovery code. The message informs the userland about new reachable IPv6 nodes on the network. The IPv6 network stack acts more like the IPv4 port by this diff. Now, the behavior is like arpcache() in netinet/if_ether.c on line 653.

snmpd: remove unused variables

2017-05-31 Thread Jan Klemkow
Hi, This diff removes two local variables which are never used. bye, Jan Index: trap.c === RCS file: /cvs/src/usr.sbin/snmpd/trap.c,v retrieving revision 1.29 diff -u -p -r1.29 trap.c --- trap.c 21 Apr 2017 13:46:15 -

Re: httpd: proposed patch to add TLS client certificate support

2017-03-30 Thread Jan Klemkow
Hi Jack, I'm not a developer (just a contributor), but I worked on httpd client certs a year ago, too. (https://marc.info/?t=14528592613=1=2) I got a private response from a developer, who had an own similar diff in preparation. He told me that is better to name configuration option

fix: cy(4) debug format strings

2017-02-01 Thread Jan Klemkow
Hi, the kernel does not compile with option CY_DEBUG because of several format string mistakes. This diff fixes them. It compiles on i386 and amd64 without any errors. bye, Jan Index: cy.c === RCS file:

Re: snmpd improvements

2016-12-21 Thread Jan Klemkow
On Wed, Dec 21, 2016 at 10:40:48AM +0100, Franco Fichtner wrote: > Hi, > > Switching from net-snmp to OpenBSD's snmpd raised two > issues and I'd like to know if they make sense to address: > > A pid file is missing. Would a patch for this be accepted? As far as I know, the OpenBSD project

Diff: Fix wrong bzero call in snmpd

2016-09-02 Thread Jan Klemkow
Hi, When a new IP address shows up on an interface, the function if_newaddr() save this IP address and its mask and boardcast address into a data structure. If the corresponding IP mask or broad cast address is not set, their data fields in this structure are bzero()-ed. But, the code wipes the

Re: Fix NULL dereference in snmpd/snmpctl

2016-05-22 Thread Jan Klemkow
wrote: > On Mon, May 09, 2016 at 09:37:08PM +0200, Jan Klemkow wrote: > > Hello, > > > > The function ber_free_elements() sets the variable ber to NULL in most > > error cases and calls ber_free_elements(ber). This causes a NULL > > dereference in ber_free_eleme

Re: diff: httpd: add client side certificate checks + test

2016-05-17 Thread Jan Klemkow
ping. Tested with current source status. On Tue, May 10, 2016 at 06:59:36PM +0200, Jan Klemkow wrote: > Hi, > > This diff adds client side certificate checks to httpd. Most parts are > straight forward. But, to transfer the whole certificate authority > store to the server

diff: httpd: add client side certificate checks + test

2016-05-10 Thread Jan Klemkow
Hi, This diff adds client side certificate checks to httpd. Most parts are straight forward. But, to transfer the whole certificate authority store to the server process through the imsg infrastructure I had to change this in an chunked transfer. The Documentation of this feature is included

Fix NULL dereference in snmpd/snmpctl

2016-05-09 Thread Jan Klemkow
Hello, The function ber_free_elements() sets the variable ber to NULL in most error cases and calls ber_free_elements(ber). This causes a NULL dereference in ber_free_elements. This patch fix that problem. bye, Jan Index: ber.c

diff: httpd: add client side certificate checks

2016-01-15 Thread Jan Klemkow
Hi, this diff adds client side certificate checks to httpd. Most parts are straight forward. But, to transfer the whole certificate authority store to the server process through the imsg infrastructure I had to change this in an chunked transfer. Documentation of this feature in httpd.conf.5

tls_init.3 add small info

2015-11-05 Thread Jan Klemkow
Hi, I'm playing around with client-side certificates[1] and saw that the manpage of tls_init.3 recommend to uses the functions: tls_config_set_ca_{file,path,mem} only in client context. But to check client-side certificates its also useful in server context. bye, Jan [1]:

libtls: add tls_accept_fds()

2015-03-29 Thread Jan Klemkow
Hi, this diff adds tls_accept_fds(3) to libtls. It allows to accept server side tls connections based on separate file descriptors for read and write, like tls_connect_fds(3) for client side connections. I tried to keep this diff similar to tls_connect_fds. If anything is wrong just tell me.

Re: new: libowfat

2014-11-05 Thread Jan Klemkow
On Sun, Nov 02, 2014 at 09:40:20AM +, Stuart Henderson wrote: On 2014/11/01 21:22, Jan Klemkow wrote: Hi, this is a new port of Fefe's reimplementation of libdjb. This library is a reimplementation of libdjb. It contains several wrappers for socket functions, mkfifo, opendir

Re: ressl: two way fds extention

2014-11-01 Thread Jan Klemkow
On Fri, Oct 31, 2014 at 09:18:26PM -0700, Doug Hogan wrote: On Sat, Nov 01, 2014 at 03:07:24AM +0100, Jan Klemkow wrote: Index: tls_client.c === RCS file: /cvs/src/lib/libtls/tls_client.c,v retrieving revision 1.1 diff -u

make: debug output to stderr

2014-10-31 Thread Jan Klemkow
Hi, this diff turns debug output of make to stderr. This is the first step to unbreak a make -d A run under ports. I tested this diff with a full kernel and userland build under amd64 architecture. Bye, Jan Index: arch.c === RCS

Re: ressl: two way fds extention

2014-10-31 Thread Jan Klemkow
Hi Joel, On Sat, Nov 01, 2014 at 03:28:04AM +1100, Joel Sing wrote: How about this API - instead of having a (now) tls_set_fds() function and then calling tls_connect_socket(), you call tls_connect_fds() directly if you need that functionality? Yes, your approach fits perfectly my needs and

ftp: use constant instead of value

2014-10-30 Thread Jan Klemkow
Hi, This diff just swaps -2 with the actual constant to increase readability of the ftp source code. bye, Jan Index: fetch.c === RCS file: /cvs/src/usr.bin/ftp/fetch.c,v retrieving revision 1.132 diff -u -p -r1.132 fetch.c ---

ressl: two way fds extention

2014-10-29 Thread Jan Klemkow
Hello, This diff enables libressl to use two file descriptors for read and write. This is feature is necessary for communication over two pipes like in the UCSPI protocol [1]. resslc[3] is a general ssl-client. +---+ ++ ++ | tcpserver | -- | resslc | -- | client

Re: rm reference to obsolete functions

2014-01-30 Thread Jan Klemkow
On Thu, Jan 30, 2014 at 09:21:52AM +0001, Jason McIntyre wrote: On Wed, Jan 29, 2014 at 08:44:05PM +0100, Jan Klemkow wrote: Hi, I've made a little diff to clean up some manpages with references to the obsoleted functions usleep(1), alarm(3). bye, Jan stuff like alarm

rm reference to obsolete functions

2014-01-29 Thread Jan Klemkow
Hi, I've made a little diff to clean up some manpages with references to the obsoleted functions usleep(1), alarm(3). bye, Jan Index: bin/sleep/sleep.1 === RCS file: /cvs/src/bin/sleep/sleep.1,v retrieving revision 1.19 diff -u -p

Fix: Seg. fault in make(1) by wrong fmt string arguments

2014-01-29 Thread Jan Klemkow
Hi, I found two segmentation faults in make(1). Here is a diff that should fix these bugs. bye, Jan Index: var.c === RCS file: /cvs/src/usr.bin/make/var.c,v retrieving revision 1.96 diff -u -p -r1.96 var.c --- var.c 6 Jan

Re: linebuffering diff for tr(1)

2013-11-20 Thread Jan Klemkow
On Tue, Nov 19, 2013 at 09:34:22PM +, Stuart Henderson wrote: On 2013/11/19 14:10, Theo de Raadt wrote: In general, new non-standard options are bad. I know and this is my own opinion to, in general. Basically, if we add this someone will use it in a script. Then it will become

linebuffering diff for tr(1)

2013-11-19 Thread Jan Klemkow
Hi, here is a diff that adds optional linebuffering to tr(1) with command line switch -u like in sed(1). I need this to remove '\r' characters from a continues input steam which lines have to be there immediately. Please write me if something is wrong with this diff or the change itself. I

Diff: for hashing of carp password

2013-07-02 Thread Jan Klemkow
Hi, This diff implements the hashing of the carp password before using it inside of the Kernel. It fix the problem that passwords like 12345678901234567890 and 12345678901234567890XXX are equal for carp. But It breaks the compatibility with older Versions. Maybe you need to increase the

Re: Diff: for hashing of carp password

2013-07-02 Thread Jan Klemkow
+0200, Alexander Bluhm wrote: On Tue, Jul 02, 2013 at 12:27:54PM +0200, Jan Klemkow wrote: Hi, This diff implements the hashing of the carp password before using it inside of the Kernel. It fix the problem that passwords like 12345678901234567890 and 12345678901234567890XXX are equal

correct includes in man(9) pages

2013-06-04 Thread Jan Klemkow
Hi, This diff converts all obsolete '.Fd' tags into '.In' tags of manpages of category nine. I hope this diff is ok and that there are no 3rd party dependencies in kernel ;-) If something is wrong with it, just wrote me and I will fix it. I need this change for a private manpage scripting

Re: ftp mput recursiv upload diff for testing

2012-07-30 Thread Jan Klemkow
Hopefully the final version. Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 30 Jul 2012 07:58:16 -

Re: ftp mput recursiv upload diff for testing

2012-07-28 Thread Jan Klemkow
I fixed a few things from the mails bevor... Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 28 Jul 2012

Re: ftp mput recursiv upload diff for testing

2012-07-23 Thread Jan Klemkow
Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 23 Jul 2012 18:49:30 - @@ -231,15 +231,32 @@ mput(int

Re: ftp mput recursiv upload diff for testing

2012-07-12 Thread Jan Klemkow
I fixed the most things. It took me a while to figure out what that code does, so I think the comments are usefull for everybody who tries to read it. The file type information comes from this special remglob2() function. There is no equivalent thing in the context of mput(). So I check the

Re: ftp mput recursiv upload diff for testing

2012-07-09 Thread Jan Klemkow
Hello, this is the same diff, but the mapage part it adaptet, for the current version of ftp.1 in cvs. bye, Jan On Thu, Jan 26, 2012 at 09:44:45PM +0100, Jan Klemkow wrote: On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan Klemkow wrote: Hello, this is my diff for recursive upload for ftp(1

Re: ftp mput recursiv upload diff for testing

2012-07-09 Thread Jan Klemkow
On Mon, Jul 09, 2012 at 02:00:11PM +0200, Jan Klemkow wrote: Hello, this is the same diff, but the mapage part it adaptet, for the current version of ftp.1 in cvs. bye, Jan On Thu, Jan 26, 2012 at 09:44:45PM +0100, Jan Klemkow wrote: On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Jan Klemkow
The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. The rest should be fine now. Thank you. On Thu, Mar 08, 2012 at 02:15:28AM +, Federico Schwindt wrote: On Wed, Mar 7, 2012 at 7:42 AM, Jan Klemkow j.klem...@wemelug.de wrote: Hi

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Jan Klemkow
sounds reasonable. On Mon, Mar 12, 2012 at 02:18:42PM +0100, Mark Kettenis wrote: Date: Mon, 12 Mar 2012 13:45:58 +0100 From: Jan Klemkow j.klem...@wemelug.de The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. We tend

Re: NEW: libc getdelim(3) and getline(3)

2012-02-28 Thread Jan Klemkow
lib/libc/stdio/getdelim.c --- /dev/null 1 Jan 1970 00:00:00 - +++ lib/libc/stdio/getdelim.c 19 Feb 2012 11:25:32 - @@ -0,0 +1,104 @@ +/* $OpenBSD$ */ + +/* + * Copyright (c) 2012 Jan Klemkow j.klem...@wemelug.de + * + * Permission to use, copy, modify, and distribute this software

Re: Unbound in base

2012-02-17 Thread Jan Klemkow
bind in ports if we do the replacement. So that the admins out there could easily use OpenBSD as a DNS-Server with such extra features. -- Jan Klemkow

Re: Unbound in base

2012-02-17 Thread Jan Klemkow
opinion the replacement of bind with unbound and nsd is more important than the support for this kind of setups :-) On Fri, Feb 17, 2012 at 12:01:46PM +0100, Henning Brauer wrote: * Jan Klemkow j.klem...@wemelug.de [2012-02-17 10:45]: There is an other problem with replacing bind with unbound

Re: NEW: libc getdelim(3) and getline(3)

2012-02-03 Thread Jan Klemkow
:47:43 - @@ -0,0 +1,104 @@ +/* $OpenBSD$ */ + +/* + * Copyright (c) 2012 Jan Klemkow j.klem...@wemelug.de + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice

Re: PATCH: failed spl lock release in pmap

2012-02-03 Thread Jan Klemkow
What is about this patch? thanks, Jan On Fri, Dec 02, 2011 at 06:31:47PM +0100, Jan Klemkow wrote: Hello, I've found an other spl lock lease failure. It's in an architecture which i couldn't test. But, I think the diff should work. bye, Jan Index: pmap.c

Re: ftp mput recursiv upload diff for testing

2012-01-26 Thread Jan Klemkow
On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan Klemkow wrote: Hello, this is my diff for recursive upload for ftp(1). It modifies the mput command for doing this. Please test it and tell me everything that is wrong with it. bye, Jan I test this patch on OpenBSD 5.0 sparc64. Man diff

NEW: libc getdelim(3) and getline(3)

2012-01-26 Thread Jan Klemkow
25 Jan 2012 20:16:30 - @@ -0,0 +1,108 @@ +/* $OpenBSD$ */ + +/* + * Copyright (c) 2012 Jan Klemkow j.klem...@wemelug.de + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice

FIX: filedescriptor leak in vi

2012-01-20 Thread Jan Klemkow
Hello, this diff fixes a filedescriptor leak in vi. I compiled the code but I could not test the code path. bye, Jan Index: recover.c === RCS file: /mount/cvsdev/cvs/openbsd/src/usr.bin/vi/common/recover.c,v retrieving revision

FIX: filedescriptor leak in authpf.c

2012-01-18 Thread Jan Klemkow
Hello, this diff fix a filedescriptor leak in authpf.c. The function allowed_luser() is call one time directly from main() but I think it should be consistent. I just compiled the sources but could not test the code path. bye, Jan Index: authpf.c

memory leak in OpenSSH

2012-01-17 Thread Jan Klemkow
Hello, this diff fixes a memory leak in OpenSSH. I have compiled it, but could not test the code path. This function is always called with an already initialized buffer. bye, Jan Index: authfile.c === RCS file:

memory leak in OpenSSH

2012-01-16 Thread Jan Klemkow
Hello, this is a diff which patch a memory leak in OpenSSH. I have just compiled it without warnings. I am unable to run this exactly this code path. bye, Jan Index: ssh-pkcs11-client.c === RCS file:

ftp mput recursiv upload diff for testing

2012-01-12 Thread Jan Klemkow
Hello, this is my diff for recursive upload for ftp(1). It modifies the mput command for doing this. Please test it and tell me everything that is wrong with it. bye, Jan Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v

PATCH: failed spl lock release in fxp

2011-12-02 Thread Jan Klemkow
Hello, i have found an other failed error handling with interrupt locking. Here is a diff which should patch this. bye, Jan Index: fxp.c === RCS file: /mount/cvsdev/cvs/openbsd/src/sys/dev/ic/fxp.c,v retrieving revision 1.108 diff

Re: PATCH: failed spl lock release in fxp

2011-12-02 Thread Jan Klemkow
Oh, sorry. Hope this fix is better. Quoting Marco Pfatschbacher m...@mailq.de: On Fri, Dec 02, 2011 at 12:02:19PM +0100, Jan Klemkow wrote: Hello, i have found an other failed error handling with interrupt locking. Here is a diff which should patch this. i don't think this compiles. your

PATCH: failed spl lock release in pmap

2011-12-02 Thread Jan Klemkow
Hello, I've found an other spl lock lease failure. It's in an architecture which i couldn't test. But, I think the diff should work. bye, Jan Index: pmap.c === RCS file:

PATCH: failed spl lock release in if_wi_usb

2011-12-02 Thread Jan Klemkow
Hello, I've found an other failed spl release lock. The diff should fix it. I compiled it and run the new kernel without an error. I'm unable to do more tests on this. bye, Jan Index: if_wi_usb.c === RCS file:

PATCH: failed spl lock release in trm

2011-12-02 Thread Jan Klemkow
Hello, This is the last spl lock leak which i've found with static code analysis. This is not in GENERIC. For testing I compiled it into my kernel and run the kernel without any error. bye, Jan Index: trm.c === RCS file:

PATCH: failed spl lock release in pgt

2011-12-01 Thread Jan Klemkow
Hello, i have found some incorrect error handling in the pgt driver. Here is a diff which should patch this. bye, Jan Klemkow Index: pgt.c === RCS file: /mount/cvsdev/cvs/openbsd/src/sys/dev/ic/pgt.c,v retrieving revision 1.67