Date: Sun, 03 Apr 2011 18:38:51 -0600
From: Theo de Raadt dera...@cvs.openbsd.org
based on a conversation at the bar.
POOL_DEBUG is expensive. But we really want it because it finds bugs
before they hurt us. The solution to this is to make it simpler to
turn off.
This diff starts the
) 2011
Stefan Sperling s...@openbsd.org wrote:
Change number 2 is the only one that hasn't been committed yet.
According to
http://pubs.opengroup.org/onlinepubs/009695399/functions/wcwidth.html
wcwidth() should return -1 for non-printable characters.
So this change looks good to me. Anyone want to
Hi,
1) Swapping to svnds has issues (pagedaemon deadlocks) and has been
broken since forever.
2) Swapping to vnds makes no sense, why add another layer when you
can just swap to a regular file instead ?
so stop supporting swapping to vnds. If this turns out to be kosher
I have a diff
On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote:
Hi,
1) Swapping to svnds has issues (pagedaemon deadlocks) and has been
broken since forever.
2) Swapping to vnds makes no sense, why add another layer when you
can just swap to a regular file instead ?
so stop
On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote:
Hi,
1) Swapping to svnds has issues (pagedaemon deadlocks) and has been
broken since forever.
2) Swapping to vnds makes no sense, why add another layer when you
can just swap to a regular file instead ?
so stop
Date: Mon, 4 Apr 2011 09:22:41 +
From: Thordur Bjornsson t...@openbsd.org
Hi,
1) Swapping to svnds has issues (pagedaemon deadlocks) and has been
broken since forever.
2) Swapping to vnds makes no sense, why add another layer when you
can just swap to a regular file instead ?
comments inline...
On 04/04/2011, at 9:01 AM, Kenneth R Westerback wrote:
Works on my crypto volume. People with other volume types would be nice
to hear from.
Ken
Index: softraid.c
===
RCS file:
On Mon, Apr 04, 2011 at 12:34:17PM +0200, Otto Moerbeek wrote:
On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote:
Hi,
1) Swapping to svnds has issues (pagedaemon deadlocks) and has been
broken since forever.
2) Swapping to vnds makes no sense, why add another layer
On 04/04/2011, at 8:43 PM, Thordur Bjornsson wrote:
On Mon, Apr 04, 2011 at 12:34:17PM +0200, Otto Moerbeek wrote:
On Mon, Apr 04, 2011 at 09:22:41AM +, Thordur Bjornsson wrote:
Hi,
1) Swapping to svnds has issues (pagedaemon deadlocks) and has been
broken since forever.
2) Swapping
On Mon, Apr 4, 2011 at 3:29 AM, Thordur Bjornsson t...@openbsd.org wrote:
this one is unused.
OK ?
I love the smell of burning bits in the morning. ok guenther
On Sun, Apr 03, 2011 at 06:38:51PM -0600, Theo de Raadt wrote:
based on a conversation at the bar.
POOL_DEBUG is expensive. But we really want it because it finds bugs
before they hurt us. The solution to this is to make it simpler to
turn off.
This diff starts the kernel with pool debug
o Collapse a few _KERNEL's and move some definitions to
allow this.
o Expose a few NFSMOUNT stuffs (one I will remove, the other
I'm going to use later anyways).
o Kill a protection for a forward decleration
o Kill __STDC__ protection (which is under _KERNEL).
OK ?
Index: sys/mount.h
Hi,
Test the iterated range, instead of the range chosen to not meet the
assert. This has been broken for a long time, but apparently no-one hit
it so far.
While here, change the KASSERT to a KDASSERT, as it is a validation of
internal state of pmemrange.
Ok?
--
Ariane
Index: uvm_pmemrange.c
On Mon, Apr 04, 2011 at 03:00:43PM +0200, Ariane van der Steldt wrote:
Please test this diff to uvm_map on as many architectures as possible.
Contains a number of fixes and a better algorithm.
It makes sure random address space allocations happen (and enables it in
the kernel) without causing
On Mon, Apr 4, 2011 at 7:51 AM, Thordur Bjornsson t...@openbsd.org wrote:
tiny tedu moment of mine, disable COMPAT_43 and keep
it so for a few releases and if noone complains, nuke it.
OK/Thoughts ?
I think this is ok. I looked at a few of the uses, and we seem to be
using the linux compat
Velika fitnes akcija!
Ne propustite, poslednje koliD
ine fitnesa opreme PO NAJNIE=IM CENAMA do
sada!
Ova posebna ponuda traje do 15. maja 2011!
Ne gubite vreme, koliD
ine su ograniD
ene!
Kliknite i poruD
ite;
Najbolja forma uz najbolje ponude
Najbolji fitnes po najniEim cenama - poslednje
On Sun, Apr 03, 2011 at 07:01:04PM -0400, Kenneth R Westerback wrote:
Works on my crypto volume. People with other volume types would be nice
to hear from.
Ken
v2. Use scsi_io_[get|put](), stop trying so hard to avoid calling scsi_done()
at SPLBIO as this is nice but not necessary,
this reads fine by me, except for one thing. i worry that it looks like wu's
get lists of ccbs attached to them that are released when the wu is released.
before iopools there was a wu per call to softraids scsi_cmd handler, but now
the same wu can be given to scsi_cmd multiple times. sr_scsi_done
Routers need to ingore ICMP redirects in anycase so it would make sense to
disable ICMP redirects as soon as ipforwarding is set to 1.
The IPv6 counterpart already does this.
OK?
--
:wq Claudio
Index: netinet/ip_icmp.c
===
RCS
On Saturday, April 2, Amit Kulkarni wrote:
FreeBSD which is the origin of FFS does a
background fsck, and if Kirk McCusick feels so strongly I will do it
too.
FreeBSD was not the origin of the FFS code. Background fsck in freebsd
is mainly meant to reduce the amount of time it takes to get
pcc currently only chokes on some inline functions that need external
linkage. gcc isn't pesky about that, but pcc and clang are (rightfully,
imo). Anyway, the functions in question are:
net/pf.c: pf_addr_compare (was probably ok before r1.729)
arch/{amd64,i386}/isa/clock.c: mc146818_read
On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker cje...@diehard.n-r-g.com
wrote:
+ if (icmp_rediraccept == 0 || ipforwarding == 1)
Would ipforwarding != 0 be more appropriate here? According to
sysctl(3), ipforwarding == 2 is a legitimate configuration setting.
On Sun, Apr 03, 2011 at 11:21:35PM +0100, Nicholas Marriott wrote:
- if (x + len - 1 = win-_maxx) {
+ if (len = 0 x + len - 1 = win-_maxx) {
Not sure this is required, astr is a cchar_t * which will come from
setcchar.
Right. That already makes sure the string cannot contain
On Sun, Apr 03, 2011 at 11:41:47PM +0100, Nicholas Marriott wrote:
Again so it is a cchar_t so I'm not sure it is valid for it to be
nonprintable but this doesn't do any harm.
Might want to run this stuff past upstream first though? It is better if
we stay in sync if they do want to take it.
On Mon, Apr 04, 2011 at 10:10:49AM -0700, Matthew Dempsky wrote:
On Mon, Apr 4, 2011 at 9:11 AM, Claudio Jeker cje...@diehard.n-r-g.com
wrote:
+ if (icmp_rediraccept == 0 || ipforwarding == 1)
Would ipforwarding != 0 be more appropriate here? According to
sysctl(3),
This is ok nicm
I wouldn't be surprised if WIDECHAR build of libedit has other issues,
getting it going is still on my list of things to do :-).
On Mon, Apr 04, 2011 at 08:30:42PM +0200, Stefan Sperling wrote:
On Sun, Apr 03, 2011 at 11:26:52PM +0100, Nicholas Marriott wrote:
Hi
We
Would it be better maybe to do the check in the Width() macro itself?
Yes indeed. New diff below.
-#define Width(c) wcwidth(c)
+#define Width(c) (wcwidth(c) == -1 ? 0 : wcwidth(c))
But this calls wcwidth() to be invoked twice, which is ugly. As a
minimum, make this an inline
On Mon, Apr 04, 2011 at 08:06:57PM +0200, Pascal Stumpf wrote:
pcc currently only chokes on some inline functions that need external
linkage. gcc isn't pesky about that, but pcc and clang are (rightfully,
imo). Anyway, the functions in question are:
net/pf.c: pf_addr_compare (was
On Mon, Apr 04, 2011 at 06:44:10PM +, Miod Vallat wrote:
Would it be better maybe to do the check in the Width() macro itself?
Yes indeed. New diff below.
-#define Width(c) wcwidth(c)
+#define Width(c) (wcwidth(c) == -1 ? 0 : wcwidth(c))
But this calls wcwidth() to be
On Mon, Apr 04, 2011 at 08:06:57PM +0200, Pascal Stumpf wrote:
net/pf.c: pf_addr_compare (was probably ok before r1.729)
The current implementation has been discussed. See also:
http://www.greenend.org.uk/rjk/2003/03/inline.html
The function should be inline within pf.c and callable from
On Mon, Apr 4, 2011 at 11:06 AM, Pascal Stumpf pascal.stu...@cubes.de wrote:
pcc currently only chokes on some inline functions that need external
linkage. gcc isn't pesky about that, but pcc and clang are (rightfully,
imo).
It's completely legal and defined (by the standard and not just gcc!)
I haven't heard any objections to my initial AI_FQDN diff, so here's
the diff again with updated man page bits. See the original thread
for a proof-of-concept diff from djm@ to use this in OpenSSH.
The man page mostly only uses hostname when referring to the formal
argument, so I changed the
This of course needs a libc minor bump too.
On Mon, Apr 04, 2011 at 11:10:54AM -0700, Matthew Dempsky wrote:
I haven't heard any objections to my initial AI_FQDN diff, so here's
the diff again with updated man page bits. See the original thread
for a proof-of-concept diff from djm@ to use
On Mon, Apr 4, 2011 at 11:24 AM, Claudio Jeker cje...@diehard.n-r-g.com wrote:
Yes, ipforwarding == 2 is legitimate but IMO it is not a full router when
forwarding is only done when an IPsec flow is used. I have the feeling
that IPsec may need some redirects. This is why I choosed the == 1
Hi
This is fine with me.
On Mon, Apr 04, 2011 at 09:04:26PM +0200, Stefan Sperling wrote:
On Mon, Apr 04, 2011 at 06:44:10PM +, Miod Vallat wrote:
Would it be better maybe to do the check in the Width() macro itself?
Yes indeed. New diff below.
-#define Width(c) wcwidth(c)
Cleanup of some horrible macros pulled into the network code
from the horrible radix code.
Now boots and runs! And sends email!
Hi, otto@!
Index: net/radix.c
===
RCS file: /cvs/src/sys/net/radix.c,v
retrieving revision 1.28
diff -u
On Mon, Apr 04, 2011 at 10:47:37AM -0400, Kenneth R Westerback wrote:
On Sun, Apr 03, 2011 at 07:01:04PM -0400, Kenneth R Westerback wrote:
Works on my crypto volume. People with other volume types would be nice
to hear from.
Ken
v2. Use scsi_io_[get|put](), stop trying so hard
The implementation of SO_PEERCRED is leaking mbufs.
netstat -m
5292 mbufs in use:
46 mbufs allocated to data
4 mbufs allocated to packet headers
43 mbufs allocated to socket names and addresses
5199 mbufs allocated to socket options
and quite a few over some time
On Fri, Mar 25, 2011 at 10:40:38PM +0100, Martin Pelikan wrote:
Hi list,
if anyone tries to develop an application using tun(4), the manpage
misses some includes neccesary for IFT_* and IFF_* constants.
If you switch the order of sys/types.h and sys/socket.h, your program
won't compile (is
On Mon, 4 Apr 2011, Alexander Bluhm wrote:
On Mon, Apr 04, 2011 at 08:06:57PM +0200, Pascal Stumpf wrote:
net/pf.c: pf_addr_compare (was probably ok before r1.729)
The current implementation has been discussed. See also:
http://www.greenend.org.uk/rjk/2003/03/inline.html
The function
First proper use of the new km_alloc.
- Change pool constraints to use kmem_pa_mode instead of uvm_constraint_range
- Use km_alloc for all backend allocations in pools.
- Use km_alloc for the emergmency kentry allocations in uvm_mapent_alloc
- Garbage collect uvm_km_getpage,
For isprint() to work correctly in a UTF-8 locale applications must
set up the LC_CTYPE locale before using isprint().
As done for hexdump and tcpdump already.
This diff covers all offenders in usr.bin.
Index: bc/bc.y
===
RCS file:
From an old thread on misc@, circa Jun 17, 2008:
Re: usb gamepads
So I ended up bying a Logitech Dual Action for $15 at a local store.
This is what shows up in dmesg:
uhidev2 at uhub1 port 2 configuration 1 interface 0 Logitech Logitech Dual
Action rev 1.10/3.00 addr 2
uhidev2:
On Mon, Apr 04, 2011 at 03:54:32PM -0600, Artur Grabowski wrote:
First proper use of the new km_alloc.
- Change pool constraints to use kmem_pa_mode instead of uvm_constraint_range
- Use km_alloc for all backend allocations in pools.
- Use km_alloc for the emergmency kentry allocations in
From an old thread on misc@, circa Jun 17, 2008:
Re: usb gamepads
So I ended up bying a Logitech Dual Action for $15 at a local store.
This is what shows up in dmesg:
uhidev2 at uhub1 port 2 configuration 1 interface 0 Logitech Logitech Dual
Action rev 1.10/3.00 addr 2
uhidev2:
46 matches
Mail list logo
