Re: unsigned = 0 comparisons

2012-07-10 Thread David Coppa
On Mon, Jun 25, 2012 at 10:53 PM, Arto Jonsson ajons...@kapsi.fi wrote: On Mon, Jun 25, 2012 at 01:47:18PM -0600, Theo de Raadt wrote: Like, who cares about about commit id's. Projects are just people working together. A project didn't come up with that diff. A person did. When we say

relayd: statistics are broken [patches]

2012-07-10 Thread Erik Lax
Hi, There is a bug in relayd's handling of statistics collected from each prefork (0,1,2,3,4,..). Once received over IMSG, statistics should be saved in a rl_stats[RELAY_MAXPROC + 1] array per relay (rlay-rl_stats). However all ends up in rlay-rl_stats[0] overwriting other children's statistics

wakeup should only call need_resched if priority is lower than current one.

2012-07-10 Thread Christiano F. Haesbaert
Heya, wakeup_n() has a inline expansion of setrunnable(), but it differs by always calling need_resched(), this sends an ipi for *every* wakeup channel. It might have something to do with aja's problem. Index: kern_synch.c === RCS

Re: ral(4) tx/prio queue fixes (was: rt2560 tx/prio queue fixes)

2012-07-10 Thread Stefan Sperling
On Sun, Jul 08, 2012 at 10:11:44AM +0200, Stefan Sperling wrote: The rt2560 part of the ral driver uses a prio queue for management frames and a tx queue for data frames. Both queues currently use a shared flag to tell the network stack that they are full (IFF_OACTIVE). It seems that

Re: wakeup should only call need_resched if priority is lower than current one.

2012-07-10 Thread Christiano F. Haesbaert
Commited, it fixes aja's problem indeed. Now, I don't like this at all, we'll have more bugs of this nature, can't we turn setrunnable() into an inline function and place it in a header ? Or just call setrunnable() directly, but I'd have to run some tests to see the performance impact. On Tue,

tcpdump -A

2012-07-10 Thread Stuart Henderson
adds support for -A for tcpdump, to print captured text without the hex dump. can be useful if you're watching text-based protocols like HTTP or SIP. tcpdump.org uses the same flag (this isn't their code though). comments? OK? Index: tcpdump.8

Re: tcpdump -A

2012-07-10 Thread Mike Small
Stuart Henderson s...@spacehopper.org writes: +/* dump the text from the buffer */ +void +default_print_ascii(const u_char *cp, unsigned int length, unsigned int offset) +{ + int c, i; + + printf(\n); + for (i = 0; i length; i++) { + c = cp[i]; + c

Re: tcpdump -A

2012-07-10 Thread Stuart Henderson
On 2012/07/10 14:15, Mike Small wrote: Stuart Henderson s...@spacehopper.org writes: +/* dump the text from the buffer */ +void +default_print_ascii(const u_char *cp, unsigned int length, unsigned int offset) +{ + int c, i; + + printf(\n); + for (i = 0; i length; i++)

rum and host ap mode

2012-07-10 Thread vesbula
Hello, I'm resending this to tech list also. I have rum driver in host AP mode. Below patch makes it faster from 100 kB/s to 700 kB/s. +++ part is copied from other place in the file. There could be better choice even. Index: sys/dev/usb/if_rum.c

fix for ClickPad

2012-07-10 Thread Alexandr Shadchin
Now in clickpad mode the pointer moves to [1,1] (upper left corner) even on a single tap. These patches fixes it. On issue pointed gilles@ and matthieu@ * cd /sys * patch 01_kernel.diff * build and install new kernel * cd /usr/src * (if need - make obj) * make includes * cd

tedu sched_peg_curproc()

2012-07-10 Thread Christiano F. Haesbaert
This isn't used, the idle thread just sets the PEG flag and goes on. Index: kern/kern_sched.c === RCS file: /cvs/src/sys/kern/kern_sched.c,v retrieving revision 1.27 diff -d -u -p -r1.27 kern_sched.c --- kern/kern_sched.c 10 Jul

Typo st_mtim in stat manpage.

2012-07-10 Thread Han Boetes
I found this mistake in the stat manpage: Index: sys/stat.2 === RCS file: /cvs/src/lib/libc/sys/stat.2,v retrieving revision 1.31 diff -u -p -r1.31 stat.2 --- sys/stat.2 17 Nov 2011 14:26:14 - 1.31 +++ sys/stat.2 10 Jul

Re: fix for ClickPad

2012-07-10 Thread Gilles Chehade
For what it's worth, this fixes the issue on my laptop. I still can't highlight a portion of a line, but at least I can copy / paste a word now \o/ Thanks a *LOT* as it was plenty annoying Gilles On Wed, Jul 11, 2012 at 12:53:00AM +0600, Alexandr Shadchin wrote: Now in clickpad mode the

Re: tedu sched_peg_curproc()

2012-07-10 Thread Mark Kettenis
Date: Tue, 10 Jul 2012 21:44:06 +0200 From: Christiano F. Haesbaert haesba...@openbsd.org This isn't used, the idle thread just sets the PEG flag and goes on. Please don't; I have some stuff that *will* use this. Index: kern/kern_sched.c

Re: Typo st_mtim in stat manpage.

2012-07-10 Thread Matthew Dempsky
On Tue, Jul 10, 2012 at 11:49 AM, Han Boetes h...@boetes.org wrote: I found this mistake in the stat manpage: Not a mistake; see /usr/include/sys/stat.h.

Re: tedu sched_peg_curproc()

2012-07-10 Thread Christiano F. Haesbaert
On 10 July 2012 22:32, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Tue, 10 Jul 2012 21:44:06 +0200 From: Christiano F. Haesbaert haesba...@openbsd.org This isn't used, the idle thread just sets the PEG flag and goes on. Please don't; I have some stuff that *will* use this. Okayz :)

Re: Typo st_mtim in stat manpage.

2012-07-10 Thread Philip Guenther
On Tue, Jul 10, 2012 at 1:51 PM, Matthew Dempsky matt...@dempsky.org wrote: On Tue, Jul 10, 2012 at 11:49 AM, Han Boetes h...@boetes.org wrote: I found this mistake in the stat manpage: Not a mistake; see /usr/include/sys/stat.h. ...or just keep reading further on the manpage and think about