On Fri, Sep 12, 2014 at 02:23:34PM -0600, Todd C. Miller wrote:
> No objection here. I'd go a step farther and nuke all the FOO_END
> macros as well. They add nothing and just make code harder to read.
In preparation for that, this replaces all _END macro calls.
Since we're not calling CIRCLEQ_*
I was actually thinking the same thing Philip, nuking this was long overdue.
-- gregoire
On Sat, Sep 13, 2014 at 04:13, Joel Sing wrote:
>
> I'm not convinced that we should be doing this with the *_mem() functions,
> as
> there is a benefit to the client owning this memory. Currently, in httpd the
> public/private key is removed as soon as ressl_configure() is called.
> Obviously lib
On Fri, 12 Sep 2014 13:50:51 -0700, Philip Guenther wrote:
> On Fri, 12 Sep 2014, Todd C. Miller wrote:
> > No objection here. I'd go a step farther and nuke all the FOO_END
> > macros as well. They add nothing and just make code harder to read.
>
> Better?
Looks good. OK millert@
- todd
On Fri, 12 Sep 2014, Todd C. Miller wrote:
> No objection here. I'd go a step farther and nuke all the FOO_END
> macros as well. They add nothing and just make code harder to read.
Better?
Index: queue.3
===
RCS file: /cvs/src/shar
No objection here. I'd go a step farther and nuke all the FOO_END
macros as well. They add nothing and just make code harder to read.
- todd
On Mon, 8 Sep 2014, Jona Joachim wrote:
> On 2014-09-06, Gr?goire Duch?ne wrote:
> > Hi,
> >
> > Although CIRCLEQ_* macros are deprecated, queue(3) does not say so.
>
> perhaps it would be interesting to mention why circle queues got
> deprecated.
Let's go a step further and remove them from the
On Fri, 12 Sep 2014, Ted Unangst wrote:
> On Wed, Sep 10, 2014 at 16:38, Ted Unangst wrote:
> > On Fri, Aug 15, 2014 at 13:06, Ted Unangst wrote:
> >> Instead, ressl should copy all parameters as necessary and
> >> free them. This does introduce an error case into formerly void
> >> functions, but
Hello,
I'm polishing the GOST implementation for LibreSSL
(https://github.com/libressl-portable/openbsd/pull/6).
Currently there are three instances of ASN methods
and pmethods structures, because there three
different OIDs related to GOST public keys
(-2001, -2012, 256 bit, -2012 512 bit).
I th
On Fri, Sep 12, 2014 at 09:39, Kent R. Spillner wrote:
> On Fri, Sep 12, 2014 at 12:38:07AM -0700, Doug Hogan wrote:
>> Hmm this doesn't look right to me. ressl_config is not allocated the
>> same way as the other variables. The other variables such as ssl,
>> sslhost, etc are local to that funct
On Thu, 11 Sep 2014 22:03:04 -0700, William Orr wrote:
> I'm resubmitting this patch since the source tree was locked last time I
> submitted. Any thoughts?
I think we've discussed this one to death already. It looks fine
to me.
- todd
On Fri, Sep 12, 2014 at 09:39:30AM -0500, Kent R. Spillner wrote:
> Of course, you're right. Is there any reason why ressl_config must be
> global? It's only used in url_get. It should be harmless to create a
> new one each time as long as we always free it.
>
> Here's a diff for that:
Forgot
On Fri, Sep 12, 2014 at 12:38:07AM -0700, Doug Hogan wrote:
> Hmm this doesn't look right to me. ressl_config is not allocated the
> same way as the other variables. The other variables such as ssl,
> sslhost, etc are local to that function and allocated there.
> ressl_config is a global and only
On Mon, Sep 8, 2014 at 12:23 PM, sven falempin wrote:
> On Mon, Sep 8, 2014 at 12:17 PM, Miod Vallat wrote:
>>> My question is more about the driver itself, it did not change a lot
>>> since 1994 , while netbsd apparently move to a complete different
>>> driver :
>>> http://cvsweb.netbsd.org/bsd
On Thu, Sep 11, 2014 at 11:05:02PM -0500, Kent R. Spillner wrote:
> While reviewing tedu@'s libressl config cleanup diffs I noticed we're
> not explicitly freeing ressl_config in ftp(1).
...
> Index: fetch.c
> ===
...
> if (ssl !
15 matches
Mail list logo
