Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: I have found a peculiar behaviour in ospfd when the physical link of the parent carp interface is down. The carp interface net is then announced with it's regular metric. An example: The cable of em2, parent of carp2

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Stuart Henderson
On 2015/05/19 09:03, Johan Ymerson wrote: On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: I have found a peculiar behaviour in ospfd when the physical link of the parent carp interface is down. The carp interface net is then announced with it's regular metric. An example: The

Re: vlan+bridge fix

2015-05-19 Thread Martin Pieuchot
On 15/05/15(Fri) 17:34, mxb wrote: Diff is applied. So far no problems. Unfortunately I can’t test this fully - no vlans on my side. Thanks for testing. A no regression report is always welcome. There's some more issues with bridge+vlan but jasper@ also confirmed this diff improve the

Re: id: add -c option

2015-05-19 Thread Marc Espie
On Mon, May 18, 2015 at 03:12:24PM -0600, Todd C. Miller wrote: This adds id -c to display a user's login class. If no user is specified, it looks up the passwd entry based on the real uid and displays the corresponding login class. This is similar to id -c in FreeBSD (but they keep the

Re: chroot: add -c to use login class with -u

2015-05-19 Thread Marc Espie
On Mon, May 18, 2015 at 04:30:33PM -0600, Todd C. Miller wrote: Currently, chroot -u doesn't use the settings in /etc/login.conf. This adds a -c option to apply the via setusercontext(). We can't use LOGIN_SETALL since the uid change has to happen after chroot(2) and the groups may be

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: On 2015/05/19 10:10, Johan Ymerson wrote: Yes I understand that, but if carp init was counted in LINK_STATE_DOWN then the metric would be 65535 which I think would still avoid the problem you're seeing, and would involve less

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Tue, 2015-05-19 at 10:10 +0100, Stuart Henderson wrote: On 2015/05/19 09:03, Johan Ymerson wrote: On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: I have found a peculiar behaviour in ospfd when the physical link of the parent carp interface is down. The carp interface net is

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Stuart Henderson
On 2015/05/19 10:10, Johan Ymerson wrote: On Tue, 2015-05-19 at 10:10 +0100, Stuart Henderson wrote: On 2015/05/19 09:03, Johan Ymerson wrote: On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: I have found a peculiar behaviour in ospfd when the physical link of the parent carp

Re: More if_output()

2015-05-19 Thread Martin Pieuchot
On 15/05/15(Fri) 15:53, Martin Pieuchot wrote: Some more if_output() conversion. The xl bits are here because I'd like to reduce the number of places where IFQ_ENQUEUE() is used. After applying this diff you should only have a couple left. Anyone? Ok? Index: dev/usb/if_upl.c

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Henning Brauer
* Johan Ymerson johan.ymer...@transmode.com [2015-05-19 19:25]: On Tue, 2015-05-19 at 11:16 +, Johan Ymerson wrote: On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: On 2015/05/19 10:10, Johan Ymerson wrote: Yes I understand that, but if carp init was counted in

[Patch] httpd - don't leak fcgi file descriptors

2015-05-19 Thread Todd Mortimer
Hi tech, The attached patch fixes a problem I’ve been having with httpd + php_fpm + owncloud on 5.7. The patch is against 5.7-release. After several days running owncloud with httpd, php_fpm started complaining about hitting pm.max_children, and top would show a bunch of idle php_fpm processes

Re: Brainy: Memory Leak in ICMP

2015-05-19 Thread Martin Pieuchot
On 19/05/15(Tue) 15:28, Maxime Villard wrote: -- netinet/ip_icmp.c -- 925 rt = rtalloc(sintosa(sin), RT_REPORT|RT_RESOLVE, rtableid); if (rt == NULL) return (NULL); /* Check if the route is actually usable */

Brainy: Memory Leak in ICMP

2015-05-19 Thread Maxime Villard
Hi, I put here a bug among others: -- netinet/ip_icmp.c -- 925 rt = rtalloc(sintosa(sin), RT_REPORT|RT_RESOLVE, rtableid); if (rt == NULL) return (NULL); /* Check if the route is actually usable */ if

pcap N listeners vs N devs

2015-05-19 Thread def
Hi! As bpf devices is a some limited resource, and as far as i know the kernal is like single-thread when performing filtering each packet thr many active bpf devices. So the question applying to ethernet trunk where one eth port spans multiple vlans, or i.e. multiple mpe.In terms of

Re: chroot: add -c to use login class with -u

2015-05-19 Thread trondd
On Mon, May 18, 2015 6:30 pm, Todd C. Miller wrote: Currently, chroot -u doesn't use the settings in /etc/login.conf. Nice. I was missing this option. Open questions: 1) Should this just be default behavior with -u? Are there cases when you would *not* want to set the priority and

[patch]rcs: xstrdup just wrappes strdup

2015-05-19 Thread Fritjof Bornebusch
Hi, xstrdup just wrappes strdup, so there is no need to call xmalloc and strlcpy instead. Regards, --F. Index: xmalloc.c === RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v retrieving revision 1.8 diff -u -p -r1.8 xmalloc.c ---

Re: chroot: add -c to use login class with -u

2015-05-19 Thread Todd C. Miller
The consensus seems to be that chroot -u should apply the settings in /etc/login.conf by default. Since this is a non-standard flag we can do what we like with it. I should have used setusercontext() when I added -u to chroot in the first place. We can add a -c class option in the future if

Re: chroot: add -c to use login class with -u

2015-05-19 Thread Todd C. Miller
On Tue, 19 May 2015 09:56:53 -0600, Theo de Raadt wrote: I think the consensus was easy to form. People using -u right now collect root's giant limits, which is not sensible. Actually, they retain the invoking user's limits. But either way, it is surprising. - todd

Re: chroot: add -c to use login class with -u

2015-05-19 Thread Theo de Raadt
The consensus seems to be that chroot -u should apply the settings in /etc/login.conf by default. Since this is a non-standard flag we can do what we like with it. I should have used setusercontext() when I added -u to chroot in the first place. We can add a -c class option in the future

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Tue, 2015-05-19 at 11:16 +, Johan Ymerson wrote: On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: On 2015/05/19 10:10, Johan Ymerson wrote: Yes I understand that, but if carp init was counted in LINK_STATE_DOWN then the metric would be 65535 which I think would still

Re: em(4) support for another Tolopai based board

2015-05-19 Thread Dariusz Swiderski
On Sat, 16 May 2015, Dariusz Swiderski wrote: Hi, Attached patch implements support for yet another Tolopai (EP80579) based soho router. As some of you might remeber I wrote the original support for this platform during h2k9. In this case, the board is named Teak 3020, and not only it