Re: strtok_r: remove useless casts

2015-06-19 Thread Mark Kettenis
From: Todd C. Miller todd.mil...@courtesan.com Date: Fri, 19 Jun 2015 09:11:21 -0600 There's no reason to cast delim to char * when we can just make spanp const char * to match it. Fewer casts is good. Not sure I agree with the s/0/'\0'/, but that's merely a matter of taste. ok kettenis@

Re: using httpd to distribute signify keys

2015-06-19 Thread Reyk Floeter
On Thu, Jun 18, 2015 at 11:46:13PM +1000, David Gwynne wrote: this adds the current signify pub key for base to the httpd Server version header. as you say, the keys are small. this could help distribute it widely. here's an example of what it looks like: dlg@mild ~$ curl -I

lorder(1) - don't rely on sort(1) and join(1) historical behavior

2015-06-19 Thread Jérémie Courrèges-Anglas
When I looked at the lorder script, I had trouble understanding the sort and join calls, since the syntax used is historical. I'm using this diff since a couple of months. Could someone double check that I got the conversion right? Index: lorder.sh

[patch] nm: minimal section header size

2015-06-19 Thread Sébastien Marie
Hi, This patch ensure that e_shentsize (sections header's size in bytes) is big enough to fill at least one Elf_Shdr. Please note, I am not completely sure to have understand this part: calloc() is called with a dynamic element size (e_shentsize: readed for file), but the variable is declared as

[patch] nm: some code cleanup

2015-06-19 Thread Sébastien Marie
Some code cleanup: - disable elf_load_phdrs() and elf_fix_phdrs() functions as there aren't in used. I also add a comment for elf_load_phdrs(): the code seems as buggy as elf_load_shdrs() against crafted input. Some other code could be dead too: I have not investigated a lot in this

[patch] nm: on error, set globals to NULL

2015-06-19 Thread Sébastien Marie
Hi, This patch ensure that when an error is detected, the freed variables in elf_symloadx() are reinitialised. Else show_file() in nm.c will used these variables, even if they has just been freed. (nm.c +689). Problem found by afl. -- Sébastien Marie Index: elf.c

[patch] cwm: Add obscured windows to hidden windows menu

2015-06-19 Thread ben
This patch adds any windows that are completely obscured by other windows to the menu of currently hidden windows. I've found this very useful. When I lose track of a window it doesn't matter to me whether I intentionally hid it or it just became obscured, I just want to bring it back easily

Re: using httpd to distribute signify keys

2015-06-19 Thread sid77
- Original Message - I'm concerned that this may be confused with a patch level, or a signature. Does a custom HTTP header create less confusion? Something similar to: HTTP/1.1 200 OK Connection: keep-alive Content-Length: 2259 Content-Type: text/html Date: Thu, 18 Jun 2015 13:45:29 GMT

video(1): uninitialized variable

2015-06-19 Thread Theo Buehler
My laptop has the built-in camera $ dmesg | grep uvideo uvideo0 at uhub0 port 4 configuration 1 interface 0 Micron Built-in iSight rev 2.00/1.84 addr 2 video0 at uvideo0 $ and video(1) usually fails to grab frames in the default resolution of 640x480. No problems so far with 320x240 and

strtok_r: remove useless casts

2015-06-19 Thread Todd C. Miller
There's no reason to cast delim to char * when we can just make spanp const char * to match it. - todd Index: lib/libc/string/strtok.c === RCS file: /cvs/src/lib/libc/string/strtok.c,v retrieving revision 1.6 diff -u -p -u -r1.6

Re: [patch] cwm: Add obscured windows to hidden windows menu

2015-06-19 Thread Okan Demirmen
On Fri 2015.06.19 at 08:49 -0500, b...@cbza.org wrote: This patch adds any windows that are completely obscured by other windows to the menu of currently hidden windows. I've found this very useful. When I lose track of a window it doesn't matter to me whether I intentionally hid it or it

Re: [patch] dig(1), host(1), nslookup(1) manpages

2015-06-19 Thread Theo de Raadt
On Thu, Jun 18, 2015 at 02:50:48PM -0500, Dutch Ingraham wrote: If an application (say, named) is removed from base, but still included in ports, it it the policy to remove references to that application from base applications' manpages? generally, yes. but in this case i'm less