Re: Unlocking ix(4) a bit further

2015-09-30 Thread Hrvoje Popovski
On 30.9.2015. 14:30, Mark Kettenis wrote: > Since people seemed to like my diff for em(4), here is one for ix(4). > In addition to unlocking the rx completion path, this one also uses > intr_barrier() and removes the rx mutex that claudio@ put in recently. > > I don't have any ix(4) hardware. So

remove useless AUCAT_COOKIE knob

2015-09-30 Thread Alexandre Ratchov
The AUCAT_COOKIE environment variable was never used. It doesn't allow the cookie to be shared between users or to have a "group" cookie (because permissions are checked by the library). On the other hand sometimes people loose time trying to use it. OK to remove it? Index: aucat.c

Re: sppp goes on a diet

2015-09-30 Thread Martin Pieuchot
On 30/09/15(Wed) 00:36, Stuart Henderson wrote: > The last diff only had +'s, so restore the balance. Since the sad > demise of art, san, and lmc, there is some crisco that can be flensed. > The diff has ^L's in so there's a risk it may get mangled with > quoted-unreadable encoding, so I've put a

Re: Simply use rtdeletemsg()

2015-09-30 Thread Martin Pieuchot
On 25/09/15(Fri) 13:07, Martin Pieuchot wrote: > This brings nd6_free() in line with arptfree() and adds a userland > notification for free. > > ok? Anyone? > > Index: netinet6/nd6.c > === > RCS file: /cvs/src/sys/netinet6/nd6.c,v

Re: Unlocking ix(4) a bit further

2015-09-30 Thread Hrvoje Popovski
On 30.9.2015. 19:20, Hrvoje Popovski wrote: > On 30.9.2015. 14:30, Mark Kettenis wrote: >> Since people seemed to like my diff for em(4), here is one for ix(4). >> In addition to unlocking the rx completion path, this one also uses >> intr_barrier() and removes the rx mutex that claudio@ put in

Re: Unlocking em(4) a bit further

2015-09-30 Thread Stuart Henderson
On 2015/09/30 12:32, Martin Pieuchot wrote: > > Could use some further testing of course. > > Tested on: > > em0 at pci1 dev 0 function 0 "Intel I210" rev 0x03: msi > em0 at pci0 dev 25 function 0 "Intel 82579LM" rev 0x04: msi > em2 at pci0 dev 20 function 0 "Intel I354 SGMII" rev 0x03: msi em1

Re: Unable to install bootblocks

2015-09-30 Thread mxb
Is you disk is thick os thin provisioned? In should be thick and eager zeroed. There are ways to move from thin to thick. Google for it. //mxb > On 29 sep. 2015, at 22:52, Pedro Caetano wrote: > > Hi, > > While installing openbsd on vmware using today's

Re: Unlocking em(4) a bit further

2015-09-30 Thread Martin Pieuchot
On 28/09/15(Mon) 23:53, Mark Kettenis wrote: > This diff makes the tx completion path run without the kernel lock > held. With this change, the interrupt handler will not grab the > kernel lock under normal circumstances. The diff follows the same > approach as dlg@ took with vmx(4). > > The

Re: Unlocking em(4) a bit further

2015-09-30 Thread Peter Hessler
On 2015 Sep 28 (Mon) at 23:53:13 +0200 (+0200), Mark Kettenis wrote: :This diff makes the tx completion path run without the kernel lock :held. With this change, the interrupt handler will not grab the :kernel lock under normal circumstances. The diff follows the same :approach as dlg@ took with

Re: Unable to install bootblocks

2015-09-30 Thread Stuart Henderson
On 2015/09/29 21:52, Pedro Caetano wrote: > Hi, > > While installing openbsd on vmware using today's snapshot 29-sep-2015, I > get the following message on the final part of the install process, leaving > the system in an unusable state (not booting normally after installing from > bsd.rd). > >

Re: Simply use rtdeletemsg()

2015-09-30 Thread Stuart Henderson
On 2015/09/30 10:37, Martin Pieuchot wrote: > On 25/09/15(Fri) 13:07, Martin Pieuchot wrote: > > This brings nd6_free() in line with arptfree() and adds a userland > > notification for free. > > > > ok? > > Anyone? There are two differences beside the userland notification - 1. rtdeletemsg()

Re: Simply use rtdeletemsg()

2015-09-30 Thread Martin Pieuchot
On 30/09/15(Wed) 11:21, Stuart Henderson wrote: > On 2015/09/30 10:37, Martin Pieuchot wrote: > > On 25/09/15(Fri) 13:07, Martin Pieuchot wrote: > > > This brings nd6_free() in line with arptfree() and adds a userland > > > notification for free. > > > > > > ok? > > > > Anyone? > > There are

Re: Simply use rtdeletemsg()

2015-09-30 Thread Mike Belopuhov
On Wed, Sep 30, 2015 at 10:37 +0200, Martin Pieuchot wrote: > On 25/09/15(Fri) 13:07, Martin Pieuchot wrote: > > This brings nd6_free() in line with arptfree() and adds a userland > > notification for free. > > > > ok? > > Anyone? > Since nobody has complained so far that arp is doing this, I

Re: rcctl action multiple daemons

2015-09-30 Thread Martijn van Duren
ping On 09/25/15 14:44, Martijn van Duren wrote: On 09/25/15 14:03, Stuart Henderson wrote: On 2015/09/25 13:17, Martijn van Duren wrote: I don't always want all daemons running all the time on my desktop, but when I want to start multiple daemons (for instance when doing some webdev) I have

Re: [patch] cleaner checksum modification for pf

2015-09-30 Thread Richard Procter
On 29/09/2015, at 11:14 PM, Alexandr Nedvedicky wrote: > Hello, > > I've tried Richard's patch on sparc. I took a brief look at its source code. > It's essentially what PF is doing on Solaris. Thanks for doing that. Just for the record, I look at PF's patched checksum handling as follows.

sppp diet #2

2015-09-30 Thread Stuart Henderson
Left-over from the removal of sppp's special queue handling. Index: if_spppsubr.c === RCS file: /cvs/src/sys/net/if_spppsubr.c,v retrieving revision 1.138 diff -u -p -r1.138 if_spppsubr.c --- if_spppsubr.c 30 Sep 2015 09:45:20

Re: sppp diet #2

2015-09-30 Thread Mike Belopuhov
On 30 September 2015 at 14:07, Stuart Henderson wrote: > Left-over from the removal of sppp's special queue handling. > OK! > - /* > -* Put low delay, telnet, rlogin and ftp control packets > -* in front of the queue. > -*/ This made me cry

Re: sppp diet #2

2015-09-30 Thread Martin Pieuchot
On 30/09/15(Wed) 14:13, Mike Belopuhov wrote: > On 30 September 2015 at 14:07, Stuart Henderson wrote: > > Left-over from the removal of sppp's special queue handling. ok mpi@ > > - /* > > -* Put low delay, telnet, rlogin and ftp control packets > > -

Unlocking ix(4) a bit further

2015-09-30 Thread Mark Kettenis
Since people seemed to like my diff for em(4), here is one for ix(4). In addition to unlocking the rx completion path, this one also uses intr_barrier() and removes the rx mutex that claudio@ put in recently. I don't have any ix(4) hardware. So the only guarantee is that this compiles ;).

Re: sppp/pppoe and vlan prio

2015-09-30 Thread Stuart Henderson
On 2015/09/30 00:31, Stuart Henderson wrote: > This diff teachs sppp/pppoe(4) to set ifq priority on control frames > (LCP, PAP/CHAP, the various pppoe PADx). These cannot be set the normal > way because these non-IP frames aren't fed through PF. > > It's done using a #define which is currently

Re: iked patch for iOS9 IKEv2 VPN (and probably El Capitan)

2015-09-30 Thread Benjamin Perrault
> On Sep 30, 2015, at 6:09 PM, Reyk Floeter wrote: > >> On Wed, Sep 30, 2015 at 04:30:15PM +0100, Stuart Henderson wrote: >>> On 2015/09/30 17:17, Reyk Floeter wrote: >>> The attached diff always responds with a CERT or public key. If the >>> peer didn't send a CERTREQ, iked

explicit_bzero() for isakmpd(8)

2015-09-30 Thread Michael McConville
Index: sbin/isakmpd/hash.c === RCS file: /cvs/src/sbin/isakmpd/hash.c,v retrieving revision 1.23 diff -u -p -r1.23 hash.c --- sbin/isakmpd/hash.c 21 Mar 2013 04:30:14 - 1.23 +++ sbin/isakmpd/hash.c 1 Oct 2015 00:10:23 -

Re: tcpdump bpf_catchpacket crash

2015-09-30 Thread Stuart Henderson
In /sys/ddb/db_trap.c line 72, change if(panicstr != NULL) to if(1), it should give you a backtrace and short ps (showing only the active process on each cpu). These are now done automatically for panics, but not for other ddb entries (which includes uvm faults). On 30 September 2015 23:30:02

tcpdump bpf_catchpacket crash

2015-09-30 Thread Hrvoje Popovski
Hi, I have tested mp ix patches and at one point very naively, i did tcpdump on interface on which i generate traffic :) and everything is fine until i quit tcpdump with ^C, then crash happened. traffic is generated at high rate (10Mpps). this crash is 100% reproducible. in ddb console i can't do

More explicit_bzero() for ssh

2015-09-30 Thread Michael McConville
Index: usr.bin/ssh/sshbuf-misc.c === RCS file: /cvs/src/usr.bin/ssh/sshbuf-misc.c,v retrieving revision 1.4 diff -u -p -r1.4 sshbuf-misc.c --- usr.bin/ssh/sshbuf-misc.c 24 Mar 2015 20:03:44 - 1.4 +++

Re: Unlocking ix(4) a bit further

2015-09-30 Thread Alexey Suslikov
Mark Kettenis xs4all.nl> writes: > + * Thise parameter controls the minimum number of available transmit "Thise" should be "This" here.

iked patch for iOS9 IKEv2 VPN (and probably El Capitan)

2015-09-30 Thread Reyk Floeter
Hi, the following diffs allows to use iked/OpenIKED with iOS9 IKEv2 clients. You will be able to connect your super-large iPad Pro or premium iPhone 6s+ via OpenBSD :) I don't have El Capitan yet, but it might fix it for your super-light MacBook as well. Problem: iOS doesn't send a CERTREQ but

Re: Dubious loop logic in pciide(4)

2015-09-30 Thread Miod Vallat
> Certainly the least invasive. But I think you should drop the > semicolon after the label. Nope, the semicolon is required by the C standard those days (labels must be followed by statements).

Re: iked patch for iOS9 IKEv2 VPN (and probably El Capitan)

2015-09-30 Thread Stuart Henderson
On 2015/09/30 17:17, Reyk Floeter wrote: > The attached diff always responds with a CERT or public key. If the > peer didn't send a CERTREQ, iked now picks a cert based on its own > trusted CAs (which usually includes the CA that signed your local > cert). This diff looks sane, OK with me,

Re: Dubious loop logic in pciide(4)

2015-09-30 Thread Mark Kettenis
> Date: Wed, 30 Sep 2015 11:35:36 -0400 > From: Michael McConville > > Yesterday, I ran a Coccinelle script to find useless continue statements > and sent a few to tedu@. He pointed out that, based on the loop above > it, the one below probably meant to continue the

Re: CVS: cvs.openbsd.org: src

2015-09-30 Thread Joerg Jung
On Wed, Sep 30, 2015 at 05:13:31PM +0200, Martijn van Duren wrote: > On 09/30/15 14:15, Joerg Jung wrote: > >CVSROOT: /cvs > >Module name: src > >Changes by: j...@cvs.openbsd.org2015/09/30 06:15:12 > > > >Modified files: > > share/man/man4 : isa.4 > > sys/arch/amd64/conf: GENERIC

Re: iked patch for iOS9 IKEv2 VPN (and probably El Capitan)

2015-09-30 Thread Reyk Floeter
On Wed, Sep 30, 2015 at 04:30:15PM +0100, Stuart Henderson wrote: > On 2015/09/30 17:17, Reyk Floeter wrote: > > The attached diff always responds with a CERT or public key. If the > > peer didn't send a CERTREQ, iked now picks a cert based on its own > > trusted CAs (which usually includes the

Dubious loop logic in pciide(4)

2015-09-30 Thread Michael McConville
Yesterday, I ran a Coccinelle script to find useless continue statements and sent a few to tedu@. He pointed out that, based on the loop above it, the one below probably meant to continue the outer loop. Here's the least invasive fix, assuming we're correct. Thoughts? I don't know if this is the

Re: CVS: cvs.openbsd.org: src

2015-09-30 Thread Martijn van Duren
On 09/30/15 14:15, Joerg Jung wrote: CVSROOT:/cvs Module name:src Changes by: j...@cvs.openbsd.org2015/09/30 06:15:12 Modified files: share/man/man4 : isa.4 sys/arch/amd64/conf: GENERIC sys/arch/i386/conf: GENERIC sys/dev/isa: files.isa