rdist/rdistd: use mode_t for file modes

The file mode is passed from client to server as a printf string formatted with %04o (unsigned) so use strtoul() not strtol() to parse it. Error out on modes > 0. There is no way that the mode can ever be -1 so remove those checks. This rabbit hole brought to you by:

Re: rdistd: quiet compiler warnings

On Wed, 30 Mar 2016 14:29:05 -0600, Theo de Raadt wrote: > > /usr/src/usr.bin/rdistd/server.c:845: warning: zero-length printf format st > ring > > defs.h:void error(const char *, ...) __attribute__((format (printf, 1, 2))); > > That seems to be the source of this warning. That function is not

move "privileged port" check out of in(6)_pcbaddrisavail()

Hello, This diff moves the "are we binding to a privileged port while not being root ?" check from in(6)_pcbaddrisavail() to in_pcbbind(). This way we have a cleaner separation between "is the resource available ?" and "am I allowed to access the resource ?" (which may or may not get its own

Re: increase v_specbitmap size (allow more cloned devices)

On Wed, 30 Mar 2016 12:32:40 -0700, Philip Guenther wrote: > That structure is used for every (open?) device, no? Is there an > estimate of memory usage increase? Maybe the bitmap should be > separately allocated for the cloning device, as there's only a few of > those ever. That's a good

Re: rdistd: quiet compiler warnings

> /usr/src/usr.bin/rdistd/server.c:845: warning: zero-length printf format > string defs.h:void error(const char *, ...) __attribute__((format (printf, 1, 2))); That seems to be the source of this warning. That function is not printf-like, in that it produces an implicit newline... Shrug, it

Re: increase v_specbitmap size (allow more cloned devices)

>On Wed, Mar 30, 2016 at 7:31 AM, Martin Natano wrote: >> I'm currently working on a diff to make bpf a cloning device. Therefore >> it is necessary to increase the number of clones possible of a cloning >> device, as there are users with a need for more than 64 open bpf

rdistd: quiet compiler warnings

This fixed the following warnings: /usr/src/usr.bin/rdistd/server.c:845: warning: zero-length printf format string /usr/src/usr.bin/rdistd/server.c:1150: warning: zero-length printf format string The error() function already supports passing a NULL format string. This diff allows message() to

Re: increase v_specbitmap size (allow more cloned devices)

On Wed, Mar 30, 2016 at 7:31 AM, Martin Natano wrote: > I'm currently working on a diff to make bpf a cloning device. Therefore > it is necessary to increase the number of clones possible of a cloning > device, as there are users with a need for more than 64 open bpf devices >

Re: [PATCH] Proposal to remove -f for arp(8) and ndp(8)

Dimitris Papastamos writes: > On Wed, Mar 30, 2016 at 02:49:06PM +0200, Mike Belopuhov wrote: >> Good day, Dimitris. >> >> Long time ago in a galaxy far far away I've been using this >> alongside the -F option that I've added. While managed >> switches are becoming cheaper, I

Re: multi-pool malloc wip diff

On Mon Mar 28 2016 11:27, Otto Moerbeek wrote: > Second diff. Only one person (Stefan Kempf, thanks!) gave feedback... Sorry, running with this patch since a week, but missed to give feedback. As others already reported, no regressions here on amd64 also.

Re: [PATCH] Proposal to remove -f for arp(8) and ndp(8)

Mike Belopuhov writes: > Good day, Dimitris. > > Long time ago in a galaxy far far away I've been using this > alongside the -F option that I've added. While managed > switches are becoming cheaper, I don't see a reason for a > working feature to go away, especially since

Re: [patch] Fix carp(4) with balancing ip / ip-stealth

On 03/01/16 23:03, Martin Pieuchot wrote: > On 18/02/16(Thu) 16:46, Florian Riehm wrote: >> On 02/16/16 11:23, Martin Pieuchot wrote: >>> On 12/02/16(Fri) 16:33, Florian Riehm wrote: Hi Tech, I have noticed that CARP IP-Balancing is broken, so I am testing and fixing it.

Re: list manual upgrade for single processor in upgrade59.html

> This adds manual upgrade instructions for bsd.sp kernels similar to what > upgrade58 did. > > Don't want to miss the nice copy & paste for all kind of machines I support. good point. I added something similar to your diff back. Will be live soon. Untested, so please double check.

list manual upgrade for single processor in upgrade59.html

Hi, This adds manual upgrade instructions for bsd.sp kernels similar to what upgrade58 did. Don't want to miss the nice copy & paste for all kind of machines I support. regards, Giannis Index: upgrade59.html === RCS file:

increase v_specbitmap size (allow more cloned devices)

I'm currently working on a diff to make bpf a cloning device. Therefore it is necessary to increase the number of clones possible of a cloning device, as there are users with a need for more than 64 open bpf devices at the same time. mikeb@ pointed me to this thread:

Re: [PATCH] Proposal to remove -f for arp(8) and ndp(8)

On Wed, Mar 30, 2016 at 02:49:06PM +0200, Mike Belopuhov wrote: > Good day, Dimitris. > > Long time ago in a galaxy far far away I've been using this > alongside the -F option that I've added. While managed > switches are becoming cheaper, I don't see a reason for a > working feature to go away,

Re: [PATCH] Proposal to remove -f for arp(8) and ndp(8)

Good day, Dimitris. Long time ago in a galaxy far far away I've been using this alongside the -F option that I've added. While managed switches are becoming cheaper, I don't see a reason for a working feature to go away, especially since there has been zero rationale provided apart from "ndp -f"

Re: [PATCH] Proposal to remove -f for arp(8) and ndp(8)

Dimitris Papastamos writes: > Hi everyone, Hi, > I totally forgot about this patch. At the time it couldn't go in > because the tree was locked. Does it make sense? If so I will check > whether it applies on -current and resubmit. I don't understand the rationale. Using -f

Re: [PATCH] Proposal to remove -f for arp(8) and ndp(8)

Hi everyone, I totally forgot about this patch. At the time it couldn't go in because the tree was locked. Does it make sense? If so I will check whether it applies on -current and resubmit. On Fri, Jul 31, 2015 at 01:55:07PM +0100, Dimitris Papastamos wrote: > Hi everyone, > > This is a

Re: knote activate splhigh

On 29/03/16(Tue) 22:36, Alexander Bluhm wrote: > Hi, > > from a customer's system I got this panic: > > kernel diagnostic assertion "(kn->kn_status & KN_QUEUED) == 0" failed: file > ".. > /../../../kern/kern_event.c", line 1071 > > panic() at panic+0xfe > __assert() at __assert+0x25 >

Re: spamd - DNS whitelist - with prototype

I forgot to attach my prototype. Here it is. On 2016-03-29 Bob Beck wrote: > No. DNS based whitelisting does not belong in there. because it is > slow and DOS'able > > spamd is designed to be high speed low drag. If you want to do a DNS > based whitelist, write a little