Re: rc: reorder_libs: [1/2] Drop unused _l, exit early on failure

2017-07-15 Thread Theo Buehler
On Sun, Jul 16, 2017 at 03:34:07AM +0200, Klemens Nanni wrote: > $_l is not used and picking the latest archive versions is of no use > if /usr/lib cannot be written to. > > This patch applies cleanly before my next one but not vice versa. > > Feedback? OK? _l is only unused after your second

rc: reorder_libs: [2/2] Pick archive versions more efficiently

2017-07-15 Thread Klemens Nanni
Why looping over all existing archives, picking the latest version of the current archive, skipping it in case it's already in our list of selected latest versions or adding it otherwise? The current code runs ls|sort|tail about n * (v - 1) times for n different libraries and v versions

rc: reorder_libs: [1/2] Drop unused _l, exit early on failure

2017-07-15 Thread Klemens Nanni
$_l is not used and picking the latest archive versions is of no use if /usr/lib cannot be written to. This patch applies cleanly before my next one but not vice versa. Feedback? OK? Index: rc === RCS file: /cvs/src/etc/rc,v

Re: RFC 7217: /etc/{rc,netstart} [4/8]

2017-07-15 Thread Robert Peichaer
On Sat, Jul 15, 2017 at 05:09:43PM +, Florian Obser wrote: > netstart & simplification suggested by naddy > > OK? > > diff --git etc/netstart etc/netstart > index 71890bc7a5b..047eef1ab83 100644 > --- etc/netstart > +++ etc/netstart > @@ -190,6 +190,8 @@ if $PRINT_ONLY && (($# == 0)); then >

Re: RFC 7217: installer support [8/8]

2017-07-15 Thread Robert Peichaer
On Sat, Jul 15, 2017 at 05:16:04PM +, Florian Obser wrote: > OK? > > diff --git distrib/miniroot/install.sub distrib/miniroot/install.sub > index 26cecd81cbc..52360686b38 100644 > --- distrib/miniroot/install.sub > +++ distrib/miniroot/install.sub > @@ -2988,6 +2988,9 @@ do_upgrade() { >

Re: RFC 7217: random but stable addresses (take 2)

2017-07-15 Thread Tom Cosgrove
>>> Christian Weisgerber 14-Jul-17 23:04 >>> > > > secondly, im always wary of truncating hash output in case it throws > > away some of the guarantees it's supposed to provide. if you cut > > sha512 output down to an 8th of its size, is it 8 times easier to > > calculate a collision, or more than

ifstated diff cleanup before delegating proc/exec to privchild

2017-07-15 Thread Rob Pierce
This diff should probably be three separate diffs, but changes are colliding (i.e. adjacent lines of code are being modified within different diffs). The diff contains three modifications: - removal of unused logging code (see previous diff); - a cleanup of parse.y, converting it to use log.c;

Re: RFC 7217: changelist & mtree [5/8]

2017-07-15 Thread Florian Obser
less typo, pointed out by tb@, thanks! diff --git etc/changelist etc/changelist index 756927e29c6..9aed3f2a782 100644 --- etc/changelist +++ etc/changelist @@ -115,6 +115,7 @@ /etc/services /etc/shells /etc/snmpd.conf ++/etc/soii.key +/etc/spwd.db /etc/ssh/ssh_config

RFC 7217: slaacd support [7/8]

2017-07-15 Thread Florian Obser
OK? diff --git sbin/slaacd/engine.c sbin/slaacd/engine.c index 394df48eeb6..5fecf6e8779 100644 --- sbin/slaacd/engine.c +++ sbin/slaacd/engine.c @@ -64,6 +64,8 @@ #include #include +#include + #include #include #include @@ -180,6 +182,7 @@ struct address_proposal { uint8_t

RFC 7217: link local addresses [6/8]

2017-07-15 Thread Florian Obser
first thing that actually changes addresses: link local addresses - generate new link local address if soiikey changes - honour NOSOII flag when generating link local address - regen link local address if NOSOII flag changes OK? diff --git sys/net/if.c sys/net/if.c index

RFC 7217: /etc/{rc,netstart} [4/8]

2017-07-15 Thread Florian Obser
netstart & simplification suggested by naddy OK? diff --git etc/netstart etc/netstart index 71890bc7a5b..047eef1ab83 100644 --- etc/netstart +++ etc/netstart @@ -190,6 +190,8 @@ if $PRINT_ONLY && (($# == 0)); then exit 1 fi +$PRINT_ONLY || sysctl -q "net.inet6.ip6.soiikey=$( 0)); then

RFC 7217: interface flag [2/8]

2017-07-15 Thread Florian Obser
we need an interface flag to disable RFC 7217 processing, like autoconfprivacy it's on by default. OK? diff --git sys/net/if.h sys/net/if.h index 89867eac340..370c7928492 100644 --- sys/net/if.h +++ sys/net/if.h @@ -212,6 +212,7 @@ struct if_status_description { #defineIFXF_MPLS

RFC 7217: sysctl [1/8]

2017-07-15 Thread Florian Obser
I didn't not hear any objections to RFC 7217 support, so I guess it's time to get this thing in to get some operational experience with it before 6.2 is cut. Also the big diff gets a bit unwieldy, further improvement can happen in-tree. This is the sysctl part for "net.inet6.ip6.soiikey", written

[PATCH] axen improvement

2017-07-15 Thread sc dying
Hi, This patch does: - Fix axen won't work after interface down. - Fix definitions and comments that differ from linux ones. regards, --- sys/dev/usb/if_axen.c Fri Mar 3 15:04:52 2017 +++ sys/dev/usb/if_axen.c Mon Jun 19 16:05:09 2017 @@ -1256,6 +1256,14 @@ axen_init(void *xsc) */

[PATCH] ure improvement

2017-07-15 Thread sc dying
Hi, This patch does: - Enable RX aggregation. - Fix RX packet buffer alignment, using roundup() macro in sys/params.h. - Call usbd_set_config before configuring endpoints in ure_init to fix an error when re-opening pipes. I grabbed the code from if_kue.c. - Make the chip recognize given MAC

Re: RFC 7217: random but stable addresses (take 3)

2017-07-15 Thread Florian Obser
On Sat, Jul 15, 2017 at 06:58:40AM +0200, Sebastien Marie wrote: > On Fri, Jul 14, 2017 at 11:56:02AM +, Florian Obser wrote: > > next try > > - sha512 > > - fixed key size > > - /etc/soii.key > > - man page tweaks from sthen & jmc and rewording by me to get rid of 48 bits > > - link local