Re: cdio: read_track: plug leak

2017-09-10 Thread Scott Cheloha
> On Sep 10, 2017, at 9:35 PM, Michael W. Bombardieri wrote: > > Patch was also posted here, but I didn't test it. > https://marc.info/?l=openbsd-tech=149784342025304=2 omg we're twins

[Patch] Remove unnecessary assignment in pctr.c

2017-09-10 Thread Nan Xiao
Hi tech@ Remove unnecessary assignment. Thanks! Best Regards Nan Xiao Index: pctr.c === RCS file: /cvs/src/usr.bin/pctr/pctr.c,v retrieving revision 1.23 diff -u -p -r1.23 pctr.c --- pctr.c 10 Sep 2017 11:30:43 - 1.23

Re: cdio: read_track: plug leak

2017-09-10 Thread Michael W. Bombardieri
Hi, Patch was also posted here, but I didn't test it. https://marc.info/?l=openbsd-tech=149784342025304=2 - Michael On Sun, Sep 10, 2017 at 04:23:49PM -0500, Scott Cheloha wrote: > Hi, > > Saw this when preparing the monotonic clock patch. > > This is a leak, right? Every other return path

cdio: read_track: plug leak

2017-09-10 Thread Scott Cheloha
Hi, Saw this when preparing the monotonic clock patch. This is a leak, right? Every other return path in read_track() aside from the malloc failure frees sec. I think the function itself is more confusing than it needs to be and could use a refactor but that belongs in a separate patch.

cdio: mono clock for progress printouts in rip, write

2017-09-10 Thread Scott Cheloha
Hi, This keeps the progress printouts from stalling in the pathological case. We were also missing for gettimeofday(2). -- Scott Cheloha Index: usr.bin/cdio/mmc.c === RCS file: /cvs/src/usr.bin/cdio/mmc.c,v retrieving revision

md5(1): use mono clock in time trial

2017-09-10 Thread Scott Cheloha
Hi, Use a monotonic clock for the elapsed time trial. -- Scott Cheloha Index: bin/md5/md5.c === RCS file: /cvs/src/bin/md5/md5.c,v retrieving revision 1.91 diff -u -p -r1.91 md5.c --- bin/md5/md5.c 22 May 2017 16:00:47 -

Re: [PATCH] pwd_mkdb.8 - fix wording

2017-09-10 Thread Ingo Schwarze
Hi Raf, Raf Czlonka wrote on Sat, Sep 09, 2017 at 10:03:03PM +0100: > I guess the two could be simplified further and combined into one Done, and i also fixed various other aspects while there. Yours, Ingo