Re: mp-safe carp_iamatch6()

2017-11-22 Thread Hrvoje Popovski
On 22.11.2017. 15:48, Martin Pieuchot wrote: > Hrvoje Popovski reported the following panic when testing my diff to > unlock protocol inputs function: > > panic() at panic+0x128 > __assert(814d1114,800022755d80,809ce000,800022755e20) > carp_ourether(ff0003c0c290,

macppc: default to MBR for new installs

2017-11-22 Thread Stefan Sperling
This flips the default response for the macppc disk layout question from HFS to MBR. I use an MBR on all my macppc machines. Booting OpenBSD is much simpler this way. I don't see why I cannot just hit enter for this question on new installs. I'd rather let Mac software archaeologists who wish to d

less: use monotonic clock for line number echo

2017-11-22 Thread Scott Cheloha
Hi, The "Calculating line numbers" echo in less(1) is meant to fire after an interval has elapsed, so we should use the monotonic clock to measure. Currently, if the system time is changed during the execution of find_linenum() the echo fires too quickly or not at all. -- Scott Cheloha Index: u

Re: mp-safe carp_iamatch6()

2017-11-22 Thread Alexander Bluhm
On Wed, Nov 22, 2017 at 03:48:43PM +0100, Martin Pieuchot wrote: > Hrvoje Popovski reported the following panic when testing my diff to > unlock protocol inputs function: > > panic() at panic+0x128 > __assert(814d1114,800022755d80,809ce000,800022755e20) > carp_ourether(f

armv7 stand diff for clang

2017-11-22 Thread Mark Kettenis
Needed to build efiboot with clang. ok? Index: sys/arch/armv7/stand/efiboot/Makefile === RCS file: /cvs/src/sys/arch/armv7/stand/efiboot/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile --- sys/arch/armv7/stand/efiboot/M

Re: Regulators as sensors?

2017-11-22 Thread STeve Andre'
On 11/22/17 13:06, Anders Andersson wrote: On Tue, Nov 21, 2017 at 11:19 PM, STeve Andre' wrote: On 11/21/17 16:31, Mark Kettenis wrote: The diff below exposes voltage regulators as sensors. This makes it easy to look at the current settings of these regulators. The downside is that these

Re: Regulators as sensors?

2017-11-22 Thread Anders Andersson
On Tue, Nov 21, 2017 at 11:19 PM, STeve Andre' wrote: > On 11/21/17 16:31, Mark Kettenis wrote: >> >> The diff below exposes voltage regulators as sensors. This makes it >> easy to look at the current settings of these regulators. The >> downside is that these aren't really sensors as the voltag

Re: openssl s_time, speed: use monotime for absolute interval measurement

2017-11-22 Thread Scott Cheloha
Whoops, ignore that last patch, it lacked the static changes in apps_posix.c -- Scott Cheloha Index: usr.bin/openssl/apps_posix.c === RCS file: /cvs/src/usr.bin/openssl/apps_posix.c,v retrieving revision 1.2 diff -u -p -r1.2 apps_pos

Re: openssl s_time, speed: use monotime for absolute interval measurement

2017-11-22 Thread Scott Cheloha
On Sat, Nov 18, 2017 at 05:27:14PM +0100, Jeremie Courreges-Anglas wrote: > On Sat, Nov 11 2017, Scott Cheloha wrote: > > [...] > > I doubt that timersub/timespecsub are a big problem to add to -portable, > they're just macros. clock_gettime and getrusage seem to already be > used in libressl(-p

Re: Add Diffie-Hellman group negotiation to iked

2017-11-22 Thread Patrick Wildt
On 2017/06/25 21:44, Tim Stewart wrote: > My first patch did, in fact, break Child SAs rekeying. I have a new > patch at the end of this message that simply restricts DH group > negotiation to IKE SAs (I *think* that DH group guessing only applies to > IKE SAs, and perhaps only the IKE_SA_INIT exc

Azalia Apollo Lake Cosmetic Patch

2017-11-22 Thread Kevin Chadwick
Before realising the motherboard switch was set to i2s and wondering why I had no codecs I cooked up this patch. Almost entirely cosmetic, Change it, Take it or leave it, obviously. Note APPLE comment in azalia_codec.c added simply because quirk present for CS4206 and CS4208 and so guessed at rele

race-less nd6_timer

2017-11-22 Thread Martin Pieuchot
Hrvoje Popovski the great, found another crazy race related with NDP: # ifconfig vlan300 destroy kernel: protection fault trap, code=0 Stopped at nd6_ns_output+0x30: cmpb$0xff,0(%r13) ddb{0}> trace nd6_ns_output(ff0786bfe210,81434800,...) at nd6_ns_output+0x30 nd6_ll

mp-safe carp_iamatch6()

2017-11-22 Thread Martin Pieuchot
Hrvoje Popovski reported the following panic when testing my diff to unlock protocol inputs function: panic() at panic+0x128 __assert(814d1114,800022755d80,809ce000,800022755e20) carp_ourether(ff0003c0c290,809ce000) at carp_ourether nd6_ns_input(20,0,800

[PATCH] Enable PCMCIA ne(4) on macppc

2017-11-22 Thread Donovan Watteau
Hi, I have an old SMC 8041TX EZCard that happens to work in the PCMCIA slot of my PowerBook G4, when it's enabled with the following diff. dmesg also included. Index: GENERIC === RCS file: /cvs/src/sys/arch/macppc/conf/GENERIC,v ret

Re: cvsweb: cvs annotate error

2017-11-22 Thread Stuart Henderson
On 2017/11/22 14:48, Alexander Bluhm wrote: > On Wed, Nov 22, 2017 at 03:30:09PM +0800, Michael W. Bombardieri wrote: > > Sorry if this is the wrong list, but I found a couple of branch > > revisions in file src/sys/dev/midi.c which produce an error when > > clicking "annotate" link in cvsweb. > >

Re: avoid pcb lookup in pf forward

2017-11-22 Thread Alexandr Nedvedicky
Hello, On Wed, Nov 22, 2017 at 01:45:39PM +0100, Alexander Bluhm wrote: > On Wed, Nov 22, 2017 at 09:49:06AM +0100, Alexandr Nedvedicky wrote: > > > /* if reassembled packet passed, create new fragments */ > > > - if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD) { > > > + if

Re: cvsweb: cvs annotate error

2017-11-22 Thread Alexander Bluhm
On Wed, Nov 22, 2017 at 03:30:09PM +0800, Michael W. Bombardieri wrote: > Sorry if this is the wrong list, but I found a couple of branch > revisions in file src/sys/dev/midi.c which produce an error when > clicking "annotate" link in cvsweb. > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/dev/m

Re: sbunlock() w/o KERNEL_LOCK()

2017-11-22 Thread Alexander Bluhm
On Wed, Nov 22, 2017 at 01:01:25PM +0100, Martin Pieuchot wrote: > When we converted most of the splsoftnet() to NET_LOCK() we ended up > with some "lock" inversions between the socket buffer "lock" and the > NET_LOCK(). At that time the KERNEL_LOCK() was serializing access to > `sb_flags'. > > W

Re: ip_deliver() w/o KERNEL_LOCK

2017-11-22 Thread Alexander Bluhm
On Wed, Nov 22, 2017 at 12:19:49PM +0100, Martin Pieuchot wrote: > On 22/11/17(Wed) 11:05, Martin Pieuchot wrote: > > ip_deliver() dispatches incoming packets to their corresponding protocol > > input function. It doesn't need the KERNEL_LOCK(), so remove the assert > > and mark the dispatch table

Re: Implement __cxa_thread_atexit

2017-11-22 Thread Joerg Sonnenberger
On Mon, Nov 20, 2017 at 10:07:33PM +0100, Mark Kettenis wrote: > > Date: Sun, 19 Nov 2017 23:13:05 +0100 > > From: Joerg Sonnenberger > > > > On Sun, Nov 19, 2017 at 11:05:31PM +0100, Joerg Sonnenberger wrote: > > > On Sun, Nov 19, 2017 at 10:04:45PM +0100, Mark Kettenis wrote: > > > > Here is an

Re: avoid pcb lookup in pf forward

2017-11-22 Thread Alexander Bluhm
On Wed, Nov 22, 2017 at 09:49:06AM +0100, Alexandr Nedvedicky wrote: > > /* if reassembled packet passed, create new fragments */ > > - if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD) { > > + if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD && > > +

sbunlock() w/o KERNEL_LOCK()

2017-11-22 Thread Martin Pieuchot
When we converted most of the splsoftnet() to NET_LOCK() we ended up with some "lock" inversions between the socket buffer "lock" and the NET_LOCK(). At that time the KERNEL_LOCK() was serializing access to `sb_flags'. We're now moving towards running sockets functions w/o KERNEL_LOCK() in protoc

Re: ip_deliver() w/o KERNEL_LOCK

2017-11-22 Thread Martin Pieuchot
On 22/11/17(Wed) 11:05, Martin Pieuchot wrote: > ip_deliver() dispatches incoming packets to their corresponding protocol > input function. It doesn't need the KERNEL_LOCK(), so remove the assert > and mark the dispatch tables as 'const' all over the kernel. > > ok? I missed netinet6/ bits in th

ip_deliver() w/o KERNEL_LOCK

2017-11-22 Thread Martin Pieuchot
ip_deliver() dispatches incoming packets to their corresponding protocol input function. It doesn't need the KERNEL_LOCK(), so remove the assert and mark the dispatch tables as 'const' all over the kernel. ok? Index: kern/uipc_domain.c

Re: avoid pcb lookup in pf forward

2017-11-22 Thread Alexandr Nedvedicky
Hello, your change looks good to me as-is. Though the patch itself drags my attention to line here in pf_test(): > @@ -7072,7 +7083,8 @@ done: > > #ifdef INET6 > /* if reassembled packet passed, create new fragments */ > - if (pf_status.reass && action == PF_PASS && pd.m && fwdir ==