VMD: Fix Failure Start

2018-01-24 Thread Carlos Cardenas
Howdy. Attached is a patch to fix the following condition: When attempting to start a VM from vm.conf that fails (can't allocate resources, etc...), do not remove vm from vm list. Reported to bugs@ by mpi@. Comments? Ok? +--+ Carlos Index: config.c

Re: bridge(4): protected interface (port)

2018-01-24 Thread Tom Smyth
Hello, Martin, Remi, All Im very excited about this feature, Thanks Martin, Please see Comments inline below On 23 January 2018 at 18:06, Remi Locherer wrote: > On Mon, Jan 22, 2018 at 04:23:59PM +0100, Martin Pieuchot wrote: >> Diff below adds a new feature to bridge(4),

Re: awk: better support for \v and \a escapes

2018-01-24 Thread Jeremie Courreges-Anglas
On Tue, Jan 23 2018, "Todd C. Miller" wrote: > POSIX says awk supports \v and \a escapes but ours does not. > I used \007 for BEL since that is what awk's lex.c uses, though we > could safely use '\a' there instead. ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293

Re: malloc optimizations wrt junking and freezero

2018-01-24 Thread Otto Moerbeek
On Sun, Jan 21, 2018 at 11:50:24AM +0100, Otto Moerbeek wrote: > Hi, > > chunk pages do not need to be junked, all allocated chunks are already > junked on free. Same hold for a few error paths. > > Also, for freezero(), only clear the size as reqeusted instead of the > whole allocation. > >

iwn/iwm: ignore missed beacons during background scan

2018-01-24 Thread Stefan Sperling
I just observed iwn(4) firmware reporting a missed beacon event during a background scan: Jan 24 18:24:50 laptop /bsd: iwn0: begin background scan Jan 24 18:24:57 laptop /bsd: iwn0: sending probe_req to xx:xx:xx:xx:xx:xx on channel 10 mode 11g Jan 24 18:24:59 laptop /bsd: iwn0: end background

Re: ftp: use closefrom instead of close(pid)

2018-01-24 Thread Theo de Raadt
Sure. But always be careful that the fd loop isn't bounded for a reason, for instance some fd at > 20 that it wanted left open. > This variable reuse has a funny smell. > > Index: usr.bin/ftp/cmds.c > === > RCS file:

ksh: bug with quoted parameter expansion

2018-01-24 Thread mail
I found a bug in ksh's parameter expansion on an edge case: true $(true "${USER#'"'}") /home/sh[4]: no closing quote The problem seems to occurs when all of these conditions are present: 1. On ${var#pattern} or ${var%pattern} parameter expansion 2. When the pattern contains a

Re: ftp: use closefrom instead of close(pid)

2018-01-24 Thread Jeremie Courreges-Anglas
On Wed, Jan 24 2018, Theo Buehler wrote: > This variable reuse has a funny smell. ok > Index: usr.bin/ftp/cmds.c > === > RCS file: /var/cvs/src/usr.bin/ftp/cmds.c,v > retrieving revision 1.79 > diff -u -p

ftp: use closefrom instead of close(pid)

2018-01-24 Thread Theo Buehler
This variable reuse has a funny smell. Index: usr.bin/ftp/cmds.c === RCS file: /var/cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.79 diff -u -p -r1.79 cmds.c --- usr.bin/ftp/cmds.c 21 Jan 2017 08:33:07 - 1.79 +++

Re: carp_ourether() tweak

2018-01-24 Thread Alexander Bluhm
On Mon, Jan 22, 2018 at 11:58:30AM +0100, Martin Pieuchot wrote: > Check if `if_carp' is empty inside carp_ourether() instead of outside. > > ok? Maybe I am confused by the ! and && but I think this diff changes the logic. Old code: - if_carp is empty - SRPL_EMPTY_LOCKED(>ifp->if_carp) is