Remove DM* modem control commands

2018-02-13 Thread Tobias Ulmer
Remove the ancient tty.h DMSET etc. modem control commands. They're confusing to someone without the historical background. No documentation doesn't help either. TIOCM* serve the same purpose, are documented in tty(4) and the various *ctl() functions use the TTYCM_ register definitions, making thi

Re: em: minimum ethernet frame size

2018-02-13 Thread Michele Curti
On Fri, Feb 09, 2018 at 03:40:13PM +0100, Martin Pieuchot wrote: > On 02/02/18(Fri) 12:18, Michele Curti wrote: > > Hi, > > in sys/dev/pci/if_em.c at line 469 there is: > > sc->hw.min_frame_size = > > ETHER_MIN_LEN + ETHER_CRC_LEN; > > > > But ETHER_MIN_LEN already includes the CRC siz

[PATCH] Possible case of 0 return on error in tls_read/tls_write

2018-02-13 Thread Devchandra L Meetei
Hi While going through code of `tls_read` listed below. It looks like to me that there is possibility of returning 0 on error when following code-flow takes place 1) if tls_handshake(ctx) returns 0, Now rv is 0. It goes to if ((ctx->state & TLS_HANDSHAKE_COMPLETE) == 0) { if ((rv

[PATCH] Possible case of 0 return on error in tls_read/tls_write

2018-02-13 Thread Devchandra L Meetei
Hi While going through code of `tls_read` listed below. It looks like to me that there is possibility of returning 0 on error when following code-flow takes place 1) if tls_handshake(ctx) returns 0, Now rv is 0. It goes to if ((ctx->state & TLS_HANDSHAKE_COMPLETE) == 0) { if ((rv

Sizes for free() in the Enhanced SpeedStep driver

2018-02-13 Thread Frederic Cambus
Hi tech@, Add sizes for free() in the i386 version of the Enhanced SpeedStep driver. It was already done on amd64, but not on i386. Tested on an Atom N270. Comments? OK? Index: sys/arch/i386/i386/est.c === RCS file: /cvs/src/sys/ar