[PATCH] nsclpcsio: nuke unused variable

2018-06-03 Thread Kevin Lo
Hi, This diff zaps unused variable. Ok? Index: sys/dev/isa/nsclpcsio_isa.c === RCS file: /cvs/src/sys/dev/isa/nsclpcsio_isa.c,v retrieving revision 1.13 diff -u -p -u -p -r1.13 nsclpcsio_isa.c --- sys/dev/isa/nsclpcsio_isa.c 15 Oct

Re: witness report

2018-06-03 Thread Alexander Bluhm
On Sun, Jun 03, 2018 at 10:37:30AM -0700, Philip Guenther wrote: > @@ -1602,7 +1607,7 @@ vfs_stall(struct proc *p, int stall) >*/ > TAILQ_FOREACH_REVERSE(mp, , mntlist, mnt_list) { > if (stall) { > - error = vfs_busy(mp, VB_WRITE|VB_WAIT); > +

Re: witness report

2018-06-03 Thread Alexander Bluhm
On Sun, Jun 03, 2018 at 10:37:30AM -0700, Philip Guenther wrote: > Diff below adds VB_DUPOK to indicate that a given vfs_busy() call is > expected/permitted to occur while the thread already holds another > filesystem busy; the caller is responsible for ensuring the filesystems > are locked in

Make libc/libpthread use process-private futexes

2018-06-03 Thread Mark Kettenis
Now that the kernel distinguishes between process-shared and process-private futexes make libc/libpthread use process-private ones. ok? Index: lib/libc/thread/synch.h === RCS file: /cvs/src/lib/libc/thread/synch.h,v retrieving

Re: netstat: zap unused maxmif

2018-06-03 Thread Alexander Bluhm
On Sun, Jun 03, 2018 at 04:22:02PM +0200, Klemens Nanni wrote: > Unused since introduction in 1.17 from 2015. > > OK? OK bluhm@ > Index: mroute6.c > === > RCS file: /cvs/src/usr.bin/netstat/mroute6.c,v > retrieving revision 1.23 >

Re: witness report

2018-06-03 Thread Amit Kulkarni
On Sun, 3 Jun 2018 13:09:43 -0700 Philip Guenther wrote: > On Sun, Jun 3, 2018 at 12:51 PM, Amit Kulkarni wrote: > > > On Sun, 3 Jun 2018 10:37:30 -0700 > > Philip Guenther wrote: > > > ... > > > > Index: kern/kern_rwlock.c > > >

Re: witness report

2018-06-03 Thread Philip Guenther
On Sun, Jun 3, 2018 at 12:51 PM, Amit Kulkarni wrote: > On Sun, 3 Jun 2018 10:37:30 -0700 > Philip Guenther wrote: > ... > > Index: kern/kern_rwlock.c > > === > > RCS file: /data/src/openbsd/src/sys/kern/kern_rwlock.c,v > >

Re: witness report

2018-06-03 Thread Amit Kulkarni
On Sun, 3 Jun 2018 10:37:30 -0700 Philip Guenther wrote: > On Sun, 3 Jun 2018, Theo de Raadt wrote: > > Philip Guenther wrote: > > > The warning is not that a single filesystem is being locked > > > recursively by a single thread, but just that a single thread is > > > holding locks on

OpenBSD will never run on XScale again

2018-06-03 Thread Mark Kettenis
Time to get rid of these #ifdef __XSCALE__ bits. No binary change. ok? Index: arch/arm/arm/bcopy_page.S === RCS file: /cvs/src/sys/arch/arm/arm/bcopy_page.S,v retrieving revision 1.1 diff -u -p -r1.1 bcopy_page.S ---

Re: witness report

2018-06-03 Thread Philip Guenther
On Sun, 3 Jun 2018, Theo de Raadt wrote: > Philip Guenther wrote: > > The warning is not that a single filesystem is being locked > > recursively by a single thread, but just that a single thread is > > holding locks on multiple filesystems. > > vfs_stall() needs to grab locks on all

Re: witness report

2018-06-03 Thread Theo de Raadt
Philip Guenther wrote: > The warning is not that a single filesystem is being locked recursively by a > single > thread, but just that a single thread is holding locks on multiple > filesystems. vfs_stall() needs to grab locks on all filesystems, to stop a variety of filesystem transactions.

Re: witness report

2018-06-03 Thread Philip Guenther
On Sun, Jun 3, 2018 at 9:08 AM, Theo de Raadt wrote: > Philip Guenther wrote: > > > On Sun, Jun 3, 2018 at 3:26 AM, Klemens Nanni wrote: > > > > > Snap from 31.05.2018 with > > > > > > OpenBSD 6.3-current (GENERIC.MP) #0: Sat Jun 2 16:21:22 CEST 2018 > > >

Re: witness report

2018-06-03 Thread Theo de Raadt
Philip Guenther wrote: > On Sun, Jun 3, 2018 at 3:26 AM, Klemens Nanni wrote: > > > Snap from 31.05.2018 with > > > > OpenBSD 6.3-current (GENERIC.MP) #0: Sat Jun 2 16:21:22 CEST 2018 > > k...@x250.my.domain:/usr/src/sys/arch/amd64/compile/GENERIC.MP > > > > > > acquiring duplicate lock

Re: Allow disks to be specifid by duid in install.sub

2018-06-03 Thread kwesterback
> On Jun 2, 2018, at 3:27 PM, Robert Peichaer wrote: > >> On Fri, May 18, 2018 at 12:14:36PM +0200, Theo Buehler wrote: >>> On Thu, May 17, 2018 at 06:42:15PM -0600, Aaron Bieber wrote: On Thu, May 17, 2018 at 06:37:56PM -0600, Aaron Bieber wrote: > On Fri, Mar 02, 2018 at 07:32:04AM

Re: witness report

2018-06-03 Thread Philip Guenther
On Sun, Jun 3, 2018 at 3:26 AM, Klemens Nanni wrote: > Snap from 31.05.2018 with > > OpenBSD 6.3-current (GENERIC.MP) #0: Sat Jun 2 16:21:22 CEST 2018 > k...@x250.my.domain:/usr/src/sys/arch/amd64/compile/GENERIC.MP > > > acquiring duplicate lock of same type: ">mnt_lock" > 1st vfslock @

Re: smtpd/parse.y : fix line count

2018-06-03 Thread Gilles Chehade
On Sat, Jun 02, 2018 at 10:32:52PM +0200, Denis Fondras wrote: > Applying otto@'s diff to smtpd. > Fixes an off-by-one line count when using include statements. > > Ok ? > tested, ok gilles@ > Index: parse.y > === > RCS file:

netstat: zap unused maxmif

2018-06-03 Thread Klemens Nanni
Unused since introduction in 1.17 from 2015. OK? Index: mroute6.c === RCS file: /cvs/src/usr.bin/netstat/mroute6.c,v retrieving revision 1.23 diff -u -p -r1.23 mroute6.c --- mroute6.c 8 May 2017 09:31:34 - 1.23 +++

Re: Installer support to fetch/verify bsd.rd for release upgrade

2018-06-03 Thread Robert Peichaer
On Sun, Oct 08, 2017 at 09:56:15AM +, Robert Peichaer wrote: > Up to now, the upgrade procedure from one to the next release meant > that you had to manually download and verify the new ramdisk kernel. > > What about if you just needed to boot into the existing bsd.rd and > it would support

witness report

2018-06-03 Thread Klemens Nanni
Snap from 31.05.2018 with OpenBSD 6.3-current (GENERIC.MP) #0: Sat Jun 2 16:21:22 CEST 2018 k...@x250.my.domain:/usr/src/sys/arch/amd64/compile/GENERIC.MP acquiring duplicate lock of same type: ">mnt_lock" 1st vfslock @ /usr/src/sys/kern/vfs_subr.c:191 2nd vfslock @

Re: route: improve inet6_makenetandmask

2018-06-03 Thread Klemens Nanni
On Sun, May 27, 2018 at 03:13:04AM +0200, Klemens Nanni wrote: > On Sat, May 26, 2018 at 11:49:29PM +0200, Denis Fondras wrote: > > Not related to this diff but RFC2374 has been made obsolete by RFC3587 for > > some > > years : "implementations should not make any assumptions about 2000::/3 > >

Re: ospfd/parse.y : fix line count

2018-06-03 Thread Remi Locherer
On Sat, Jun 02, 2018 at 10:33:11PM +0200, Denis Fondras wrote: > Applying otto@'s diff to ospfd. > Fixes an off-by-one line count when using include statements. > > Ok ? I applied your diff and verified that the line number for errors in included files is now correct. ok remi@ > > Index:

Re: ospf6d/parse.y : fix line count

2018-06-03 Thread Remi Locherer
On Sat, Jun 02, 2018 at 10:33:07PM +0200, Denis Fondras wrote: > Applying otto@'s diff to ospf6d. > Fixes an off-by-one line count when using include statements. > > Ok ? I applied your diff and verified that the line number for errors in included files is now correct. ok remi@ > > Index:

Re: route: zap unused sockaddr

2018-06-03 Thread Alexander Bluhm
On Sun, Jun 03, 2018 at 01:05:32AM +0200, Klemens Nanni wrote: > No object change. > > OK? usr.bin/netstat/show.c has the same code. They should stay in sync. Please change it there, too. Then OK bluhm@. > Index: show.c > === >