Re: NMEA: add more gps sensor values (2nd take)

2018-12-28 Thread Paul Irofti
> so now that the sensor types got adjusted, here's the tty_nmea.c diff > again, adding 7 new sensors: > - # satellites (raw) > - GPS/DGPS fix (or not) (raw) > - HDOP/VDOP/PDOP (raw) > - Altitude (m) > - Speed (m/s) Yay sensors! > i'd welcome eyes on the logic, and especially on the nmea_atoi()

NMEA: add more gps sensor values (2nd take)

2018-12-28 Thread Landry Breuil
Hi, so now that the sensor types got adjusted, here's the tty_nmea.c diff again, adding 7 new sensors: - # satellites (raw) - GPS/DGPS fix (or not) (raw) - HDOP/VDOP/PDOP (raw) - Altitude (m) - Speed (m/s) i'd welcome eyes on the logic, and especially on the nmea_atoi() implementation - it is

ospf6d: fib-priority

2018-12-28 Thread Remi Locherer
Hi tech, this allows to adjust the priority of the routes that ospf6d inserts into the kernel routing table. It's basically the same change that I commited to ospfd today (without reload support). OK? Remi Index: kroute.c ===

video(1) pledge (& updated kernel diff)

2018-12-28 Thread Landry Breuil
Hi, so i've updated my 'video' class for pledge and also did an initial naive pledging of xenocara/app/video: the kernel diff is the same subset as the diff from some months ago, except that it adds: - VIDIOC_QUERYCTRL/VIDIOC_G_CTRL/VIDIOC_S_CTRL: those 3 are used by video(1) to set

Re: MPLSv6 2/2 : bgpd diff

2018-12-28 Thread Claudio Jeker
On Fri, Dec 28, 2018 at 05:21:02PM +0100, Denis Fondras wrote: > On Fri, Dec 28, 2018 at 03:15:35PM +0100, Claudio Jeker wrote: > > > /* > > > * This function will have undefined behaviour if the passed in > > > prefixlen is > > > - * to large for the respective bgpd_addr address family. > > >

Re: MPLSv6 2/2 : bgpd diff

2018-12-28 Thread Claudio Jeker
On Fri, Dec 28, 2018 at 07:50:08PM +0100, Denis Fondras wrote: > On Fri, Dec 28, 2018 at 06:08:16PM +0100, Klemens Nanni wrote: > > On Fri, Dec 28, 2018 at 05:21:02PM +0100, Denis Fondras wrote: > > > int > > > +krVPN6_change(struct ktable *kt, struct kroute_full *kl, u_int8_t > > > fib_prio) >

Re: MPLSv6 2/2 : bgpd diff

2018-12-28 Thread Denis Fondras
On Fri, Dec 28, 2018 at 06:08:16PM +0100, Klemens Nanni wrote: > On Fri, Dec 28, 2018 at 05:21:02PM +0100, Denis Fondras wrote: > > int > > +krVPN6_change(struct ktable *kt, struct kroute_full *kl, u_int8_t fib_prio) > > +{ > > + struct kroute6_node *kr6; > > + struct in6_addr

Re: MPLSv6 2/2 : bgpd diff

2018-12-28 Thread Klemens Nanni
On Fri, Dec 28, 2018 at 05:21:02PM +0100, Denis Fondras wrote: > int > +krVPN6_change(struct ktable *kt, struct kroute_full *kl, u_int8_t fib_prio) > +{ > + struct kroute6_node *kr6; > + struct in6_addr lo6 = IN6ADDR_LOOPBACK_INIT; > + int action =

Re: MPLSv6 2/2 : bgpd diff

2018-12-28 Thread Denis Fondras
On Fri, Dec 28, 2018 at 03:15:35PM +0100, Claudio Jeker wrote: > > /* > > * This function will have undefined behaviour if the passed in prefixlen > > is > > - * to large for the respective bgpd_addr address family. > > + * too large for the respective bgpd_addr address family. > > */ > >

Re: bgpd: remove intermediate value in MP capabilities

2018-12-28 Thread Claudio Jeker
On Fri, Dec 28, 2018 at 02:58:23PM +0100, Denis Fondras wrote: > The parser sets curpeer->conf.capabilities.mp to -1 before setting it to > either > 1 or 0 by default. Set it to 0 by default and change it to 1 when needed. > > Index: parse.y >

Re: MPLSv6 2/2 : bgpd diff

2018-12-28 Thread Claudio Jeker
On Tue, Dec 18, 2018 at 12:13:38PM +0100, Denis Fondras wrote: > Here is a serie of diffs to enable MPLSv6, MPLS transport over IPv6. > > Second diff : add support for IPv6 MPLS routes exchange with bgpd(8). > > (***) > pe1# cat /etc/hostname.mpe0

bgpd: remove intermediate value in MP capabilities

2018-12-28 Thread Denis Fondras
The parser sets curpeer->conf.capabilities.mp to -1 before setting it to either 1 or 0 by default. Set it to 0 by default and change it to 1 when needed. Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving

Re: ospfd: fib-priority

2018-12-28 Thread Claudio Jeker
On Fri, Dec 28, 2018 at 02:32:54PM +0100, Remi Locherer wrote: > ping OK claudio@ > On Mon, Dec 10, 2018 at 10:40:22AM +0100, Remi Locherer wrote: > > Hi, > > > > below patch adds "fib-priority" to ospfd.conf which allows to set a > > custom priority to routes. 32 is still the default if not

Re: ospfd: fib-priority

2018-12-28 Thread Remi Locherer
ping On Mon, Dec 10, 2018 at 10:40:22AM +0100, Remi Locherer wrote: > Hi, > > below patch adds "fib-priority" to ospfd.conf which allows to set a > custom priority to routes. 32 is still the default if not set. Changing > the priority with a reload is also supported. > > A discussion about the

Re: typo in getgrent.3

2018-12-28 Thread Theo Buehler
On Fri, Dec 28, 2018 at 01:25:02PM +0200, Lauri Tirkkonen wrote: > Hi, trivial typo fix for getgrent.3. fixed, thanks.

Re: tcpdump: print SAFI name

2018-12-28 Thread Claudio Jeker
On Fri, Dec 28, 2018 at 12:16:05PM +0100, Denis Fondras wrote: > Print well-known SAFI name instead of value. > > * Before: > BGP (OPEN: Version 4, AS #65530, Holdtime 90, ID 10.2.2.2, Option length 44 > ((CAP MULTI_PROTOCOL [IPv4 Unicast], CAP MULTI_PROTOCOL [IPv4 #128], CAP > MULTI_PROTOCOL

typo in getgrent.3

2018-12-28 Thread Lauri Tirkkonen
Hi, trivial typo fix for getgrent.3. diff --git a/lib/libc/gen/getgrent.3 b/lib/libc/gen/getgrent.3 index d3c12bad042..f26ae625997 100644 --- a/lib/libc/gen/getgrent.3 +++ b/lib/libc/gen/getgrent.3 @@ -193,7 +193,7 @@ group database file .El .Sh ERRORS The -.Fn getgruid_r +.Fn getgrgid_r and

tcpdump: print SAFI name

2018-12-28 Thread Denis Fondras
Print well-known SAFI name instead of value. * Before: BGP (OPEN: Version 4, AS #65530, Holdtime 90, ID 10.2.2.2, Option length 44 ((CAP MULTI_PROTOCOL [IPv4 Unicast], CAP MULTI_PROTOCOL [IPv4 #128], CAP MULTI_PROTOCOL [IPv6 #128], CAP ROUTE_REFRESH, CAP GRACEFUL_RESTART [R], Time 90s (IPv4