Re: pfctl.8: mention that -T{add,replace} creates persistent tables

2018-12-30 Thread Jason McIntyre
On Sun, Dec 30, 2018 at 04:24:57PM +0100, Klemens Nanni wrote: > If the given table "t" does not exist, `pfctl -t t -T replace' and > `pfctl -t t -T add ::1' will create it persistently: > > # pfctl -sT > # pfctl -tt -Tr > 1 table created. > no changes. > # pfctl

Re: ksh: quote empties

2018-12-30 Thread Martijn Dekker
Op 30-12-18 om 23:43 schreef Philip Guenther: This thread was never resolved/committed. Looking again at the diffs, I still think I prefer that we_not_ touch print_value_quoted(), as the other callers all use the 'key=value' format and don't need special handling of empty values, [...] Not

[PATCH] wsmux consistency: me_parent should be set while me is in _cld

2018-12-30 Thread Greg Steuck
The invariant (me->me_parent == sc) is checked everywhere. Breaking it before removal doesn't seem consistent with the other TAILQ_REMOVE and also is not in the reverse order of TAILQ_INSERT_TAIL. dash of style while here. --- sys/dev/wscons/wsmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: ksh: quote empties

2018-12-30 Thread Todd C. Miller
On Sun, 30 Dec 2018 14:43:37 -0800, Philip Guenther wrote: > This thread was never resolved/committed. Looking again at the diffs, I > still think I prefer that we _not_ touch print_value_quoted(), as the > other callers all use the 'key=value' format and don't need special > handling of

Re: ksh: quote empties

2018-12-30 Thread Philip Guenther
On Sun, 15 Apr 2018, Martijn Dekker wrote: > Op 15-04-18 om 03:41 schreef Philip Guenther: > > On Sun, 15 Apr 2018, Klemens Nanni wrote: > > > It also badly effects non-empty cases: > > ... > > > $ ./obj/ksh -c alias > > > autoload='' > > > functions='' > > > > Hah! The original diff i

reduce libgen.h usage

2018-12-30 Thread Philip Guenther
only prototypes dirname() and basename(). There are a bunch of source files that #include it but don't need it; the diff below deletes those pointless includes. ok? Philip Index: bin/ksh/edit.c === RCS file:

ripd: fib-priority

2018-12-30 Thread Remi Locherer
Hi tech, after adding the config option "fib-priority" to ospfd/ospf6d I figured out that it is almost the same change to add it to ripd. After that all our routing daemons (unicast) have an option to adjust the fib-priority. Or did I miss one? OK? Remi Index: kroute.c

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Landry Breuil
On Sun, Dec 30, 2018 at 02:23:59PM -0700, Theo de Raadt wrote: > Landry Breuil wrote: > > > On Sun, Dec 30, 2018 at 01:37:26PM -0700, Theo de Raadt wrote: > > > That's a big step you are taking there > > > > > > "ldattach -t nmea" was written to extract time information for ntpd. > > > > > >

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Theo de Raadt
Landry Breuil wrote: > On Sun, Dec 30, 2018 at 01:37:26PM -0700, Theo de Raadt wrote: > > That's a big step you are taking there > > > > "ldattach -t nmea" was written to extract time information for ntpd. > > > > It was not written to extract any other information. > > > > Until you came up

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Landry Breuil
On Sun, Dec 30, 2018 at 01:37:26PM -0700, Theo de Raadt wrote: > That's a big step you are taking there > > "ldattach -t nmea" was written to extract time information for ntpd. > > It was not written to extract any other information. > > Until you came up with a diff which extracts other

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Theo de Raadt
Landry Breuil wrote: > Except that most devices around have a builtin microphone, all laptops > have builtin webcams, and none have a builtin gps device. When you buy > and plug a specific devices, you plan to make use of it.. To extend your reasoning, a usb stick you plug in should be readable

pfctl: brace anchors must not be empty

2018-12-30 Thread Klemens Nanni
There's a (subtle) bug in anchor creation/handling I haven't quite pinned down yet: Nested brace anchors with names end up being loaded under a different name if their ruleset is empty: $ pfctl -aa1 -vnf- anchor a2 { } match ^D anchor "a1/a2" all

Re: make NET_TASKQ optionable

2018-12-30 Thread Theo de Raadt
No please don't do that. For lots of reasons. Instead test it, fix the bugs that have stopped it from being enabled in a better way, and do so as a community. #ifndef does not actually help that process. >For future testing purposes, is this ok for the tree? > >Index: if.c

make NET_TASKQ optionable

2018-12-30 Thread Chris Cappuccio
For future testing purposes, is this ok for the tree? Index: if.c === RCS file: /cvs/src/sys/net/if.c,v retrieving revision 1.570 diff -u -p -u -r1.570 if.c --- if.c20 Dec 2018 10:26:36 - 1.570 +++ if.c30 Dec

pfctl.8: mention that -T{add,replace} creates persistent tables

2018-12-30 Thread Klemens Nanni
If the given table "t" does not exist, `pfctl -t t -T replace' and `pfctl -t t -T add ::1' will create it persistently: # pfctl -sT # pfctl -tt -Tr 1 table created. no changes. # pfctl -vsT -pa t pf.conf(5) provides this information:

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Landry Breuil
On Sun, Dec 30, 2018 at 05:17:54AM -0700, Theo de Raadt wrote: > I think you've gone overboard adding sensors. > > Some of them aren't informing a fact about the world, but about the GPS device > operation. > > Therefore I think nsat, quality, hdop, vdop, pdop are irrelevant. These > are

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Landry Breuil
On Sun, Dec 30, 2018 at 06:04:17AM -0700, Theo de Raadt wrote: > Anyways, I haven't seen a specific consumer ready to use this > information from sysctl. I'm sure such programs exist and will be > adapted to use sysctl (or a file, will we make it mode 600 by > default?) rather than some linux

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Mark Kettenis
> From: Theo de Raadt > Date: Sun, 30 Dec 2018 06:04:17 -0700 (MST) > > From mark.kette...@sibelius.xs4all.nl Sun Dec 30 05:47:33 2018 > >Date: Sun, 30 Dec 2018 13:47:30 +0100 (CET) > >From: Mark Kettenis > > > >> From: Theo de Raadt > >> Date: Sun, 30 Dec 2018 05:17:54 -0700 (MST) > >> > >>

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Landry Breuil
On Sun, Dec 30, 2018 at 05:17:54AM -0700, Theo de Raadt wrote: > I think you've gone overboard adding sensors. > > Some of them aren't informing a fact about the world, but about the GPS device > operation. > > Therefore I think nsat, quality, hdop, vdop, pdop are irrelevant. These > are

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Theo de Raadt
>From mark.kette...@sibelius.xs4all.nl Sun Dec 30 05:47:33 2018 >Delivered-To: dera...@cvs.openbsd.org >Date: Sun, 30 Dec 2018 13:47:30 +0100 (CET) >From: Mark Kettenis >To: Theo de Raadt >CC: lan...@openbsd.org, p...@irofti.net, tech@openbsd.org >In-reply-to: <2cee4d488423c...@openbsd.org>

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Mark Kettenis
> From: Theo de Raadt > Date: Sun, 30 Dec 2018 05:17:54 -0700 (MST) > > I think you've gone overboard adding sensors. > > Some of them aren't informing a fact about the world, but about the > GPS device operation. > > Therefore I think nsat, quality, hdop, vdop, pdop are irrelevant. These >

Re: ospf6d: fib-priority

2018-12-30 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.12.29 17:09:51 +0100: > On Sat, Dec 29, 2018 at 02:06:32PM +0100, Denis Fondras wrote: > > On Fri, Dec 28, 2018 at 09:50:50PM +0100, Remi Locherer wrote: > > > Hi tech, > > > > > > this allows to adjust the priority of the routes that ospf6d inserts >

Re: bgpd mrt bad sizeof

2018-12-30 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.12.29 23:46:18 +0100: > On Sat, Dec 29, 2018 at 08:24:50PM +0100, Sebastian Benoit wrote: > > Hi, > > > > we allocate the wrong size here i think. > > > > ok? > > No, this diff is wrong. Check out the parse.y code. It uses MRT2MC to > access

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Theo de Raadt
I think you've gone overboard adding sensors. Some of them aren't informing a fact about the world, but about the GPS device operation. Therefore I think nsat, quality, hdop, vdop, pdop are irrelevant. These are basically protocol-specific / device-specific "error bars". I think you should

Re: uudecode error message

2018-12-30 Thread Klemens Nanni
On Sun, Dec 30, 2018 at 12:19:54PM +0100, Alexander Bluhm wrote: > uudecode: in: out: character value (159) out of range [33-96] OK

Re: NMEA: add more gps sensor values (2nd take)

2018-12-30 Thread Landry Breuil
On Sat, Dec 29, 2018 at 12:45:07AM +0200, Paul Irofti wrote: > > so now that the sensor types got adjusted, here's the tty_nmea.c diff > > again, adding 7 new sensors: > > - # satellites (raw) > > - GPS/DGPS fix (or not) (raw) > > - HDOP/VDOP/PDOP (raw) > > - Altitude (m) > > - Speed (m/s) > >

Re: uudecode error message

2018-12-30 Thread Alexander Bluhm
On Sat, Dec 29, 2018 at 07:52:42PM -0500, Ted Unangst wrote: > Would "character value (%d) out of range" be clearer? > Also, I think you should add an (unsigned char) cast uudecode: in: out: character value (159) out of range [33-96] better? Index: usr.bin/uudecode/uudecode.c

Re: video(1) pledge (& updated kernel diff)

2018-12-30 Thread Sebastien Marie
On Sun, Dec 30, 2018 at 10:58:58AM +0100, Landry Breuil wrote: > On Sat, Dec 29, 2018 at 09:30:22AM +0100, Sebastien Marie wrote: > > On Fri, Dec 28, 2018 at 09:41:06PM +0100, Landry Breuil wrote: > > > I think you pledged too early. > > > > "dns unix" are here for XOpenDisplay(), but if the

Re: video(1) pledge (& updated kernel diff)

2018-12-30 Thread Sebastien Marie
On Sun, Dec 30, 2018 at 10:58:58AM +0100, Landry Breuil wrote: > On Sat, Dec 29, 2018 at 09:30:22AM +0100, Sebastien Marie wrote: > > On Fri, Dec 28, 2018 at 09:41:06PM +0100, Landry Breuil wrote: > > > > I would separate the addition of pledge(2) and unrelated fixes. > > Right, two separated

Re: video(1) pledge (& updated kernel diff)

2018-12-30 Thread Landry Breuil
On Sat, Dec 29, 2018 at 09:30:22AM +0100, Sebastien Marie wrote: > On Fri, Dec 28, 2018 at 09:41:06PM +0100, Landry Breuil wrote: > > Hi, > > > > so i've updated my 'video' class for pledge and also did an initial > > naive pledging of xenocara/app/video: > > just a small note: video(1) is the