Re: arm64: softraid boot

2019-01-30 Thread Patrick Wildt
On Thu, Jan 31, 2019 at 12:55:44AM +0100, Mark Kettenis wrote: > Still need to review this properly. But why is one of the properties > called openbsd,bootsr-maskkey? openbsd,bootsr-key would make more > sense. Or maybe openbsd,sr-bootuuid and openbsd,sr-bootkey? I agree, I don't like them

Re: sysctl kern.pool.XXX

2019-01-30 Thread Amit Kulkarni
> > This comment below is misleading. There are no such sysctl's. The defines > > are only used in kern/subr_pool.c > > > > ... to implement the sysctls. What are you talking about? > Ah, I see. These are not present, leading me to wonder, why are they being mentioned here?

Re: sysctl kern.pool.XXX

2019-01-30 Thread Ted Unangst
Amit Kulkarni wrote: > This comment below is misleading. There are no such sysctl's. The defines are > only used in kern/subr_pool.c > ... to implement the sysctls. What are you talking about? > > > diff --git sys/pool.h sys/pool.h > index d2f05227b7a..e97f774a272 100644 > --- sys/pool.h >

sysctl kern.pool.XXX

2019-01-30 Thread Amit Kulkarni
This comment below is misleading. There are no such sysctl's. The defines are only used in kern/subr_pool.c diff --git sys/pool.h sys/pool.h index d2f05227b7a..e97f774a272 100644 --- sys/pool.h +++ sys/pool.h @@ -34,12 +34,6 @@ #ifndef _SYS_POOL_H_ #define _SYS_POOL_H_ -/* - * sysctls. - *

Re: fork rt_ifa_{add,del} for mpls local input routes

2019-01-30 Thread David Gwynne
On Wed, Jan 30, 2019 at 11:54:45AM -0200, Martin Pieuchot wrote: > On 30/01/19(Wed) 11:48, David Gwynne wrote: > > mpls uses AF_MPLS routes with RTF_LOCAL set on them to know which tags > > are used as input for the mpe and mpw interfaces. setting this up > > currently goes through rt_ifa_add, but

tar t and broken pipes

2019-01-30 Thread Ted Unangst
I have a very large (gzipped) archive and I've forgotten exactly how the contents are structured. (is it stuff, tedu/stuff, etc.) I run tar ztf bananas.tgz | head. This prints out a few lines, and then... nothing. For a long time. head is long gone, but tar is still chugging away. Aren't

Re: Fix gdb "target kvm" on amd64

2019-01-30 Thread Todd Mortimer
On Tue, Jan 22, 2019 at 02:47:10PM +0900, YASUOKA Masahiko wrote: > Hi, > > Currently gdb "target kvm bsd.0.core" on amd64 doesn't work. It can't > read the registers and can't follow the stack frames. The diff > follows fixes those problems. > > ok? comment? Sorry for the delay getting to

Re: grep: convert fgetln to getline

2019-01-30 Thread Ted Unangst
Lauri Tirkkonen wrote: > In summary: sorry for the bug I introduced - please apply the diff above > to fix memory mapping files in grep. As for the fgetln->getline > conversion, I think this result should show that fgetln is not > particularly smart about how it's calling mmap -- getline seems

Re: athn(4): enable more calibration

2019-01-30 Thread Juan Francisco Cantero Hurtado
On Wed, Jan 30, 2019 at 05:07:37PM +0800, Kevin Lo wrote: > On Tue, Jan 29, 2019 at 09:11:42PM +0100, Stefan Sperling wrote: > > > > The diff below enables periodic ADC/IQ calibration on athn(4) devices. > > Without this calibration athn devices might perform suboptimally > > as they warm up

Re: arm64: softraid boot

2019-01-30 Thread Mark Kettenis
> Date: Wed, 30 Jan 2019 22:31:31 +0100 > From: Patrick Wildt > > Hi, > > to boot a pinebook with softraid crypto there are three parts that need > to be implemented, which this diff hopefully does well enough. > > First, our EFI bootloader so far only supports one disk, so we need to > extend

arm64: softraid boot

2019-01-30 Thread Patrick Wildt
Hi, to boot a pinebook with softraid crypto there are three parts that need to be implemented, which this diff hopefully does well enough. First, our EFI bootloader so far only supports one disk, so we need to extend this so we can see all connected block devices. The second part is adding the

Re: ASN1_get_object.3

2019-01-30 Thread Ingo Schwarze
Hi Kristaps, Kristaps Dzonsons BSD.LV wrote on Wed, Jan 30, 2019 at 12:17:16PM +0100: >> Attached is a manpage for ASN1_get_object(3), ASN1_put_object(3), and >> ASN1_put_eoc(3). > This is not complete without ASN1_object_size(), as otherwise one can't > scan over children, which is necessary

make.1: add missing dependency to example

2019-01-30 Thread Scott Cheloha
We need to tell ${CC} about b.o explicitly. ok? -Scott P.S. How was BSD $> or GNU $^ or an equivalent *not* standardized as an automatic variable? I get that it isn't a silver bullet, but in the relatively common "let's take several and make a " case it is extremely useful and totally missing

PATCH: configurable tiling for cwm(1)

2019-01-30 Thread Joe Davis
Hello @tech, cwm(1) currently implements some rudimentary tiling via the window-htile and window-vtile commands. The current behaviour is to resize the master client to half of the screen width or height. While this is a reasonable default, I find that I often want the master window to be a

Re: ASN1_get_object.3

2019-01-30 Thread Ted Unangst
Kristaps Dzonsons wrote: > > Attached is a manpage for ASN1_get_object(3), ASN1_put_object(3), and > > ASN1_put_eoc(3). Having the first function documented would have saved > > me a lot of time. (I did the others for symmetry.) > > > > In short, they encode or decode ASN.1 data structures

Re: glob(3): size_t or int?

2019-01-30 Thread Todd C . Miller
This was something I meant to fix years ago after a libc major version bump but forgot about. The use of int for gl_pathc and gl_offs is historic. This is a BSD interface and POSIX changed them to size_t when it was standardized. - todd

Re: futex(2) based pthread_rwlock*

2019-01-30 Thread Paul Irofti
On Wed, Jan 30, 2019 at 12:29:20PM -0200, Martin Pieuchot wrote: > On 28/01/19(Mon) 14:57, Martin Pieuchot wrote: > > Summer is really warm here. No need to make my machines hotter by > > spinning a lot. So here's a futex(2) based pthread_rwlock* > > implementation. I should look familiar to

Re: futex(2) based pthread_rwlock*

2019-01-30 Thread Martin Pieuchot
On 28/01/19(Mon) 14:57, Martin Pieuchot wrote: > Summer is really warm here. No need to make my machines hotter by > spinning a lot. So here's a futex(2) based pthread_rwlock* > implementation. I should look familiar to those of you that reviewed > the mutex & semaphore implementations. It

Re: fork rt_ifa_{add,del} for mpls local input routes

2019-01-30 Thread Martin Pieuchot
On 30/01/19(Wed) 11:48, David Gwynne wrote: > mpls uses AF_MPLS routes with RTF_LOCAL set on them to know which tags > are used as input for the mpe and mpw interfaces. setting this up > currently goes through rt_ifa_add, but that has a couple of features > that are undesirable for mpls. > >

glob(3): size_t or int?

2019-01-30 Thread Stephen Gregoratto
Apologies if this was brought up before, I tried searching through marc and couldn't find any related threads. Backstory: I was working on building mrsh[1], a POSIX compliant shell on OpenBSD, and had build errors regarding the types used to implement glob_t. Basically, POSIX.2 states that the

unwind: make dhcp lease parsing more robust

2019-01-30 Thread Sebastian Benoit
I had a box that was installed in 2012 and got a dhcp lease: $ cat /var/db/dhclient.leases.em0 lease { interface "em0"; fixed-address 172.16.1.5; filename "openbsd.0"; option subnet-mask 255.255.255.0; option routers 172.16.1.1; option

unwind: verify forwarder ip addresses

2019-01-30 Thread Sebastian Benoit
check that ips in the forwarder {} sections are indeed ips. ok? diff --git sbin/unwind/uw_parse.y sbin/unwind/uw_parse.y index 6b23fa3972b..82ac1f1b401 100644 --- sbin/unwind/uw_parse.y +++ sbin/unwind/uw_parse.y @@ -24,6 +24,7 @@ %{ #include +#include #include #include @@ -31,6

unwind: cleanup some includes

2019-01-30 Thread Sebastian Benoit
remove not needed includes in uw_parse.y add some to unwind.h clean up some whitespace. ok? (benno_unwind_clean_include_parser.diff) diff --git sbin/unwind/unwind.h sbin/unwind/unwind.h index 887db4b46ab..e2cbdc2d1b0 100644 --- sbin/unwind/unwind.h +++ sbin/unwind/unwind.h @@ -18,6 +18,11 @@

Re: athn(4): enable more calibration

2019-01-30 Thread Jonathan Matthew
On Tue, Jan 29, 2019 at 09:11:42PM +0100, Stefan Sperling wrote: > The diff below enables periodic ADC/IQ calibration on athn(4) devices. > Without this calibration athn devices might perform suboptimally > as they warm up during operation. > > The code is already there, it was just not being

Re: ASN1_get_object.3

2019-01-30 Thread Kristaps Dzonsons
> Attached is a manpage for ASN1_get_object(3), ASN1_put_object(3), and > ASN1_put_eoc(3). Having the first function documented would have saved > me a lot of time. (I did the others for symmetry.) > > In short, they encode or decode ASN.1 data structures from/into a > buffer. Using the first,

Re: archaic quotes in calendar

2019-01-30 Thread Anthony J. Bentley
Jason McIntyre writes: > in the man page you have used Sq. that will make it mark up the same as > it already does: > > (`*') There's a difference: Ted uses a UTF-8 locale where Sq shows up as pretty Unicode quotes. Literally typing `' doesn't (not in the terminal, anyway). mandoc should

ASN1_get_object.3

2019-01-30 Thread Kristaps Dzonsons
Attached is a manpage for ASN1_get_object(3), ASN1_put_object(3), and ASN1_put_eoc(3). Having the first function documented would have saved me a lot of time. (I did the others for symmetry.) In short, they encode or decode ASN.1 data structures from/into a buffer. Using the first, one can

Re: archaic quotes in calendar

2019-01-30 Thread Jason McIntyre
On Tue, Jan 29, 2019 at 03:58:49PM -0500, Ted Unangst wrote: > Run calendar without a calendar file. > hi. > calendar: no calendar file: ``calendar'' or ``~/.calendar/calendar'' > > I think these fake double quotes are really ugly. It's been a long time since > the typical font rendered them

Re: athn(4): enable more calibration

2019-01-30 Thread Kevin Lo
On Tue, Jan 29, 2019 at 09:11:42PM +0100, Stefan Sperling wrote: > > The diff below enables periodic ADC/IQ calibration on athn(4) devices. > Without this calibration athn devices might perform suboptimally > as they warm up during operation. > > The code is already there, it was just not being