libevent: endless loop on excessively large buffers

2019-05-02 Thread Tobias Stoeckmann
It is possible to trigger an endless loop or out of boundary write on 64 bit systems with evbuffer_readline calls for buffers which exceed 4 GB (i.e. overflow uint). for (i = 0; i < len; i++) Variable i is unsigned int and len size_t. This leads to an endless loop if len is larger than

Re: httpd: New log format to log X-Forwarded-{For|Port} headers

2019-05-02 Thread Bruno Flückiger
On 03.05., Theo Buehler wrote: > On Fri, Mar 08, 2019 at 10:52:28AM +0100, Reyk Floeter wrote: > > Hi, > > > > On Mon, Mar 04, 2019 at 02:06:02PM +0100, Bruno Flueckiger wrote: > > > I've completely reworked my patch for httpd(8). The last patch broke the > > > log format combined. And the config

Re: httpd: New log format to log X-Forwarded-{For|Port} headers

2019-05-02 Thread Mischa Peters
> On 3 May 2019, at 04:59, Theo Buehler wrote: > >> On Fri, Mar 08, 2019 at 10:52:28AM +0100, Reyk Floeter wrote: >> Hi, >> >>> On Mon, Mar 04, 2019 at 02:06:02PM +0100, Bruno Flueckiger wrote: >>> I've completely reworked my patch for httpd(8). The last patch broke the >>> log format

Re: perldoc: fix man output & formatting

2019-05-02 Thread Andrew Hewus Fresh
On Fri, May 03, 2019 at 04:27:15AM +0200, Ingo Schwarze wrote: > Hi Todd & Andrew, > > Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700: > > On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: > >> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: > > >>> I

Re: kqueue.2: formatting fixes and minor HISTORY expansion

2019-05-02 Thread Ingo Schwarze
Hi Fabio, Fabio Scotoni wrote on Thu, May 02, 2019 at 03:33:42PM +0200: > I've taken a stab at improving kqueue.2 formatting. > Most of the changes are markup fixes. All your formatting decisions are good. > I used ".Dv NULL" over plain "null" in accordance with > lib/libc/stdlib/malloc.3 rev.

Re: perldoc: fix man output & formatting

2019-05-02 Thread Ingo Schwarze
Hi Andrew, Andrew Daugherity wrote on Thu, May 02, 2019 at 10:53:37AM -0500: > Also, their ToMan patch has a previously-included hunk > for MANWIDTH=tty, All that does is suppress a warning message "non-numeric MANWIDTH" when a user has MANWIDTH=tty in their environment. No idea why any user

Re: httpd: New log format to log X-Forwarded-{For|Port} headers

2019-05-02 Thread Theo Buehler
On Fri, Mar 08, 2019 at 10:52:28AM +0100, Reyk Floeter wrote: > Hi, > > On Mon, Mar 04, 2019 at 02:06:02PM +0100, Bruno Flueckiger wrote: > > I've completely reworked my patch for httpd(8). The last patch broke the > > log format combined. And the config option was ugly. This time I've > > added

Re: perldoc: fix man output & formatting

2019-05-02 Thread Ingo Schwarze
Hi Todd & Andrew, Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700: > On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: >> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: >>> I reported this to FreeBSD ports a couple months ago [2], and they >>> provided a

Re: httpd: avoid opening log files on "no log"

2019-05-02 Thread Solene Rapenne
On Thu, May 02, 2019 at 10:36:29PM +0200, Klemens Nanni wrote: > httpd(8) still creates/opens log files with `no log' in httpd.conf(5): > > [no] log [option] > Set the specified logging options. Logging is enabled by default > using the standard access and error

httpd: avoid opening log files on "no log"

2019-05-02 Thread Klemens Nanni
httpd(8) still creates/opens log files with `no log' in httpd.conf(5): [no] log [option] Set the specified logging options. Logging is enabled by default using the standard access and error log files, but can be changed per server or location. Use

Re: libevent: endless loop on excessively large buffers

2019-05-02 Thread Nicholas Marriott
ok nicm On Thu, May 02, 2019 at 06:59:33PM +0200, Tobias Stöckmann wrote: > It is possible to trigger an endless loop or out of boundary write > on 64 bit systems with evbuffer_readline calls for buffers which > exceed 4 GB (i.e. overflow uint). > > for (i = 0; i < len; i++) > >

Re: libevent: endless loop on excessively large buffers

2019-05-02 Thread Ted Unangst
Tobias Stöckmann wrote: > Generally this is a rather theoretical case. Normal users are not > allowed to allocate so much memory. But better be safe than sorry, > especially if login.conf values were adjusted (or the process runs > as root). > > This patch completely removes "unsigned int" from

libevent: endless loop on excessively large buffers

2019-05-02 Thread Tobias Stöckmann
It is possible to trigger an endless loop or out of boundary write on 64 bit systems with evbuffer_readline calls for buffers which exceed 4 GB (i.e. overflow uint). for (i = 0; i < len; i++) Variable i is unsigned int and len size_t. This leads to an endless loop if len is larger than

Re: perldoc: fix man output & formatting

2019-05-02 Thread Andrew Hewus Fresh
On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: > On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: > > > I reported this to FreeBSD ports a couple months ago [2], and they > > provided a fix [3] which repairs the -oMan output, and makes that the > > default. Their fix

Re: perldoc: fix man output & formatting

2019-05-02 Thread Todd C . Miller
On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: > I reported this to FreeBSD ports a couple months ago [2], and they > provided a fix [3] which repairs the -oMan output, and makes that the > default. Their fix applies cleanly to the OpenBSD tree and works, but > I have no idea why

perldoc: fix man output & formatting

2019-05-02 Thread Andrew Daugherity
After upgrading to 6.5 and thus perl 5.28, the man pages displayed by perldoc (e.g. 'perldoc Digest') or via Perl scripts making use of pod2usage lack formatting such as bold and underlining. In fact, text which used to be underlined is now wrapped in *asterisks* (bold text is just displayed as

kqueue.2: formatting fixes and minor HISTORY expansion

2019-05-02 Thread Fabio Scotoni
I've taken a stab at improving kqueue.2 formatting. Most of the changes are markup fixes. I used ".Dv NULL" over plain "null" in accordance with lib/libc/stdlib/malloc.3 rev. 1.113. I also added a note to the HISTORY section that kqueue()/kevent() have been available in OpenBSD since 2.9; the

Re: patch axen(4) (WIP)

2019-05-02 Thread Nils Frohberg
Any there further interest in these patches? I was running these since 61 days, doing lots of rsync and TimeMachine (netatalk) backups. Didn't have any crashes or (noticeable) network dropouts. $ uptime 11:05AM up 61 days, 16:54, 1 user, load averages: 0.35, 0.38, 0.38 $ On Thu, Feb 28, 2019