Re: [Patch] Driver for Keyspan USA-19HS

2019-06-03 Thread Cody Cutler
Hi jcs and tech, the following is a patch which implements jcs's feedback and adds a man page. Note that one must execute `make -C sys/dev/usb' after applying to build. Thanks! diff --git share/man/man4/Makefile share/man/man4/Makefile index 7d470b6ca47..999621c7889 100644 ---

pfsync_sendout() requires PF_LOCK()

2019-06-03 Thread Alexandr Nedvedicky
Hello, this is yet another fall out from my experiments. It has turned out my initial change introduced some time ago [1] omits pfsyncintr() and pfsync_sendout(). Both functions call pfsync_sendout(), which currently requires protection of PF_LOCK(). Without change below the test box was dying

pf_state_key_link_reverse() needs atomic ops

2019-06-03 Thread Alexandr Nedvedicky
Hello, I've managed to get pf_test() running in parallel on forwarding path in my experimental tree. And there was some fall out. PF died on ASSERT() in pf_state_key_link_reverse() at line 7371: 7368 pf_state_key_link_reverse(struct pf_state_key *sk, ...) 7369 { 7370 /* Note

if_netisr(): trade NET_LOCK() for NET_RLOCK()

2019-06-03 Thread Alexandr Nedvedicky
Hello, diff below is just cosmetic change, which has no impact on current functionality, because there is just single network task to deliver packets to IP stack. I just want to push this small change to tree to minimize delta between current and my experimental branch. OK? thanks and regards

[patch] rsync: fix free() on uninitialized pointer with -rx and same device

2019-06-03 Thread Hiltjo Posthuma
Hi, I noticed a free() issue on an uninitialized pointer on a certain condition. To reproduce: mkdir -p /tmp/test /tmp/plop openrsync -rx /tmp/test/ /tmp/plop/ Result: openrsync(3470) in free(): bogus pointer (double free?) 0x7f7dcdc8 Abort trap (core

Re: [patch] rsync: fix another double close socket descriptor

2019-06-03 Thread Christian Weisgerber
On 2019-06-02, Hiltjo Posthuma wrote: > I noticed when using openrsync with a remote and a ssh_prog set (-e option) > the > socket is closed twice also. Yes, we need to decide whether rsync_socket() should close the socket itself or not. Since rsync_socket() doesn't open the socket, I guess

bfd: respond to poll sequence from peer

2019-06-03 Thread Mitchell Krome
Hi, Testing bfd against frr on linux, their bfd implementation sends polls as soon as the session is up even if the session timers haven't changed from what it was advertising while it was in the down state. Currently openbsd bfd doesn't respond to polls, so this diff adds that support. tcpdump

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-03 Thread Renaud Allard
On 6/3/19 11:18 AM, Renaud Allard wrote: On 5/29/19 10:19 AM, Renaud Allard wrote: On 5/29/19 9:58 AM, Florian Obser wrote: On Wed, May 22, 2019 at 01:33:11PM +0200, Renaud Allard wrote: The key needs to be generated manually i.e.: openssl ecparam -genkey -name secp384r1 -out

Re: Pump my sched: fewer SCHED_LOCK() & kill p_priority

2019-06-03 Thread Solene Rapenne
On Sat, Jun 01, 2019 at 06:55:20PM -0300, Martin Pieuchot wrote: > Diff below exists mainly for documentation and test purposes. If > you're not interested about how to break the scheduler internals in > pieces, don't read further and go straight to testing! I'm running it since a few hours. -

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-03 Thread Renaud Allard
On 5/29/19 10:19 AM, Renaud Allard wrote: On 5/29/19 9:58 AM, Florian Obser wrote: On Wed, May 22, 2019 at 01:33:11PM +0200, Renaud Allard wrote: The key needs to be generated manually i.e.: openssl ecparam -genkey -name secp384r1 -out privkey.pem why not let acme-client generate the

Re: Pump my sched: fewer SCHED_LOCK() & kill p_priority

2019-06-03 Thread Amit Kulkarni
Hi, This is pretty cool diff in splitting the sleep prio and the run prio! In a few places, the documentation comment could be changed from process to proc, tried to find it below and mark. It leaves reader confused for a moment. thanks > > - `spc_curpriority' is now updated at every