OpenBSD perl 5.30.0 - Call for Testing

2019-07-24 Thread Andrew Hewus Fresh
I've updated our patches for perl 5.30.0 and I'd like to get some other folks to kick the tyres. I doubt it's quite ready to become system perl just yet, but I have been running it on a test machine for a while now. This summer has been surprisingly good at keeping me from spending much time on

itimerdecr(): simplify code

2019-07-24 Thread Scott Cheloha
We can simplify the itimerdecr() code with the sys/time.h macros. I think this is a lot easier to decipher. With the macros we don't need special logic to correctly handle the reload if the decrement exceeds the time remaining in the itimer. With the loop we now correctly handle decrements

Re: unveil in process accounting and lastcomm

2019-07-24 Thread Theo de Raadt
I have worried about secret unveil failures, and I am happy with this approach. Alexander Bluhm wrote: > On Thu, Jul 18, 2019 at 04:13:10PM +0200, Alexander Bluhm wrote: > > Hi, > > > > Can we track unveil(2) violators in process accounting lastcomm(1)? > > This makes it easier to find them. >

Re: unveil in process accounting and lastcomm

2019-07-24 Thread Alexander Bluhm
On Thu, Jul 18, 2019 at 04:13:10PM +0200, Alexander Bluhm wrote: > Hi, > > Can we track unveil(2) violators in process accounting lastcomm(1)? > This makes it easier to find them. Could I put that in? Process accounting is cheap and does not hurt. I have added it localy to my daily mail like

Re: apmd: fix error message

2019-07-24 Thread Alexander Bluhm
On Wed, Jul 24, 2019 at 09:25:57PM +0200, Klemens Nanni wrote: > This snuck through > > revision 1.84 > date: 2018/12/04 18:00:57; author: tedu; state: Exp; lines: +44 -30; > redo the debug logging to be more like everything else. > ok kn > > Where the direct syslog(3)

Re: smtpd: default to standard ports in relay-host

2019-07-24 Thread Klemens Nanni
On Wed, Jul 24, 2019 at 10:21:18PM +0200, Gilles Chehade wrote: > This becomes unnecessary with your diff since you assign port to 0 > for lmtp:// already. I left it intentionally to keep the diff simple, but sure; will commit with that check removed, thanks.

Re: smtpd: default to standard ports in relay-host

2019-07-24 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 12:15:26PM +0200, Klemens Nanni wrote: > On Tue, Jul 23, 2019 at 11:00:04AM +0200, Gilles Chehade wrote: > > there is no schema today that should default to 587, unless > > submission:// is introduced as an alias to smtp+tls AND port 587. > Alright; this way we guarantee

Re: apmd: use unveil(2)

2019-07-24 Thread Theo de Raadt
Klemens Nanni wrote: > Pledge is not possible due to the ioctls, but as it hoists both the > control socket and apm device early at startup and only ever possibly > executes scripts under /etc/apm/, hiding the rest of the filesystem > becomes easy. > > Technically, only "x" is required to

apmd: use unveil(2)

2019-07-24 Thread Klemens Nanni
Pledge is not possible due to the ioctls, but as it hoists both the control socket and apm device early at startup and only ever possibly executes scripts under /etc/apm/, hiding the rest of the filesystem becomes easy. Technically, only "x" is required to traverse the directory and run scripts,

apmd: fix error message

2019-07-24 Thread Klemens Nanni
This snuck through revision 1.84 date: 2018/12/04 18:00:57; author: tedu; state: Exp; lines: +44 -30; redo the debug logging to be more like everything else. ok kn Where the direct syslog(3) call was replaced with a logmsg() wrapper which uses printf(2) in case

Re: remove BUGS section from spamd(8)

2019-07-24 Thread Todd C . Miller
On Wed, 24 Jul 2019 15:52:57 +0100, Ricardo Mestre wrote: > That being said then in my opinion I think that the BUGS section should be > removed from the manpage, because even if the processes are running with the > same user the concern here doesn't apply anymore. Makes sense. OK millert@ -

remove BUGS section from spamd(8)

2019-07-24 Thread Ricardo Mestre
Hi, Ever since I introduced pledge(2) on spamd(8) the chroot'ed process, if running in default, cannot get anywhere near the filesystem since its only promises are "stdio inet". Furthermore, in blacklist mode this same codepath is not chroot'ed but once again it gets the same pledge(2). That

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-24 Thread Klemens Nanni
On Wed, Jul 24, 2019 at 09:28:26AM -0400, Kurt Mosiejczuk wrote: > Here's a diff that does that. Thanks, OK kn.

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-24 Thread Ingo Schwarze
Hi Kurt, Kurt Mosiejczuk wrote on Wed, Jul 24, 2019 at 09:28:26AM -0400: > On Wed, Jul 24, 2019 at 02:17:47PM +0200, Klemens Nanni wrote: >> On Wed, Jul 24, 2019 at 01:32:52PM +0200, Gilles Chehade wrote: >>> Well I think we should remove the reserved keywords as suggested by Kurt >>> but keep

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-24 Thread Theo de Raadt
Yep, this keeps the quotes around the labels, and shows how the labels would be used in a real configuration. the ambiguity is gone. Imagine if other example files had stuff like table "table" something "something" Kurt Mosiejczuk wrote: > On Wed, Jul 24, 2019 at 02:17:47PM

Add #include to ksh/io.c

2019-07-24 Thread Brian Callahan
Hi tech -- ksh/io.c uses mkstemp but does not include stdlib.h. It has been getting by with the legacy definition in unistd.h Originally spotted by m...@netbsd.org OK? ~Brian Index: io.c === RCS file: /cvs/src/bin/ksh/io.c,v

bgpd fix for possible RIB entry leak

2019-07-24 Thread Claudio Jeker
When terminating or aborting a RIB dump the system needs to unlock and cleanup any rib entry or prefix which was locked. This happens for example when running `bgpctl show rib | head`. This will abort the rib_dump run and leave a locked rib entry behind. Since locked entries are not removed from

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-24 Thread Klemens Nanni
On Wed, Jul 24, 2019 at 01:32:52PM +0200, Gilles Chehade wrote: > Well I think we should remove the reserved keywords as suggested by Kurt > but keep the quotes in all examples to make it very explicit that we are > expecting a string literal at this point. I concur.

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-24 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 08:51:38PM +0200, Ingo Schwarze wrote: > Hi Gilles, > > Gilles Chehade wrote on Tue, Jul 23, 2019 at 08:27:06AM +0200: > > On Mon, Jul 22, 2019 at 05:05:01PM -0400, Kurt Mosiejczuk wrote: > > >> This is a diff for that changes the example smtpd.conf and smtpd.conf.5 > >>

Re: smtpd: Allow labels containing "@"

2019-07-24 Thread Gilles Chehade
On Wed, Jul 24, 2019 at 12:18:05AM +0200, Klemens Nanni wrote: > On Tue, Jul 23, 2019 at 09:06:33AM +0200, Gilles Chehade wrote: > > On Tue, Jul 23, 2019 at 08:51:54AM +0200, Sebastien Marie wrote: > > > it seems to me this url is wrong. the '@' in username should be > > > urlencoded. > > > > >

Re: smtpd: Allow labels containing "@"

2019-07-24 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 10:20:10PM +0200, Sebastian Benoit wrote: > Gilles Chehade(gil...@poolp.org) on 2019.07.23 09:06:33 +0200: > > On Tue, Jul 23, 2019 at 08:51:54AM +0200, Sebastien Marie wrote: > > > On Mon, Jul 22, 2019 at 11:26:28PM +0200, Klemens Nanni wrote: > > > > My mail is

shrink ifconfig trunkport output a bit

2019-07-24 Thread David Gwynne
this makes ifconfig output for a trunk/aggr look a bit smaller: this is before the change: aggr0: flags=8943 mtu 9000 lladdr bc:2c:55:9e:34:cb index 7 priority 0 llprio 7 trunk: trunkproto lacp trunk id: [(8000,bc:2c:55:9e:34:cb,0007,,),