Re: iked(8): fix some leaks in parse.y

2019-09-25 Thread Alexander Bluhm
On Wed, Sep 25, 2019 at 10:34:53PM +0200, Tobias Heider wrote: > Thanks, makes sense. Not sure how I didn't think of this. > Here is a cleaned up version: OK bluhm@ > Index: parse.y > === > RCS file: /cvs/src/sbin/iked/parse.y,v >

Re: iked(8): improve logging output

2019-09-25 Thread Alexander Bluhm
On Wed, Sep 25, 2019 at 10:45:50PM +0200, Tobias Heider wrote: > ok? > > @@ -4084,8 +4094,8 @@ ikev2_send_informational(struct iked *en > case IKEV2_N_NO_PROPOSAL_CHOSEN: > break; > default: > - log_debug("%s: unsupported notification %s", __func__, > -

Re: pretty borders for slitherins

2019-09-25 Thread Scott Cheloha
On Wed, Sep 25, 2019 at 08:29:47PM +0100, Nicholas Marriott wrote: > It will use either UTF-8 characters or the ACS characters from TERM. > > The way it decides which is somewhat confusing and it looks like it is > choosing to use UTF-8 even when I wouldn't expect it to so I'm not sure > it is

iked(8): improve logging output

2019-09-25 Thread Tobias Heider
A recent commit added the macro SPI_SA which is used to prepend log lines with "spi=0x.." as seen in the message receive and send output. This diff updates the rest of the ikev2.c file to use the new macro. Because I was already fiddling with logging I changed some log_debugs to log_info. Most of

Re: iked(8): fix some leaks in parse.y

2019-09-25 Thread Tobias Heider
> Your fix reads ok, but: > > please write null-pointer checks explicitly, i.e. != NULL or == NULL. Sure. > and a suggestion: how about putting a > > if (head == NULL) > return; > > at the top of iaw_free(), so it works like free()? > > Then you can skip the if (...) infront of all the

Re: new USB audio class v2.0 driver

2019-09-25 Thread Alexandre Ratchov
On Wed, Sep 25, 2019 at 08:39:10PM +0100, cho...@jtan.com wrote: > Alexandre Ratchov writes: > > On Wed, Sep 25, 2019 at 05:15:22PM +0100, cho...@jtan.com wrote: > > > I have a similar problem to Alexander Hof with a presonus audio usb > > > device, where attaching it reports 'only one AC iface

Re: new USB audio class v2.0 driver

2019-09-25 Thread Alexandre Ratchov
On Wed, Sep 25, 2019 at 08:13:09PM +0100, cho...@jtan.com wrote: > Alexandre Ratchov writes: > > On Wed, Sep 25, 2019 at 05:15:22PM +0100, cho...@jtan.com wrote: > > > I have a similar problem to Alexander Hof with a presonus audio usb > > > device, where attaching it reports 'only one AC iface

Re: iked(8): fix some leaks in parse.y

2019-09-25 Thread Sebastian Benoit
Tobias Heider(tobias.hei...@stusta.de) on 2019.09.25 21:29:44 +0200: > As the subject says this diff fixes a few leaks in the config parser. Your fix reads ok, but: please write null-pointer checks explicitly, i.e. != NULL or == NULL. and a suggestion: how about putting a if (head == NULL)

Re: new USB audio class v2.0 driver

2019-09-25 Thread chohag
Alexandre Ratchov writes: > On Wed, Sep 25, 2019 at 05:15:22PM +0100, cho...@jtan.com wrote: > > I have a similar problem to Alexander Hof with a presonus audio usb > > device, where attaching it reports 'only one AC iface allowed' and the > > device remains (apparently totally) inaccessible. > >

Re: pretty borders for slitherins

2019-09-25 Thread Nicholas Marriott
It will use either UTF-8 characters or the ACS characters from TERM. The way it decides which is somewhat confusing and it looks like it is choosing to use UTF-8 even when I wouldn't expect it to so I'm not sure it is actually working correctly in our ncurses version. I don't think UTF-8 line

iked(8): fix some leaks in parse.y

2019-09-25 Thread Tobias Heider
As the subject says this diff fixes a few leaks in the config parser. ok? Index: parse.y === RCS file: /cvs/src/sbin/iked/parse.y,v retrieving revision 1.83 diff -u -p -u -r1.83 parse.y --- parse.y 26 Aug 2019 16:41:08 -

Re: new USB audio class v2.0 driver

2019-09-25 Thread Alexandre Ratchov
On Wed, Sep 25, 2019 at 05:15:22PM +0100, cho...@jtan.com wrote: > I have a similar problem to Alexander Hof with a presonus audio usb > device, where attaching it reports 'only one AC iface allowed' and the > device remains (apparently totally) inaccessible. > > dmes and lsusb included below. >

Re: pretty borders for slitherins

2019-09-25 Thread Mike Larkin
On Wed, Sep 25, 2019 at 10:53:21AM -0600, Theo de Raadt wrote: > Ted Unangst wrote: > > > Scott Cheloha wrote: > > > On Mon, Sep 23, 2019 at 06:23:32PM -0400, Ted Unangst wrote: > > > > snake and worm draw boxes, but they can be prettier by using the default > > > > style, which will use line

Re: pretty borders for slitherins

2019-09-25 Thread Theo de Raadt
Ted Unangst wrote: > Scott Cheloha wrote: > > On Mon, Sep 23, 2019 at 06:23:32PM -0400, Ted Unangst wrote: > > > snake and worm draw boxes, but they can be prettier by using the default > > > style, which will use line drawing instead of ugly -*| characters. > > > > > > should do the right

Re: pretty borders for slitherins

2019-09-25 Thread Ted Unangst
Scott Cheloha wrote: > On Mon, Sep 23, 2019 at 06:23:32PM -0400, Ted Unangst wrote: > > snake and worm draw boxes, but they can be prettier by using the default > > style, which will use line drawing instead of ugly -*| characters. > > > > should do the right thing on a vt100, but only tested in

Fix libcompiler_rt __clear_cache() on armv7

2019-09-25 Thread Josh Elsasser
I came across some code which uses __clear_cache() from libgcc/libcompiler_rt on 32-bit arm. Currently that just falls through to abort(), but enabling the existing sysarch() code works for me. diff --git a/lib/libcompiler_rt/clear_cache.c b/lib/libcompiler_rt/clear_cache.c index

Re: new USB audio class v2.0 driver

2019-09-25 Thread chohag
I have a similar problem to Alexander Hof with a presonus audio usb device, where attaching it reports 'only one AC iface allowed' and the device remains (apparently totally) inaccessible. dmes and lsusb included below. The device and the box it plugs into are both available for prodding and

Re: pretty borders for slitherins

2019-09-25 Thread Scott Cheloha
On Mon, Sep 23, 2019 at 06:23:32PM -0400, Ted Unangst wrote: > snake and worm draw boxes, but they can be prettier by using the default > style, which will use line drawing instead of ugly -*| characters. > > should do the right thing on a vt100, but only tested in xterm. It looks much prettier

Re: bgpctl sh nei [group XX] terse: add peer address

2019-09-25 Thread Claudio Jeker
On Wed, Sep 25, 2019 at 12:19:23PM +0100, Stuart Henderson wrote: > On 2019/09/24 22:06, Sebastian Benoit wrote: > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.09.24 17:01:21 +0200: > > > On Tue, Sep 24, 2019 at 03:51:43PM +0100, Stuart Henderson wrote: > > > > On 2019/09/24 11:10, Claudio

smtpd: mail.* tempfail vs permfail

2019-09-25 Thread Martijn van Duren
EHLO, Recently I moved my mailserver to a new HD resulting in temporary inaccessibility of my maildir (temporarily root owned because of recursive copy), leaving smtpd running thinking nothing of it. This resulted in a few mails being PERMFAIL. I talked to gilles@ about this and he's somewhat

Re: bgpctl sh nei [group XX] terse: add peer address

2019-09-25 Thread Stuart Henderson
On 2019/09/24 22:06, Sebastian Benoit wrote: > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.09.24 17:01:21 +0200: > > On Tue, Sep 24, 2019 at 03:51:43PM +0100, Stuart Henderson wrote: > > > On 2019/09/24 11:10, Claudio Jeker wrote: > > > > On Tue, Sep 24, 2019 at 10:06:51AM +0100, Stuart

Re: Argument order fix for MCLGETI

2019-09-25 Thread Stuart Henderson
On 2019/09/25 10:22, Claudio Jeker wrote: > On Wed, Sep 25, 2019 at 04:10:10PM +0800, Kevin Lo wrote: > > ok? > > OK claudio@ > > How did that even work? /me adds ti, lge, nfe, nge to a list for next time the kernel grows too much ;-)

Re: Argument order fix for MCLGETI

2019-09-25 Thread Claudio Jeker
On Wed, Sep 25, 2019 at 04:10:10PM +0800, Kevin Lo wrote: > ok? OK claudio@ How did that even work? > Index: sys/dev/ic/ti.c > === > RCS file: /cvs/src/sys/dev/ic/ti.c,v > retrieving revision 1.25 > diff -u -p -u -p -r1.25 ti.c >

Argument order fix for MCLGETI

2019-09-25 Thread Kevin Lo
ok? Index: sys/dev/ic/ti.c === RCS file: /cvs/src/sys/dev/ic/ti.c,v retrieving revision 1.25 diff -u -p -u -p -r1.25 ti.c --- sys/dev/ic/ti.c 22 Jan 2017 10:17:38 - 1.25 +++ sys/dev/ic/ti.c 25 Sep 2019 08:06:26 -

Re: snmpd allow walk on agentx [1/2]

2019-09-25 Thread Martijn van Duren
On 9/25/19 8:55 AM, Martijn van Duren wrote: > Hello, > > Mischa found that relayd's agentx support is pretty much unusable for > the uninitiated, because you have to know the tables beforehand. > > I managed to track it down to two issue with both snmpd and relayd. > The fix is far from proper

snmpd allow walk on agentx [1/2]

2019-09-25 Thread Martijn van Duren
Hello, Mischa found that relayd's agentx support is pretty much unusable for the uninitiated, because you have to know the tables beforehand. I managed to track it down to two issue with both snmpd and relayd. The fix is far from proper support for agentx, but it's good enough for going on a