Re: Add -R alias to -r for scp(1)

2020-02-09 Thread Jan Stary
On Jan 02 11:30:35, es...@nerim.net wrote: > Once in three times, I type scp -R and go "oh fuck" when it doesn't work. Same here with 'ssh -p' vs 'scp -P'.

Re: [PATCH] Fixing an uninitialized variable that can lead to #GP.

2020-02-09 Thread Jonathan Gray
On Sun, Feb 09, 2020 at 06:17:47PM -0800, Anthony Steinhauser wrote: > In the current implementation of the TAA mitigation if the cpuid_level > is 6 and it's an Intel CPU, the sefflags_edx variable is used without > being initialized. If the SEFF0EDX_ARCH_CAP bit is accidentally flipped > in it,

Re: [PATCH] Fixing an uninitialized variable that can lead to #GP.

2020-02-09 Thread Mike Larkin
On Sun, Feb 09, 2020 at 06:17:47PM -0800, Anthony Steinhauser wrote: > In the current implementation of the TAA mitigation if the cpuid_level > is 6 and it's an Intel CPU, the sefflags_edx variable is used without > being initialized. If the SEFF0EDX_ARCH_CAP bit is accidentally flipped > in it,

[PATCH] Fixing an uninitialized variable that can lead to #GP.

2020-02-09 Thread Anthony Steinhauser
In the current implementation of the TAA mitigation if the cpuid_level is 6 and it's an Intel CPU, the sefflags_edx variable is used without being initialized. If the SEFF0EDX_ARCH_CAP bit is accidentally flipped in it, the rdmsr on the unimplemented MSR_ARCH_CAPABILITIES index leads to a #GP

Re: Add mprotect_ept ioctl to vmm(4)

2020-02-09 Thread Adam Steen
On Fri, Feb 07, 2020 at 04:38:16PM -0800, Mike Larkin wrote: > > On Fri, Feb 07, 2020 at 01:25:38PM -0800, Mike Larkin wrote: > > On Fri, Feb 07, 2020 at 04:20:16AM +, Adam Steen wrote: > > > Hi > > > > > > Please see the attached patch to add an 'IOCTL handler to sets the access > > >

Re: remove needless #ifdef

2020-02-09 Thread YASUOKA Masahiko
Hi, On Sun, 09 Feb 2020 19:28:50 +0100 Jeremie Courreges-Anglas wrote: > On Sun, Feb 09 2020, Jan Stary wrote: >> Currently, sys/net/pipex_local.h asks #ifdef __OpenBSD__ >> and if so, defines "Static" to be nothing, to use it later. >> That can go away, right? > > I believe that's something

Re: extern already declared

2020-02-09 Thread Todd C . Miller
On Sun, 09 Feb 2020 19:05:28 +0100, Jan Stary wrote: > But the externs should be mentioned in the manpage, right? > That's the only place they are mentioned before being talked about > in the text; although I suspect that's why people keep declaring them > in source code - it's what SYNOPSIS

remove the 'support' for troff fonts in lp[rd]

2020-02-09 Thread Jan Stary
(Replying to an old thread) On Jan 28 12:06:42, chrisbenn...@bennettconstruction.us wrote: > #define _PATH_VFONT "/usr/libdata/vfont/" > #define _PATH_VFONTB"/usr/libdata/vfont/B" > #define _PATH_VFONTI"/usr/libdata/vfont/I" > #define

Re: syslogd closing all udp is a tiny bit aggressiv

2020-02-09 Thread Alexander Bluhm
On Thu, Feb 06, 2020 at 05:57:15PM -0500, sven falempin wrote: > > Your DNS lookup fails at startup, sockets are closed. > > Later at SIGHUP you DNS works again. Now the sockets are needed. > > So do not close them if DNS for udp fails. I thought again about this problem. The fix can be more

Re: locate.updatedb TMPDIR

2020-02-09 Thread Joerg Jung
On Sun, Feb 09, 2020 at 04:33:13PM +0100, Ingo Schwarze wrote: > > this is absolutely not OK. > > How did you test this? I changed weekly directly on the remote machine to detect and narrow down the issue and generated the diff later on my local machine source tree. >$ doas cat

Re: locate.updatedb TMPDIR

2020-02-09 Thread Joerg Jung
On Sun, Feb 09, 2020 at 04:18:52PM +0100, Ingo Schwarze wrote: > Hi Todd, > > Todd C. Miller wrote on Sun, Feb 09, 2020 at 07:52:10AM -0700: > > > I'm fine with this. > > I don't really object, but i'm not sure it is needed either. > > It's certainly obvious that command line arguments

Re: Audio control API, part 2: add new sndioctl(1) utility

2020-02-09 Thread Alexandre Ratchov
On Sun, Feb 09, 2020 at 07:20:15PM +0100, Landry Breuil wrote: > On Sun, Feb 09, 2020 at 01:14:47PM +0100, Alexandre Ratchov wrote: > > Here's a new sndioctl utility similar to mixerctl(1) but using the new > > sndio API. Example: > > > > $ sndioctl

Re: remove needless #ifdef

2020-02-09 Thread Jeremie Courreges-Anglas
On Sun, Feb 09 2020, Jan Stary wrote: > Currently, sys/net/pipex_local.h asks #ifdef __OpenBSD__ > and if so, defines "Static" to be nothing, to use it later. > That can go away, right? I believe that's something the IIJ folks want to keep, cc'ing Yasuoka. > Jan > > > Index:

Re: Audio control API, part 2: add new sndioctl(1) utility

2020-02-09 Thread Landry Breuil
On Sun, Feb 09, 2020 at 01:14:47PM +0100, Alexandre Ratchov wrote: > Here's a new sndioctl utility similar to mixerctl(1) but using the new > sndio API. Example: > > $ sndioctl > output.level=127 > app/aucat0.level=127 > app/firefox0.level=127

Re: extern already declared

2020-02-09 Thread Jan Stary
On Feb 09 09:49:35, mill...@openbsd.org wrote: > On Sun, 09 Feb 2020 17:46:51 +0100, Jan Stary wrote: > > > Whenever unistd.h declares getopt(3), it also declares > > the extern optind and optarg, so files including unistd.h > > don't need to declare those themselves, right? > > Correct. Most

afile.h not wav.h

2020-02-09 Thread Jan Stary
The afile.h include has been so named for some time but the corresponding #define has not been changed from WAV_H - not that it matters much of course. Jan Index: afile.h === RCS file: /cvs/src/usr.bin/aucat/afile.h,v

Re: extern already declared

2020-02-09 Thread Todd C . Miller
On Sun, 09 Feb 2020 17:46:51 +0100, Jan Stary wrote: > Whenever unistd.h declares getopt(3), it also declares > the extern optind and optarg, so files including unistd.h > don't need to declare those themselves, right? Correct. Most of those date back from before optind and optarg were defined

extern already declared

2020-02-09 Thread Jan Stary
Whenever unistd.h declares getopt(3), it also declares the extern optind and optarg, so files including unistd.h don't need to declare those themselves, right? Jan Index: games/fortune/strfile/strfile.c === RCS file:

Re: Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-09 Thread Visa Hankala
On Tue, Feb 04, 2020 at 02:21:02PM +0100, Martin Pieuchot wrote: > void > selwakeup(struct selinfo *sip) > { > + KERNEL_LOCK(); > + KNOTE(>si_note, NOTE_SUBMIT); > + doselwakeup(sip); > + KERNEL_UNLOCK(); > +} There is a problem with audio code. Audio interrupt handlers

remove needless #ifdef

2020-02-09 Thread Jan Stary
Currently, sys/net/pipex_local.h asks #ifdef __OpenBSD__ and if so, defines "Static" to be nothing, to use it later. That can go away, right? Jan Index: sys/net/pipex_local.h === RCS file: /cvs/src/sys/net/pipex_local.h,v

Re: locate.updatedb TMPDIR

2020-02-09 Thread Ingo Schwarze
Hi Joerg, this is absolutely not OK. How did you test this? $ doas cat /var/log/weekly.part /etc/weekly[79]: no closing quote With that fixed, i agree with the direction of the change. Yours, Ingo Joerg Jung wrote on Sun, Feb 09, 2020 at 12:33:42AM +0100: > I have a machine with a

Re: locate.updatedb TMPDIR

2020-02-09 Thread Todd C . Miller
On Sun, 09 Feb 2020 16:18:52 +0100, Ingo Schwarze wrote: > It is mentioned there, but not really documented. OK millert@. - todd

Re: locate.updatedb TMPDIR

2020-02-09 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Sun, Feb 09, 2020 at 07:52:10AM -0700: > I'm fine with this. I don't really object, but i'm not sure it is needed either. It's certainly obvious that command line arguments override defaults. That's what they always do. It's their whole point, in general.

Re: locate.updatedb TMPDIR

2020-02-09 Thread Todd C . Miller
On Sun, 09 Feb 2020 00:46:52 +0100, Joerg Jung wrote: I'm fine with this. However, it doesn't look like we document /etc/locate.rc anywhere. I'm not sure it deserves its own man page but I think it should at least be documented in locate.updatedb in some fashion. - todd > Index:

Re: mg: fix problems found by gcc 10

2020-02-09 Thread Sebastian Benoit
read ok Florian Obser(flor...@openbsd.org) on 2020.02.09 10:46:34 +0100: > Anyone? I'll commit this soon if I don't hear back, I don't think this > is contentious. > > On Fri, Feb 07, 2020 at 03:59:50PM +0100, Florian Obser wrote: > > Moving from misc to tech. > > > > This is effectively

Re: locate.updatedb TMPDIR

2020-02-09 Thread Todd C . Miller
On Sun, 09 Feb 2020 00:33:42 +0100, Joerg Jung wrote: > I have a machine with a large data storage attached, but it has only 2GB > of /tmp (which I consider enough usually). On this machine weekly > locate.updatedb fails, due to /tmp being full. To fix this I would like > to point locate to a

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sun, Feb 09, 2020 at 07:49:10AM +: > - bgpd.8 refers to /etc/bgpd.conf. that file doesn;t exist by default. I do not consider that a problem, not even a minor one. ENVIRONMENT says which variables are inspected if they exist. FILES says which files are

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Ingo Schwarze
Hi Marc, Marc Espie wrote on Sun, Feb 09, 2020 at 02:27:23PM +0100: > I still think it's a good idea to put it in afterboot(8). No more objections, with or without jmc@'s tweaks. It seems clear that enough people want it in that page. Yours, Ingo > Index: afterboot.8 >

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Jason McIntyre
On Sun, Feb 09, 2020 at 02:27:23PM +0100, Marc Espie wrote: > On Sun, Feb 09, 2020 at 12:41:43AM +0100, Sebastian Benoit wrote: > > Ingo Schwarze(schwa...@usta.de) on 2020.02.09 00:33:06 +0100: > > > Hi, > > > > > > Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +: > > > > > > > -

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Marc Espie
On Sun, Feb 09, 2020 at 12:41:43AM +0100, Sebastian Benoit wrote: > Ingo Schwarze(schwa...@usta.de) on 2020.02.09 00:33:06 +0100: > > Hi, > > > > Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +: > > > > > - i'm ok with adding the path to these files to a FILES section > > > > So,

Audio control API, part 4: switch ports to sndio API

2020-02-09 Thread Alexandre Ratchov
There are two ports only using the kernel-based API, this diff updates them to use new libsndio-based API: - sysutils/tray-app - audio/gqmpeg As a side effect, this fixes gqmpeg crashes, makes these programs use the right device, and make them work on many uaudio(4) and envy(4) devices with

Audio control API, part 3: switch -lossaudio to sndio

2020-02-09 Thread Alexandre Ratchov
Certain ports use -lossaudio to get access to the volume knobs. This diff updates -lossaudio to use the new sndio API. By default, it exposes both sndiod output level and hardware master input/output knobs (if present). The source selectors are not exposed any longer as sndiod doesn't expose them.

Audio control API, part 2: add new sndioctl(1) utility

2020-02-09 Thread Alexandre Ratchov
Here's a new sndioctl utility similar to mixerctl(1) but using the new sndio API. Example: $ sndioctl output.level=127 app/aucat0.level=127 app/firefox0.level=127 app/firefox1.level=12 app/midisyn0.level=127 app/mpv0.level=127

Audio control API, part 1: libsndio, sndiod bits

2020-02-09 Thread Alexandre Ratchov
This diff adds an API to control knobs of audio interfaces. It aims to address these points: - allow the controls of modern audio hardware and sndiod software volume knobs in a uniform way. Hardware knobs are exposed by sndiod, which will be also important from security standpoint: by default

Re: mg: fix problems found by gcc 10

2020-02-09 Thread Florian Obser
Anyone? I'll commit this soon if I don't hear back, I don't think this is contentious. On Fri, Feb 07, 2020 at 03:59:50PM +0100, Florian Obser wrote: > Moving from misc to tech. > > This is effectively Ulrich's diff from github with a bit of whitespace > shuffling. > > OK? > > diff --git