Update Term::ReadKey to 2.38

2020-02-24 Thread Andrew Hewus Fresh
In order to better support the pkg tools we include Term::ReadKey with the base system, that means I totally forgot about it. So, this picks up a few years of updates. This patch updates the 2.33 we have in-tree to the current 2.38. https://metacpan.org/changes/distribution/TermReadKey

Re: [patch] smtpd: fix for ctype casts

2020-02-24 Thread Theo de Raadt
I am much happier with the [] array derefs. I surprised this snuck in, time for a ctype re-audit of the entire tree

Re: [patch] smtpd: fix for ctype casts

2020-02-24 Thread Joerg Jung
> On 24. Feb 2020, at 20:31, Todd C. Miller wrote: > > I have a mostly-identical patch in my tree, though I tried to improve > readability a bit. ok jung@ > - todd > > Index: usr.sbin/smtpd/mta_session.c > === > RCS file:

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Ted Unangst
Martin Pieuchot wrote: > On 24/02/20(Mon) 11:29, Lauri Tirkkonen wrote: > > On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > > > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > > > I was working on a make jobserver implementation that uses POSIX > > > > semaphores as job tokens

Re: ieee80211: handle SIOCSIFLLADDR in ifioctl()

2020-02-24 Thread Stefan Sperling
On Mon, Feb 24, 2020 at 07:54:09PM +0100, Tobias Heider wrote: > Hi, > > I noticed that my iwm(4) device does not send RTM_IFINFO messages > when the lladdr is changed with ifconfig. > For other interface types ifioctl() handles the lladdr change in > if_setlladdr() and ifnewlladdr(). > I

Re: [patch] smtpd: fix for ctype casts

2020-02-24 Thread Todd C . Miller
I have a mostly-identical patch in my tree, though I tried to improve readability a bit. - todd Index: usr.sbin/smtpd/mta_session.c === RCS file: /cvs/src/usr.sbin/smtpd/mta_session.c,v retrieving revision 1.132 diff -u -p -u

ieee80211: handle SIOCSIFLLADDR in ifioctl()

2020-02-24 Thread Tobias Heider
Hi, I noticed that my iwm(4) device does not send RTM_IFINFO messages when the lladdr is changed with ifconfig. For other interface types ifioctl() handles the lladdr change in if_setlladdr() and ifnewlladdr(). I attached a diff that seems to fix this. Is there a specific reason IFT_IEEE80211 is

fix ifconfig join with invalid hex -> join ""

2020-02-24 Thread Stefan Sperling
This command: # ifconfig iwm0 join 0x61626163a ifconfig: bad hexadecimal digits ends up adding "" to the joinlist, i.e. it has the same effect as ifconfig iwm0 join "" This happens because A_JOIN gets set even on invalid input. setifjoin

simplify ifconfig's len_string and print_string

2020-02-24 Thread Stefan Sperling
These functions will compute the wrong display width for input which is already a hex string. This bug doesn't trigger because we never actually pass an ASCII hex string in, but it is still a bug. ASCII hex strings are printable ASCII, so there's no reason to have a special case for them. This

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Lauri Tirkkonen
On Mon, Feb 24 2020 10:42:22 +0100, Martin Pieuchot wrote: > > Yes, that's what I'm trying to do. Yes, I've seen the current > > implementation -- that's why I started this thread, in an attempt to > > make them supported. :) > > > > See the followup patch -- sharing the semaphore between

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Lauri Tirkkonen
On Mon, Feb 24 2020 10:42:22 +0100, Martin Pieuchot wrote: > On 24/02/20(Mon) 11:29, Lauri Tirkkonen wrote: > > On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > > > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > > > I was working on a make jobserver implementation that uses POSIX >

Re: ifconfig with UTF-8 nwid

2020-02-24 Thread Stefan Sperling
On Sun, Feb 23, 2020 at 04:19:39PM -0800, Andrew Hewus Fresh wrote: > This removes any characters that are not marked as "printable", which I > expect is what folks want. Still doesn't always help since I still > haven't figured out font fallback in xterm so some chars don't exist in > my current

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Martin Pieuchot
On 24/02/20(Mon) 11:29, Lauri Tirkkonen wrote: > On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > > I was working on a make jobserver implementation that uses POSIX > > > semaphores as job tokens instead of a complicated socket-based

Re: Audio control API, part 1: libsndio, sndiod bits

2020-02-24 Thread Alexandre Ratchov
On Thu, Feb 13, 2020 at 05:15:34AM +, Raf Czlonka wrote: > On Sun, Feb 09, 2020 at 12:13:02PM GMT, Alexandre Ratchov wrote: > > +++ lib/libsndio/sioctl_aucat.c 8 Feb 2020 14:49:37 - > > [...] > > + * Copyright (c) 2010-2011 Alexandre Ratchov > > > > [...] > > > > +++

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Lauri Tirkkonen
On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > I was working on a make jobserver implementation that uses POSIX > > semaphores as job tokens instead of a complicated socket-based approach. > > Initially I used named semaphores, which

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Martin Pieuchot
On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > I was working on a make jobserver implementation that uses POSIX > semaphores as job tokens instead of a complicated socket-based approach. > Initially I used named semaphores, which work fine, except if child > processes with less privileges need

Re: [patch] smtpd: fix for ctype casts

2020-02-24 Thread Hiltjo Posthuma
*ping* Any feedback for the below patch is appreciated. Thanks, On Sat, Feb 01, 2020 at 05:01:48PM +0100, Hiltjo Posthuma wrote: > Hi, > > This (pedantic) patch fixes a few casts for ctype functions/macros, like > isspace, isalpha and isdigit. > > The isspace(3) man page says: > > "CAVEATS