wg(4) if_rtrequest

2020-08-25 Thread Matt Dunwoodie
Hi, I doing some IPv6 setup, I came across an issue with wg(4) and ndp. The local route is created with RTF_LLINFO, which ndp attempts to print. As wg is a layer3 tunnel it won't have any link-local information. This patch just sets if_rtrequest to p2p_rtrequest. Even if wg is technically

Re: make(1): anchors in :S/old_string/new_string/

2020-08-25 Thread Todd C . Miller
On Thu, 20 Aug 2020 20:31:03 +0200, Theo Buehler wrote: > I think the fix should be as simple as the diff below. I added a small > extension of a regress test for this. Unpatched make fails, patched > make passes. That looks good to me, I can't think of any problems that moving the logic into

Re: top: toggle routing tables

2020-08-25 Thread Remi Locherer
On Tue, Aug 25, 2020 at 09:34:55AM +0200, Klemens Nanni wrote: > On Mon, Aug 24, 2020 at 12:52:46AM +0200, Klemens Nanni wrote: > > Add `t' to swap the WAIT column with RTABLE (and vice versa); WAIT > > is wide enough to fit RTABLE, somewhat adds additional value to STATE > > and seems therefore

Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-25 Thread Mark Kettenis
> Date: Tue, 25 Aug 2020 12:20:22 -0700 > From: Mike Larkin > > On Mon, Aug 24, 2020 at 12:29:15AM -0500, Scott Cheloha wrote: > > On Sun, Aug 23, 2020 at 11:45:22PM -0500, Scott Cheloha wrote: > > > > > > [...] > > > > > > > > This patch (or something equivalent) is a prerequisite to running

snmpd(8) start cleaning up socket code.

2020-08-25 Thread Martijn van Duren
I would like to move snmpd(8) to a more modular dispatch/transport map system, but that's going to be quite the undertaking. To make things a little better to grok I'd like to split of the trap receiver components out of struct address as a first step. While doing this I can also greatly simplify

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
On Tue, Aug 25, 2020 at 01:38:20PM -0600, Theo de Raadt wrote: | What you are doing wasn't the purpose of the time field. It was added | only for time sensors, and it looks like someone added it to other | sensors. And now it must suddenly be for all of them?? Sorry - I may have introduced some

Re: sensor value last change time not updated?

2020-08-25 Thread Mark Kettenis
> Date: Tue, 25 Aug 2020 21:33:32 +0200 > From: Paul de Weerd > > Hi Mark, > > Thanks for your reply. > > On Tue, Aug 25, 2020 at 09:27:20PM +0200, Mark Kettenis wrote: > | > I've dug out my stash of weird usb devices and found another sensor (a > | > uthum(4), with only temperature support).

Re: sensor value last change time not updated?

2020-08-25 Thread Theo de Raadt
Paul de Weerd wrote: > On Tue, Aug 25, 2020 at 09:27:20PM +0200, Mark Kettenis wrote: > | > I've dug out my stash of weird usb devices and found another sensor (a > | > uthum(4), with only temperature support). I have a few other sensors > | > in live machines too (acpitz(4), cpu(4),

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
Hi Theo, On Tue, Aug 25, 2020 at 01:33:28PM -0600, Theo de Raadt wrote: | > I don't understand the point. None of the sensor drivers set that | > member except the timedelta sensors. I don't think adding code to do | > so to all sensor drivers makes sense. | | That is correct. Non-time

Re: sensor value last change time not updated?

2020-08-25 Thread Theo de Raadt
Mark Kettenis wrote: > > Date: Tue, 25 Aug 2020 21:19:19 +0200 > > From: Paul de Weerd > > > > Hi all, > > > > I've dug out my stash of weird usb devices and found another sensor (a > > uthum(4), with only temperature support). I have a few other sensors > > in live machines too (acpitz(4),

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
Hi Mark, Thanks for your reply. On Tue, Aug 25, 2020 at 09:27:20PM +0200, Mark Kettenis wrote: | > I've dug out my stash of weird usb devices and found another sensor (a | > uthum(4), with only temperature support). I have a few other sensors | > in live machines too (acpitz(4), cpu(4),

Re: sensor value last change time not updated?

2020-08-25 Thread Mark Kettenis
> Date: Tue, 25 Aug 2020 21:19:19 +0200 > From: Paul de Weerd > > Hi all, > > I've dug out my stash of weird usb devices and found another sensor (a > uthum(4), with only temperature support). I have a few other sensors > in live machines too (acpitz(4), cpu(4), admtemp(4), it(4), maybe some >

Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-25 Thread Mike Larkin
On Tue, Aug 25, 2020 at 12:12:36PM -0700, Mike Larkin wrote: > On Mon, Aug 24, 2020 at 01:55:45AM +0200, Mark Kettenis wrote: > > > Date: Sun, 23 Aug 2020 18:11:12 -0500 > > > From: Scott Cheloha > > > > > > Hi, > > > > > > Other BSDs use the TSC to implement delay(9) if the TSC is constant > > >

Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-25 Thread Mike Larkin
On Mon, Aug 24, 2020 at 12:29:15AM -0500, Scott Cheloha wrote: > On Sun, Aug 23, 2020 at 11:45:22PM -0500, Scott Cheloha wrote: > > > > [...] > > > > > > This patch (or something equivalent) is a prerequisite to running the > > > > lapic timer in oneshot or TSC deadline mode. Using the lapic

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
Hi all, I've dug out my stash of weird usb devices and found another sensor (a uthum(4), with only temperature support). I have a few other sensors in live machines too (acpitz(4), cpu(4), admtemp(4), it(4), maybe some more) that I could look into. Is there any interest in adding support for

Re: amd64: add tsc_delay(), a TSC-based delay(9) implementation

2020-08-25 Thread Mike Larkin
On Mon, Aug 24, 2020 at 01:55:45AM +0200, Mark Kettenis wrote: > > Date: Sun, 23 Aug 2020 18:11:12 -0500 > > From: Scott Cheloha > > > > Hi, > > > > Other BSDs use the TSC to implement delay(9) if the TSC is constant > > and invariant. Here's a patch to add something similar to our kernel. > >

Re: ntpd: go into unsynced mode

2020-08-25 Thread Otto Moerbeek
On Tue, Aug 25, 2020 at 07:05:31PM +0200, Matthias Schmidt wrote: > Hi Otto, > > * Otto Moerbeek wrote: > > Hi, > > > > At the moment ntpd never goes into unsynced mode if network > > connectivity is lost. The code to do that is only triggered when a > > pakcet is received, which does not

Re: ntpd: go into unsynced mode

2020-08-25 Thread Matthias Schmidt
Hi Otto, * Otto Moerbeek wrote: > Hi, > > At the moment ntpd never goes into unsynced mode if network > connectivity is lost. The code to do that is only triggered when a > pakcet is received, which does not happen. > > This diff fixes that by going into unsynced mode if no time data was >

Re: m_defrag(9) leak

2020-08-25 Thread Claudio Jeker
On Tue, Aug 25, 2020 at 08:38:06PM +1000, Matt Dunwoodie wrote: > On Tue, 25 Aug 2020 08:54:10 +0200 > Claudio Jeker wrote: > > > On Tue, Aug 25, 2020 at 08:42:47AM +0200, Martin Pieuchot wrote: > > > Maxime Villard mentioned a leak due to a missing m_freem() in wg(4): > > >

Re: smtpd filters: accept bypass in commit stage

2020-08-25 Thread Lucas
Martijn van Duren wrote: > Does this filter actually work for you? Not by my testing, nor my > understanding of filters. Filter-dkimsign works during the > filter-dataline phase, so you'd have to circumvent that one, which is > not supported. Finally got around to test it. Found the problem too

Re: m_defrag(9) leak

2020-08-25 Thread Matt Dunwoodie
On Tue, 25 Aug 2020 08:54:10 +0200 Claudio Jeker wrote: > On Tue, Aug 25, 2020 at 08:42:47AM +0200, Martin Pieuchot wrote: > > Maxime Villard mentioned a leak due to a missing m_freem() in wg(4): > > https://marc.info/?l=netbsd-tech-net=159827988018641=2 > > > > It seems to be that such

iwm/iwx: reset Rx BA session counter

2020-08-25 Thread Stefan Sperling
The Rx block ack session counter is not reset when an iwm/iwx interface disassociates from the AP or is put down via ifconfig. This can lead to new Rx block ack session being refused upon re-association. Found by zxystd from the OpenIntelWireless project (drivers for macOS). The firmware

Re: smtpd filters: accept bypass in commit stage

2020-08-25 Thread Martijn van Duren
Does this filter actually work for you? Not by my testing, nor my understanding of filters. Filter-dkimsign works during the filter-dataline phase, so you'd have to circumvent that one, which is not supported. Personally I'd sign the domain anyway, since it gives the receiver some additional

Re: top: toggle routing tables

2020-08-25 Thread Klemens Nanni
On Mon, Aug 24, 2020 at 12:52:46AM +0200, Klemens Nanni wrote: > Add `t' to swap the WAIT column with RTABLE (and vice versa); WAIT > is wide enough to fit RTABLE, somewhat adds additional value to STATE > and seems therefore most appropiate to hide in favour of RTABLE. > > Internally, I renamed

Re: m_defrag(9) leak

2020-08-25 Thread Claudio Jeker
On Tue, Aug 25, 2020 at 08:42:47AM +0200, Martin Pieuchot wrote: > Maxime Villard mentioned a leak due to a missing m_freem() in wg(4): > https://marc.info/?l=netbsd-tech-net=159827988018641=2 > > It seems to be that such leak is present in other uses of m_defrag() in > the tree. I won't

m_defrag(9) leak

2020-08-25 Thread Martin Pieuchot
Maxime Villard mentioned a leak due to a missing m_freem() in wg(4): https://marc.info/?l=netbsd-tech-net=159827988018641=2 It seems to be that such leak is present in other uses of m_defrag() in the tree. I won't take the time to go though all of them, but an audit would be welcome.