Re: ldapd: adding bsd.schema

2020-09-14 Thread Robert Klein
On Thu, 10 Sep 2020 17:03:28 -0400 Aisha Tammy wrote: > On 9/10/20 2:03 AM, Robert Klein wrote: > > On Sat, 5 Sep 2020 18:47:08 -0400 > > Aisha Tammy wrote: > > > >> Sorry for the late reply. > >> > >> On 8/12/20 8:19 AM, Robert Klein wrote: > >>> Hi, > >>> > >>> On Wed, 12 Aug 2020

Re: diff: pfctl: error message for nonexisting rtable

2020-09-14 Thread YASUOKA Masahiko
Hi, On Tue, 15 Sep 2020 02:31:24 +0200 Klemens Nanni wrote: > On Tue, Sep 15, 2020 at 12:30:35AM +0200, Klemens Nanni wrote: >> Actually, that should just work regardless of whether the rounting >> domain exists at ruleset creation time; just like it is the case with >> interface names/groups

cap_mkdb: remove igetnext prototype for the function does not exist

2020-09-14 Thread Kevin Lo
ok? Index: usr.bin/cap_mkdb/cap_mkdb.c === RCS file: /cvs/src/usr.bin/cap_mkdb/cap_mkdb.c,v retrieving revision 1.24 diff -u -p -u -p -r1.24 cap_mkdb.c --- usr.bin/cap_mkdb/cap_mkdb.c 28 Jun 2019 14:20:40 - 1.24 +++

Re: diff: pfctl: error message for nonexisting rtable

2020-09-14 Thread Klemens Nanni
On Tue, Sep 15, 2020 at 12:30:35AM +0200, Klemens Nanni wrote: > Actually, that should just work regardless of whether the rounting > domain exists at ruleset creation time; just like it is the case with > interface names/groups which may come and go at runtime without > requiring changes to the

Re: diff: pfctl: error message for nonexisting rtable

2020-09-14 Thread Klemens Nanni
On Mon, Sep 14, 2020 at 02:09:27PM +0900, YASUOKA Masahiko wrote: > When pf rule with a "on rdomain n" with nonexisting rdomain n causes > > /etc/pf.conf:XXX: rdomain n does not exist Actually, that should just work regardless of whether the rounting domain exists at ruleset creation time;

Re: acme-client: improve account creation error message

2020-09-14 Thread Rafael Possamai
>please dont drop the all buffer , or keep it with -vv ? >example : warnx("%s: bad JSON object:%s", p->newaccount, c->buf.buf); > >i don't want to ktrace it to see why the new certbot version is not working Yeah, I think it's good to have the choice to inspect the vomit, maybe you stumble upon

Re: syslogd listen keep alive

2020-09-14 Thread Theo de Raadt
Excellent! Alexander Bluhm wrote: > Hi, > > A while ago dhill@ pointed out that syslogd TCP sockets will stay > open forever if a client aborts the connection silently. As syslogd > does not write anything into incoming connections, it will not > recognize failure and the socket will stay

Re: syslogd listen keep alive

2020-09-14 Thread Todd C . Miller
On Mon, 14 Sep 2020 21:49:07 +0200, Alexander Bluhm wrote: > A while ago dhill@ pointed out that syslogd TCP sockets will stay > open forever if a client aborts the connection silently. As syslogd > does not write anything into incoming connections, it will not > recognize failure and the socket

syslogd listen keep alive

2020-09-14 Thread Alexander Bluhm
Hi, A while ago dhill@ pointed out that syslogd TCP sockets will stay open forever if a client aborts the connection silently. As syslogd does not write anything into incoming connections, it will not recognize failure and the socket will stay forever. Setting TCP keep alive on the listen

Re: smtp(1) fix for usernames containing '@' symbols

2020-09-14 Thread Todd C . Miller
On Mon, 14 Sep 2020 16:55:43 -, Josh Rickmar wrote: > Some email accounts use account names that include the @host portion, > and this broke the server and credentials parsing in smtp(1). Sometimes > I see these @ characters encoded as %40, but smtp(1) was not decoding > these url escape

Re: [PATCH] Add IOMMU support for Intel VT-d and AMD-Vi

2020-09-14 Thread Mark Kettenis
> Date: Tue, 8 Sep 2020 21:43:39 -0500 > From: Jordan Hargrave > > Made changes for the iommu_readq -> iommu_read_8 and also now > dynamically allocate the hwdte for AMD IOMMU. Some more bits... > On Fri, Sep 04, 2020 at 09:17:18PM +0200, Mark Kettenis wrote: > > > Date: Fri, 4 Sep 2020

Re: ldom.conf.5: clarify vcpu strides

2020-09-14 Thread Klemens Nanni
On Wed, Sep 02, 2020 at 04:58:39PM +0200, Stefan Sperling wrote: > I would like to suggest an example for the EXAMPLES section which > illustrates how a suitable stride factor can be determined (divide the > number of desired "unused" cpus by the number of desired "used" cpus): We can do with an

smtp(1) fix for usernames containing '@' symbols

2020-09-14 Thread Josh Rickmar
Some email accounts use account names that include the @host portion, and this broke the server and credentials parsing in smtp(1). Sometimes I see these @ characters encoded as %40, but smtp(1) was not decoding these url escape sequences before base64 encoding and talking with the server.

Re: acme-client(1) and Buypass Go SSL

2020-09-14 Thread Florian Obser
This fell through the cracks back in April. We need to be able to provide contact information to use the buypass.com acme api. OK? diff --git etc/examples/acme-client.conf etc/examples/acme-client.conf index 32ecd8e8655..40d231725ac 100644 --- etc/examples/acme-client.conf +++

acme-client: relax certificate parsing

2020-09-14 Thread Florian Obser
Relax parsing of pem files a bit. Apparently there are CAs that use \r\n line endings. >From Bartosz Kuzma as part of a larger diff. OK? diff --git certproc.c certproc.c index 7fde96e970e..975e12afaaa 100644 --- certproc.c +++ certproc.c @@ -28,7 +28,8 @@ #include "extern.h" -#define MARKER

snmp request specific OIDs from mibtree

2020-09-14 Thread Martijn van Duren
Sometimes I want to know the OID from a name and vice versa. I'm done doing these by hand. Diff below does this for me: $ ./obj/snmp mibtree -On snmpTrapOID.0 .1.3.6.1.6.3.1.1.4.1.0 OK? martijn@ Index: snmp.1 === RCS file:

Re: acme-client: improve account creation error message

2020-09-14 Thread Sven F.
On Mon, Sep 14, 2020 at 9:45 AM Bob Beck wrote: > > But what if I like json and I am already set up to be a hipster and > feed all the untrusted inputs through jq.. > > (ok beck@) > > On Mon, Sep 14, 2020 at 03:37:25PM +0200, Florian Obser wrote: > > not helpful: > > $ doas acme-client

Re: btrace: add boolean AND and OR operators

2020-09-14 Thread Sebastien Marie
On Mon, Sep 14, 2020 at 03:28:17PM +0200, Jasper Lievisse Adriaanse wrote: > Hi, > > This diff adds support for the '&' and '|' operators, along with > a new testcase. > > OK? make sens to me. ok semarie@ > Index: usr.sbin/btrace/bt_parse.y >

Re: btrace: add boolean AND and OR operators

2020-09-14 Thread Jasper Lievisse Adriaanse
On Mon, Sep 14, 2020 at 03:39:04PM +0200, Otto Moerbeek wrote: > On Mon, Sep 14, 2020 at 03:28:17PM +0200, Jasper Lievisse Adriaanse wrote: > > > Hi, > > > > This diff adds support for the '&' and '|' operators, along with > > a new testcase. > > > > OK? > > The precedence looks funny > > I'd

Re: acme-client: improve account creation error message

2020-09-14 Thread Bob Beck
But what if I like json and I am already set up to be a hipster and feed all the untrusted inputs through jq.. (ok beck@) On Mon, Sep 14, 2020 at 03:37:25PM +0200, Florian Obser wrote: > not helpful: > $ doas acme-client $(hostname) > acme-client:

Re: btrace: add boolean AND and OR operators

2020-09-14 Thread Otto Moerbeek
On Mon, Sep 14, 2020 at 03:28:17PM +0200, Jasper Lievisse Adriaanse wrote: > Hi, > > This diff adds support for the '&' and '|' operators, along with > a new testcase. > > OK? The precedence looks funny I'd guess you want %left '|' %left '&' %left '+' '-' %left '/' '*' To avoid suprises.

acme-client: improve account creation error message

2020-09-14 Thread Florian Obser
not helpful: $ doas acme-client $(hostname) acme-client: https://api.test4.buypass.no/acme-v02/new-acct: bad HTTP: 400 vomitting unformated json is not better: $ doas acme-client -v $(hostname) acme-client: transfer buffer: [{"type":"urn:ietf:params:acme:error:malformed","detail":"Email is a

Re: Document the WSDISPLAYIO_GETSCREENTYPE ioctl in wsdisplay.4

2020-09-14 Thread Mark Kettenis
> Date: Mon, 14 Sep 2020 12:04:37 +0200 > From: Frederic Cambus > > Hi tech@, > > Here is a diff to document the WSDISPLAYIO_GETSCREENTYPE ioctl in > wsdisplay.4. > > The wsdisplay_screentype structure definition can be found in > . > > Comments? OK? Sure, go for it. > Index: wsdisplay.4 >

Re: smtpd: document "pki" option for relay delivery in smtpd.conf(5)

2020-09-14 Thread Todd C . Miller
On Sun, 13 Sep 2020 20:45:35 +0800, Nick Gasson wrote: > I struggled a bit to configure smtpd to relay to a remote server that > requires SSL client certificates. The solution is to just add a "pki > host.example.org" option, but "pki" is not listed as a valid option for > the relay delivery

btrace: add boolean AND and OR operators

2020-09-14 Thread Jasper Lievisse Adriaanse
Hi, This diff adds support for the '&' and '|' operators, along with a new testcase. OK? Index: usr.sbin/btrace/bt_parse.y === RCS file: /cvs/src/usr.sbin/btrace/bt_parse.y,v retrieving revision 1.16 diff -u -p -r1.16 bt_parse.y

Re: dt: add static vfs probes

2020-09-14 Thread Bob Beck
ok beck@ On Mon, Sep 14, 2020 at 12:45:55PM +0200, Jasper Lievisse Adriaanse wrote: > Hi, > > Whilst analyzing the cleaner I added tracepoints called 'cleaner' and > 'bufcache_take' to > track its behaviour. > > For the sake of symmetry I've added one in bufcache_release() too and moved >

Re: go/rust vs uvm_map_inentry()

2020-09-14 Thread Theo de Raadt
A similar fix for the "sh" cpu, which is in the landisk. Index: sh/sh/trap.c === RCS file: /cvs/src/sys/arch/sh/sh/trap.c,v retrieving revision 1.40 diff -u -p -u -r1.40 trap.c --- sh/sh/trap.c6 Sep 2019 12:22:01 -

Re: go/rust vs uvm_map_inentry()

2020-09-14 Thread Theo de Raadt
i386 has the same problem. Index: arch/i386/i386/trap.c === RCS file: /cvs/src/sys/arch/i386/i386/trap.c,v retrieving revision 1.143 diff -u -p -u -r1.143 trap.c --- arch/i386/i386/trap.c 19 Aug 2020 10:10:58 - 1.143

Re: go/rust vs uvm_map_inentry()

2020-09-14 Thread Sebastien Marie
On Mon, Sep 14, 2020 at 01:25:03PM +0200, Mark Kettenis wrote: > > Date: Sun, 13 Sep 2020 19:48:19 +0200 > > From: Sebastien Marie > > > > On Sun, Sep 13, 2020 at 04:49:48PM +0200, Sebastien Marie wrote: > > > On Sun, Sep 13, 2020 at 03:29:57PM +0200, Martin Pieuchot wrote: > > > > I'm no longer

Re: go/rust vs uvm_map_inentry()

2020-09-14 Thread Mark Kettenis
> Date: Sun, 13 Sep 2020 19:48:19 +0200 > From: Sebastien Marie > > On Sun, Sep 13, 2020 at 04:49:48PM +0200, Sebastien Marie wrote: > > On Sun, Sep 13, 2020 at 03:29:57PM +0200, Martin Pieuchot wrote: > > > I'm no longer able to reproduce the corruption while building lang/go > > > with the

pppoe: little cleanup

2020-09-14 Thread Klemens Nanni
I'm going through the pppoeintr() code path wrt. KERNEL_LOCK(), first step is discovery packet handling. Reading the code makes me want to clean/simplify it a bit by zapping needless variable assignments (dead store because next usage is another assign) and merging initializations into

dt: add static vfs probes

2020-09-14 Thread Jasper Lievisse Adriaanse
Hi, Whilst analyzing the cleaner I added tracepoints called 'cleaner' and 'bufcache_take' to track its behaviour. For the sake of symmetry I've added one in bufcache_release() too and moved the assignment of 'pages' until after the KASSERT(), following the flow of bufcache_take(). Sample

Document the WSDISPLAYIO_GETSCREENTYPE ioctl in wsdisplay.4

2020-09-14 Thread Frederic Cambus
Hi tech@, Here is a diff to document the WSDISPLAYIO_GETSCREENTYPE ioctl in wsdisplay.4. The wsdisplay_screentype structure definition can be found in . Comments? OK? Index: wsdisplay.4 === RCS file:

Re: trunk: keep interface up on port removal

2020-09-14 Thread Stuart Henderson
On 2020/09/14 10:57, Klemens Nanni wrote: > On Sun, Sep 13, 2020 at 06:44:13PM +0100, Stuart Henderson wrote: > > I can't test at the moment, but the other case is removing a port from > > the trunk without destroying the trunk interface itself. That's almost > > certainly what I was testing at

Re: diff: pfctl: error message for nonexisting rtable

2020-09-14 Thread Klemens Nanni
On Mon, Sep 14, 2020 at 02:09:27PM +0900, YASUOKA Masahiko wrote: > Make pfctl check if the rtable really exists when parsing the config. I concur, but you can do this with less (duplicated) code. Instead of copying rdomain_exists() into rtable_exists() with the `rti_domainid' check omitted,

Re: trunk: keep interface up on port removal

2020-09-14 Thread Klemens Nanni
On Sun, Sep 13, 2020 at 06:44:13PM +0100, Stuart Henderson wrote: > I can't test at the moment, but the other case is removing a port from > the trunk without destroying the trunk interface itself. That's almost > certainly what I was testing at the time. Right, that's different from destroying

Re: smtpd: document "pki" option for relay delivery in smtpd.conf(5)

2020-09-14 Thread Giovanni Bechis
On 9/13/20 11:09 PM, Todd C. Miller wrote: > On Sun, 13 Sep 2020 20:45:35 +0800, Nick Gasson wrote: > >> I struggled a bit to configure smtpd to relay to a remote server that >> requires SSL client certificates. The solution is to just add a "pki >> host.example.org" option, but "pki" is not