ospf(6)d: do not unlink the control socket

2020-09-15 Thread Remi Locherer
In 2018 we discussed that it is OK when ripd leaves its control socket laying around: https://marc.info/?l=openbsd-tech&m=154101413029926&w=2 When mestre@ adapted ldpd in June this year I was reminded to also adapt ospfd and ospf6d for consistent. OK? Remi Index: ospfd/control.c ==

Re: sigabort(), p_sigmask & p_siglist

2020-09-15 Thread Miod Vallat
> Diff below introduces an helper for sending an uncatchable SIGABRT and > annotate that `p_siglist' and `p_sigmask' are updated using atomic > operations. Why not use sigexit(p, SIGABRT); for that purpose?

systat(1): vmstat: compute rates with CLOCK_UPTIME

2020-09-15 Thread Scott Cheloha
Hi, systat(1)'s vmstat view displays rates for things like interrupts. Strangely, it uses CPU time to compute these rates, not real time. This is potentially misleading, particularly on an MP system. If I have 4 cores running on a HZ=100 kernel I expect ~400 clock interrupts per second. But sys

Re: acme-client: relax certificate parsing

2020-09-15 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2020.09.14 17:12:01 +0200: > Relax parsing of pem files a bit. Apparently there are CAs that use > \r\n line endings. > From Bartosz Kuzma as part of a larger diff. > > OK? > > diff --git certproc.c certproc.c > index 7fde96e970e..975e12afaaa 100644 > ---

Re: acme-client(1) and Buypass Go SSL

2020-09-15 Thread Sebastian Benoit
ok! Florian Obser(flor...@openbsd.org) on 2020.09.14 17:15:37 +0200: > > This fell through the cracks back in April. > > We need to be able to provide contact information to use the > buypass.com acme api. > > OK? > > diff --git etc/examples/acme-client.conf etc/examples/acme-client.conf > ind

[patch] Don't require a working efifb when probing for EFI/GPT

2020-09-15 Thread Andrew Daugherity
I successfully installed OpenBSD under xhyve, although there were a few issues, mostly xhyve's fault [1]. One which seems to be an issue with OpenBSD itself rather than xhyve is that with a headless machine, the installer always uses MBR mode. I selected GPT and ignored the warning "An EFI/GPT di

PATCH: Add vmmpci device for passthrough PCI

2020-09-15 Thread Jordan Hargrave
This adds a placeholder vmmpci device that will be used for VMD passthrough PCI. Normally the device will fail to attach unless the PCI domain:bus.dev.func has been registered with vmmpci_add. When the device is registered, it will detach any existing PCI device and reload as vmmpci. It also att

Re: acme-client: improve account creation error message

2020-09-15 Thread Demi M. Obenour
On 2020-09-15 04:25, Florian Obser wrote: > On Mon, Sep 14, 2020 at 04:26:20PM -0500, Rafael Possamai wrote: >>> please dont drop the all buffer , or keep it with -vv ? >>> example : warnx("%s: bad JSON object:%s", p->newaccount, c->buf.buf); >>> >>> i don't want to ktrace it to see why the new cer

Re: curproc vs MP vs locking

2020-09-15 Thread Claudio Jeker
On Tue, Sep 15, 2020 at 04:38:45PM +0200, Mark Kettenis wrote: > > Date: Tue, 15 Sep 2020 12:34:07 +0200 > > From: Martin Pieuchot > > > > Many functions in the kernel take a "struct proc *" as argument. When > > reviewing diffs or reading the signature of such functions it is not > > clear if t

Re: cap_mkdb: remove igetnext prototype for the function does not exist

2020-09-15 Thread Todd C . Miller
On Tue, 15 Sep 2020 11:35:13 +0800, Kevin Lo wrote: > ok? OK millert@ - todd

Re: curproc vs MP vs locking

2020-09-15 Thread Mark Kettenis
> Date: Tue, 15 Sep 2020 12:34:07 +0200 > From: Martin Pieuchot > > Many functions in the kernel take a "struct proc *" as argument. When > reviewing diffs or reading the signature of such functions it is not > clear if this pointer can be any thread or if it is, like in many cases, > pointing t

Re: sigabort(), p_sigmask & p_siglist

2020-09-15 Thread Claudio Jeker
On Tue, Sep 15, 2020 at 12:52:40PM +0200, Martin Pieuchot wrote: > Diff below introduces an helper for sending an uncatchable SIGABRT and > annotate that `p_siglist' and `p_sigmask' are updated using atomic > operations. > > As a result setsigvec() becomes local to kern/kern_sig.c. > > Note that

Re: diff: pfctl: error message for nonexisting rtable

2020-09-15 Thread Klemens Nanni
On Tue, Sep 15, 2020 at 12:42:27PM +0900, YASUOKA Masahiko wrote: > It's not clear for me why non-existing rdomain is accepted but > non-existing rtable is rejected. I suppose we can make pf(4) can > handle a packet for the non-existing routing table as if the routing > table is empty. Probably po

sigabort(), p_sigmask & p_siglist

2020-09-15 Thread Martin Pieuchot
Diff below introduces an helper for sending an uncatchable SIGABRT and annotate that `p_siglist' and `p_sigmask' are updated using atomic operations. As a result setsigvec() becomes local to kern/kern_sig.c. Note that other places in the kernel use sigexit(p, SIGABRT) for the same purpose and are

curproc vs MP vs locking

2020-09-15 Thread Martin Pieuchot
Many functions in the kernel take a "struct proc *" as argument. When reviewing diffs or reading the signature of such functions it is not clear if this pointer can be any thread or if it is, like in many cases, pointing to `curproc'. This distinction matters when it comes to reading/writing memb

Re: trunk: keep interface up on port removal

2020-09-15 Thread Klemens Nanni
On Mon, Sep 14, 2020 at 10:57:16AM +0200, Klemens Nanni wrote: > I tested removing a single port from trunk and observed that both > interfaces do end up with the same MAC address, but this happens without > my diff already - I still don't see any behaviour after my diff wrt. MAC > addresses or any

Re: agentx in services

2020-09-15 Thread Theo de Raadt
Absolutely. Having it in the file also makes sure that early call to rresvport(3), bindresvport(3), or bindresvport_sa(3) won't allocate it before the daemon is started locally. Martijn van Duren wrote: > I currently don't see any reason for adding agentx over tcp support to > our daemons, but

agentx in services

2020-09-15 Thread Martijn van Duren
I currently don't see any reason for adding agentx over tcp support to our daemons, but according to RFC2741 section 8.1.1 it should go over "wel-known port 705". Worth adding or just drop it? martijn@ Index: services === RCS file:

Re: agentx and clang static analyzer

2020-09-15 Thread Martijn van Duren
> > Index: subagentx.c > > === > > RCS file: /cvs/src/usr.sbin/relayd/subagentx.c,v > > retrieving revision 1.1 > > diff -u -p -r1.1 subagentx.c > > --- subagentx.c 14 Sep 2020 11:30:25 - 1.1 > > +++ subagentx.c 15 Sep

Re: agentx and clang static analyzer

2020-09-15 Thread Bob Beck
On Tue, Sep 15, 2020 at 11:08:04AM +0200, Martijn van Duren wrote: > There are 3 things that actually look like valid complaints when running > clang's static analyzer. > > 1) A dead store in agentx_recv. > 2) sizeof(ipaddress) intead of sizeof(*ipaddress). Since this is ipv4, >this is only a

agentx and clang static analyzer

2020-09-15 Thread Martijn van Duren
There are 3 things that actually look like valid complaints when running clang's static analyzer. 1) A dead store in agentx_recv. 2) sizeof(ipaddress) intead of sizeof(*ipaddress). Since this is ipv4, this is only a problem if sizeof(pointer) is smaller then 4 bytes, which can't happen afaik

Re: acme-client: improve account creation error message

2020-09-15 Thread Florian Obser
On Mon, Sep 14, 2020 at 04:26:20PM -0500, Rafael Possamai wrote: > >please dont drop the all buffer , or keep it with -vv ? > >example : warnx("%s: bad JSON object:%s", p->newaccount, c->buf.buf); > > > >i don't want to ktrace it to see why the new certbot version is not working > > Yeah, I think

Re: PATCH: Add ACPI IVHD_EXT structure to acpireg.h

2020-09-15 Thread Mark Kettenis
> Date: Tue, 15 Sep 2020 01:37:33 -0500 > From: Jordan Hargrave > > This patch adds a couple of entries for AMD IOMMU structure > definitions in ACPI ok kettenis@ > Index: acpireg.h > === > RCS file: /cvs/src/sys/dev/acpi/acpireg.h