Re: fdisk: make use of getline(3)

2021-01-30 Thread Todd C . Miller
On Sat, 30 Jan 2021 18:02:10 +0100, Christian Weisgerber wrote: > Replace fgetln(3) with getline(3). OK millert@ - todd

Re: uhidpp(4): logitech hid++ device driver

2021-01-30 Thread Ville Valkonen
On Sat, 2021-01-30 at 13:18 +0200, Ville Valkonen wrote: > On Sat, 2021-01-30 at 08:36 +0100, Anton Lindqvist wrote: > > On Fri, Jan 29, 2021 at 10:15:05PM +0200, Ville Valkonen wrote: > > > Hi, > > > > > > I have a bit oldish Logitech M705 mouse, bought around 2010-2011. > > > Regarding the

Re: disklabel: pointer deref fix

2021-01-30 Thread Todd C . Miller
On Sat, 30 Jan 2021 01:01:37 +0100, Christian Weisgerber wrote: > Fix a pointer dereference in disklabel(8). > > This looks like somebody wrote *s[0] in place of (*s)[0]. > Which in this case happens to be equivalent, but it still looks > wrong. Probably my bug. OK millert@ - todd

Re: sed: make use of getline(3)

2021-01-30 Thread Todd C . Miller
On Sat, 30 Jan 2021 00:43:02 +0100, Christian Weisgerber wrote: > Replace fgetln(3) with getline(3) in sed. > > The mf_fgets() part is from Johann Oskarsson for Illumos/FreeBSD. > > Passes our sed regression tests. OK millert@ - todd

fdisk: make use of getline(3)

2021-01-30 Thread Christian Weisgerber
Replace fgetln(3) with getline(3). OK? Index: sbin/fdisk/misc.c === RCS file: /cvs/src/sbin/fdisk/misc.c,v retrieving revision 1.63 diff -u -p -r1.63 misc.c --- sbin/fdisk/misc.c 3 Jul 2019 03:24:01 - 1.63 +++

Re: ftp: make use of getline(3)

2021-01-30 Thread Hiltjo Posthuma
On Sat, Jan 30, 2021 at 11:57:01AM +0100, Claudio Jeker wrote: > On Sat, Jan 30, 2021 at 11:52:15AM +0100, Hiltjo Posthuma wrote: > > On Sat, Jan 30, 2021 at 12:22:04AM +0100, Christian Weisgerber wrote: > > > Hiltjo Posthuma: > > > > > > > > @@ -75,19 +74,8 @@ cookie_load(void) > > > > >

Re: uhidpp(4): logitech hid++ device driver

2021-01-30 Thread Ville Valkonen
On Sat, 2021-01-30 at 08:36 +0100, Anton Lindqvist wrote: > On Fri, Jan 29, 2021 at 10:15:05PM +0200, Ville Valkonen wrote: > > Hi, > > > > I have a bit oldish Logitech M705 mouse, bought around 2010-2011. > > Regarding the dmesg (on below) I can see it gets attached correctly > > to > > uhiddp0

Re: sndiod: Move controls out of the device structure, please test & review

2021-01-30 Thread Edd Barrett
On Fri, Jan 29, 2021 at 04:16:44PM +0100, Alexandre Ratchov wrote: > Thanks for the feedback, new diff below. It fixes a server crash when > a client issues an invalid request. I retested the crash scenario, and can confirm that it is fixed. No other problems to report! -- Best Regards Edd

Re: ftp: make use of getline(3)

2021-01-30 Thread Claudio Jeker
On Sat, Jan 30, 2021 at 11:52:15AM +0100, Hiltjo Posthuma wrote: > On Sat, Jan 30, 2021 at 12:22:04AM +0100, Christian Weisgerber wrote: > > Hiltjo Posthuma: > > > > > > @@ -75,19 +74,8 @@ cookie_load(void) > > > > if (fp == NULL) > > > > err(1, "cannot open cookie file

Re: ftp: make use of getline(3)

2021-01-30 Thread Hiltjo Posthuma
On Sat, Jan 30, 2021 at 12:22:04AM +0100, Christian Weisgerber wrote: > Hiltjo Posthuma: > > > > @@ -75,19 +74,8 @@ cookie_load(void) > > > if (fp == NULL) > > > err(1, "cannot open cookie file %s", cookiefile); > > > date = time(NULL); > > > - lbuf = NULL; > > > - while ((line =